Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21556
thanks, merging to master!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21556
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93017/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21556
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21556
**[Test build #93017 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93017/testReport)**
for PR 21556 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21556
**[Test build #93017 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93017/testReport)**
for PR 21556 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21556
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21556
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/963/
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/21556
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21556
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93014/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21556
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21556
**[Test build #93014 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93014/testReport)**
for PR 21556 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21556
**[Test build #93014 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93014/testReport)**
for PR 21556 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21556
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/960/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21556
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user rdblue commented on the issue:
https://github.com/apache/spark/pull/21556
I misunderstood how it was safe as well. It was Yuming's clarification that
helped.
---
-
To unsubscribe, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21556
@rdblue, ah, I misunderstood then. thanks for clarifying it.
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21556
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21556
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92996/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21556
**[Test build #92996 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92996/testReport)**
for PR 21556 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21556
**[Test build #92996 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92996/testReport)**
for PR 21556 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21556
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/946/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21556
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/21556
cc @gatorsmile @cloud-fan @gengliangwang @michal-databricks
@mswit-databricks
---
-
To unsubscribe, e-mail:
Github user rdblue commented on the issue:
https://github.com/apache/spark/pull/21556
+1, I think this looks ready to go.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user rdblue commented on the issue:
https://github.com/apache/spark/pull/21556
@HyukjinKwon, even if the values are null, the makeEq function only casts
null to Java Integer so the handling is still safe. It just looks odd that
`null.asInstanceOf[JInt]` is safe. Thanks to
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21556
@rdblue, so basically you mean it looks both equality comparison and
nullsafe equality comparison are identically pushed down and looks it should be
distinguished; otherwise, there could be a
Github user rdblue commented on the issue:
https://github.com/apache/spark/pull/21556
@wangyum, can you explain what was happening with the `decimal(9,2)`
benchmark more clearly? I asked additional questions, but the thread is on a
line that changed so it's collapsed by default.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21556
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21556
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92938/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21556
**[Test build #92938 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92938/testReport)**
for PR 21556 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21556
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21556
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92936/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21556
**[Test build #92936 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92936/testReport)**
for PR 21556 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21556
**[Test build #92938 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92938/testReport)**
for PR 21556 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21556
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21556
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/900/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21556
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21556
**[Test build #92936 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92936/testReport)**
for PR 21556 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21556
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/898/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21556
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21556
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92843/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21556
**[Test build #92843 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92843/testReport)**
for PR 21556 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21556
**[Test build #92843 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92843/testReport)**
for PR 21556 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21556
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/836/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21556
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/21556
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21556
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21556
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92837/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21556
**[Test build #92837 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92837/testReport)**
for PR 21556 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21556
**[Test build #92837 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92837/testReport)**
for PR 21556 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21556
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21556
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/834/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21556
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92710/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21556
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21556
**[Test build #92710 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92710/testReport)**
for PR 21556 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21556
**[Test build #92710 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92710/testReport)**
for PR 21556 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21556
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/748/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21556
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21556
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21556
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92683/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21556
**[Test build #92683 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92683/testReport)**
for PR 21556 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21556
**[Test build #92683 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92683/testReport)**
for PR 21556 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21556
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21556
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/729/
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/21556
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21556
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21556
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92675/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21556
**[Test build #92675 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92675/testReport)**
for PR 21556 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21556
**[Test build #92675 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92675/testReport)**
for PR 21556 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21556
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21556
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/723/
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/21556
@dongjoon-hyun benchmark code:
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/21556
Thanks for pinging me. @maropu . I'd like to see the benchmark code.
> In the benchmarks above, the results of ORC except for the case
decimal(9, 2) have worse performance values as
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21556
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92641/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21556
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21556
**[Test build #92641 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92641/testReport)**
for PR 21556 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21556
**[Test build #92641 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92641/testReport)**
for PR 21556 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21556
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/702/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21556
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21556
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21556
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92619/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21556
**[Test build #92619 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92619/testReport)**
for PR 21556 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21556
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/681/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21556
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21556
**[Test build #92619 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92619/testReport)**
for PR 21556 at commit
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21556
@wangyum Thanks for the benchmarks!
@dongjoon-hyun In the benchmarks above, the results of ORC except for the
case `decimal(9, 2)` have worse performance values as compared to the Parquet
ones.
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/21556
Benchmark results:
```
###[ Pushdown benchmark for Decimal
]
Java HotSpot(TM) 64-Bit Server VM 1.8.0_151-b12 on Mac OS X
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21556
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21556
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92414/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21556
**[Test build #92414 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92414/testReport)**
for PR 21556 at commit
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21556
Can you benchmark code and results (on your env) in
`FilterPushdownBenchmark` for this type?
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21556
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/538/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21556
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21556
**[Test build #92414 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92414/testReport)**
for PR 21556 at commit
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/21556
Jenkins, retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21556
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92413/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21556
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21556
**[Test build #92413 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92413/testReport)**
for PR 21556 at commit
98 matches
Mail list logo
