Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21921
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93887/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21921
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21921
**[Test build #93887 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93887/testReport)**
for PR 21921 at commit
Github user rdblue commented on the issue:
https://github.com/apache/spark/pull/21921
Yeah, I'd say that if it isn't documented then lets go with the usually RTC
conventions.
---
-
To unsubscribe, e-mail:
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21921
addressed in
https://github.com/apache/spark/pull/21948#discussion_r206999480
---
-
To unsubscribe, e-mail:
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21921
It sounds like Github is experiencing a very bad delay. @cloud-fan Could
you submit a follow-up PR to address the comments from @rdblue ?
---
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21921
@rdblue I do not think it is documented. Let us be more conservative.
Collect LGTM from the committers no matter whether the PR author is a committer
or not.
---
Github user rdblue commented on the issue:
https://github.com/apache/spark/pull/21921
@cloud-fan, @gatorsmile, I'm fine with that if it's documented somewhere. I
wasn't aware of that convention and no one brought it up the last time I
pointed out commits without a committer +1.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21921
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21921
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21921
**[Test build #93887 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93887/testReport)**
for PR 21921 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21921
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21921
@cloud-fan To be save, let us get one more LGTM from the other committer.
---
-
To unsubscribe, e-mail:
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21921
@rdblue I vaguely remember that, if the PR author himself is a committer,
we can merge a PR with one more LGTM from the community and no one objects in
several days. I'm sorry if it's not the
Github user rdblue commented on the issue:
https://github.com/apache/spark/pull/21921
This looks fine other than the possibly unnecessary cast.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user rdblue commented on the issue:
https://github.com/apache/spark/pull/21921
@cloud-fan, I thought it was a requirement to have a committer +1 before
merging. Or is this [list of
committers](https://spark.apache.org/committers.html) out of date?
---
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21921
thanks, merging to master!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user jose-torres commented on the issue:
https://github.com/apache/spark/pull/21921
lgtm
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21921
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21921
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93796/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21921
**[Test build #93796 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93796/testReport)**
for PR 21921 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21921
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21921
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21921
**[Test build #93796 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93796/testReport)**
for PR 21921 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21921
cc @rdblue @rxin @gatorsmile @gengliangwang
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
25 matches
Mail list logo
