Github user rezasafi commented on the issue:
https://github.com/apache/spark/pull/22325
Thank you very much @vanzin @jiangxb1987
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/22325
Merging to master / 2.4.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/22325
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22325
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96581/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22325
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22325
**[Test build #96581 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96581/testReport)**
for PR 22325 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22325
**[Test build #96581 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96581/testReport)**
for PR 22325 at commit
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/22325
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22325
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22325
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96565/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22325
**[Test build #96565 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96565/testReport)**
for PR 22325 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22325
**[Test build #96565 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96565/testReport)**
for PR 22325 at commit
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/22325
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22325
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96522/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22325
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22325
**[Test build #96522 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96522/testReport)**
for PR 22325 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22325
**[Test build #96522 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96522/testReport)**
for PR 22325 at commit
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/22325
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user rezasafi commented on the issue:
https://github.com/apache/spark/pull/22325
The above test build is not working. I know that that there was a problem
with jenkins earlier today. I appreciate if one of the committers fire another
test when they think the problem is
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22325
**[Test build #4348 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4348/testReport)**
for PR 22325 at commit
Github user rezasafi commented on the issue:
https://github.com/apache/spark/pull/22325
Jenkins, retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user rezasafi commented on the issue:
https://github.com/apache/spark/pull/22325
Flaky again. retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22325
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22325
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96370/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22325
**[Test build #96370 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96370/testReport)**
for PR 22325 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22325
**[Test build #96370 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96370/testReport)**
for PR 22325 at commit
Github user rezasafi commented on the issue:
https://github.com/apache/spark/pull/22325
Looking at the unit-test.log and stacktrace the failed test doesn't seem to
be related to this change. There is errors like this
`18/09/19 20:47:53.776 shuffle-server-4270-1 ERROR
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22325
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22325
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96315/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22325
**[Test build #96315 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96315/testReport)**
for PR 22325 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22325
**[Test build #96315 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96315/testReport)**
for PR 22325 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22325
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96285/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22325
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22325
**[Test build #96285 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96285/testReport)**
for PR 22325 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22325
**[Test build #96285 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96285/testReport)**
for PR 22325 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22325
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96265/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22325
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22325
**[Test build #96265 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96265/testReport)**
for PR 22325 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22325
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22325
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96269/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22325
**[Test build #96269 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96269/testReport)**
for PR 22325 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22325
**[Test build #96269 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96269/testReport)**
for PR 22325 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22325
**[Test build #96267 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96267/testReport)**
for PR 22325 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22325
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22325
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96267/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22325
**[Test build #96267 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96267/testReport)**
for PR 22325 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22325
**[Test build #96265 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96265/testReport)**
for PR 22325 at commit
Github user rezasafi commented on the issue:
https://github.com/apache/spark/pull/22325
@vanzin well I will send the updated PR as soon as I can finish more tests
and that way my concern of breaking stuff will be more clear.
I think no change will be merged by committers if I
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/22325
Or maybe the test needs to be updated. Either way, not a reason not to
merge your changes with the existing code.
---
-
To
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/22325
If the test fails with your change you're introducing a change of behavior
that breaks things, and you should fix it.
I don't see why that is a reason for not merging both code paths.
Github user rezasafi commented on the issue:
https://github.com/apache/spark/pull/22325
it seems that it is safer to not merge the two exception handling, since
doing that will require moving around or removing some val that isn't clear why
are there. Merging and removing
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22325
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95726/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22325
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22325
**[Test build #95726 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95726/testReport)**
for PR 22325 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22325
**[Test build #95726 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95726/testReport)**
for PR 22325 at commit
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/22325
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22325
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22325
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22325
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
59 matches
Mail list logo
