[GitHub] spark issue #22471: [SPARK-25469][SQL][Performance] Eval methods of Concat, ...

2018-09-21 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/22471 away from keyboard now, so will do when I’m back. Thank! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #22471: [SPARK-25469][SQL][Performance] Eval methods of Concat, ...

2018-09-21 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/22471 @maropu Do you want to merge this as your first work as a committer? I think this can be merged into master/2.4 because this is a performance regression fix. ---

[GitHub] spark issue #22471: [SPARK-25469][SQL][Performance] Eval methods of Concat, ...

2018-09-20 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/22471 LGTM Btw, we don't need `[Performance]` in the title, probably. --- - To unsubscribe, e-mail:

[GitHub] spark issue #22471: [SPARK-25469][SQL][Performance] Eval methods of Concat, ...

2018-09-20 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/22471 ok --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22471: [SPARK-25469][SQL][Performance] Eval methods of Concat, ...

2018-09-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22471 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96340/ Test PASSed. ---

[GitHub] spark issue #22471: [SPARK-25469][SQL][Performance] Eval methods of Concat, ...

2018-09-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22471 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22471: [SPARK-25469][SQL][Performance] Eval methods of Concat, ...

2018-09-20 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22471 **[Test build #96340 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96340/testReport)** for PR 22471 at commit

[GitHub] spark issue #22471: [SPARK-25469][SQL][Performance] Eval methods of Concat, ...

2018-09-20 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/22471 @maropu Could you take a look at this again please? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #22471: [SPARK-25469][SQL][Performance] Eval methods of Concat, ...

2018-09-20 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/22471 LGTM. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: