Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22683
In this case the change is simpler to understand in prose, I think; "100
KB" becomes "97.6 KiB", etc.
---
-
To unsubscribe,
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22683
Looks okay to me too. UI change requires screenshots of UI tho strictly.
---
-
To unsubscribe, e-mail:
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22683
Fortunately the syntax is "100m", which has always meant "100 * 1024 *
1024" or "100 MiB"
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22683
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99827/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22683
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22683
**[Test build #99827 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99827/testReport)**
for PR 22683 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22683
**[Test build #99827 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99827/testReport)**
for PR 22683 at commit
Github user heary-cao commented on the issue:
https://github.com/apache/spark/pull/22683
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user httfighter commented on the issue:
https://github.com/apache/spark/pull/22683
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22683
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22683
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99806/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22683
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99810/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22683
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99815/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22683
**[Test build #99813 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99813/testReport)**
for PR 22683 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22683
**[Test build #99810 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99810/testReport)**
for PR 22683 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22683
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22683
**[Test build #99807 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99807/testReport)**
for PR 22683 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22683
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22683
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22683
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99807/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22683
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22683
**[Test build #99815 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99815/testReport)**
for PR 22683 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22683
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99813/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22683
**[Test build #99806 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99806/testReport)**
for PR 22683 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22683
**[Test build #99815 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99815/testReport)**
for PR 22683 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22683
**[Test build #99813 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99813/testReport)**
for PR 22683 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22683
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99811/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22683
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22683
**[Test build #99811 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99811/testReport)**
for PR 22683 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22683
**[Test build #99811 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99811/testReport)**
for PR 22683 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22683
**[Test build #99810 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99810/testReport)**
for PR 22683 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22683
**[Test build #99807 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99807/testReport)**
for PR 22683 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22683
**[Test build #99806 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99806/testReport)**
for PR 22683 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22683
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22683
**[Test build #99763 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99763/testReport)**
for PR 22683 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22683
**[Test build #99763 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99763/testReport)**
for PR 22683 at commit
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/22683
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user httfighter commented on the issue:
https://github.com/apache/spark/pull/22683
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22683
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22683
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99700/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22683
**[Test build #99700 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99700/testReport)**
for PR 22683 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22683
**[Test build #99700 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99700/testReport)**
for PR 22683 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22683
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99695/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22683
Build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22683
**[Test build #99695 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99695/testReport)**
for PR 22683 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22683
Build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22683
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99696/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22683
**[Test build #99696 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99696/testReport)**
for PR 22683 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22683
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99693/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22683
Build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22683
**[Test build #99693 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99693/testReport)**
for PR 22683 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22683
**[Test build #99696 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99696/testReport)**
for PR 22683 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22683
**[Test build #99695 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99695/testReport)**
for PR 22683 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22683
**[Test build #99693 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99693/testReport)**
for PR 22683 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22683
**[Test build #4450 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4450/testReport)**
for PR 22683 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22683
**[Test build #4450 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4450/testReport)**
for PR 22683 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22683
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22683
**[Test build #99611 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99611/testReport)**
for PR 22683 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22683
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99611/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22683
**[Test build #99611 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99611/testReport)**
for PR 22683 at commit
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22683
Add to this PR. The change goes logically together.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user httfighter commented on the issue:
https://github.com/apache/spark/pull/22683
@srowen Yes. I agree with you! These places should be consistent, otherwise
it is easy to be confused. I will try to modify log statements and docs.
Should I modify it in this PR or a new one?
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22683
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99565/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22683
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22683
**[Test build #99565 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99565/testReport)**
for PR 22683 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22683
**[Test build #99565 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99565/testReport)**
for PR 22683 at commit
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/22683
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user httfighter commented on the issue:
https://github.com/apache/spark/pull/22683
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22683
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22683
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99550/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22683
**[Test build #99550 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99550/testReport)**
for PR 22683 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22683
**[Test build #99550 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99550/testReport)**
for PR 22683 at commit
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/22683
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22683
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99544/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22683
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22683
**[Test build #99544 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99544/testReport)**
for PR 22683 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22683
**[Test build #99544 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99544/testReport)**
for PR 22683 at commit
Github user httfighter commented on the issue:
https://github.com/apache/spark/pull/22683
@srowen Sorry, I just saw your message. I am a little busy on weekdays. I
will try to modify the test cases in recent days.
---
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22683
Ping @httfighter
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22683
Yeah, there are going to be several more tests that fail because they are
expecting a string like 'KB'. Hopefully easy to fix.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22683
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99226/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22683
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22683
**[Test build #99226 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99226/testReport)**
for PR 22683 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22683
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user httfighter commented on the issue:
https://github.com/apache/spark/pull/22683
@srowen@ajbozarth I have added the changes, could you help me review the
code? Thank you very much.
---
-
To unsubscribe,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22683
**[Test build #99226 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99226/testReport)**
for PR 22683 at commit
Github user httfighter commented on the issue:
https://github.com/apache/spark/pull/22683
@srowen OK. Thank you very much for your advice.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22683
I believe most of the Spark code really uses units like KiB, multiples of
1024, as you see here. However it's often referred to as KB, incorrectly, and
so on. It seems like the UI is the only place
Github user httfighter commented on the issue:
https://github.com/apache/spark/pull/22683
@srowen @ajbozarth I am not sure about some things, can you give me some
advice? In the process of modification, I have a question. In Spark, whether M
and MB represent MiB. Spark does not use
Github user httfighter commented on the issue:
https://github.com/apache/spark/pull/22683
@srowen Thank you for your review. I agree with you, and I will make
changes in the near future.
@wangyum Thank you for your help.
---
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/22683
@srowen Thanks for ping me. I agree with you. If @httfighter willing,
updating all usages in the UI to indicate units like `KiB`, `MiB`, `GiB`.
@httfighter you can check details here:
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22683
@wangyum @httfighter what do you think?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22683
Heh this change is actually narrowly wrong, but, is correct and needs to be
larger in a broader sense.
1000 is the right factor for KB = kilobytes. 1024 is the right factor for
KiB =
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/22683
cc @srowen Cloud we merge this PR?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user httfighter commented on the issue:
https://github.com/apache/spark/pull/22683
It's ok. @ajbozarth
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22683
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98432/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22683
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22683
**[Test build #98432 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98432/testReport)**
for PR 22683 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22683
**[Test build #98432 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98432/testReport)**
for PR 22683 at commit
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/22683
Jenkins, ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
1 - 100 of 104 matches
Mail list logo
