Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22938
Sorry for the late response. The change looks good to me in general but I
had one question.
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22938
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22938
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99144/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22938
**[Test build #99144 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99144/testReport)**
for PR 22938 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22938
thanks, merging to master!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22938
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99143/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22938
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22938
**[Test build #99143 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99143/testReport)**
for PR 22938 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22938
**[Test build #99144 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99144/testReport)**
for PR 22938 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22938
**[Test build #99143 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99143/testReport)**
for PR 22938 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22938
LGTM except the migration guide. JSON data source can't produce null rows,
but skip it even with permisive mode.
---
-
To
Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/22938
@HyukjinKwon @cloud-fan May I ask you to look at this PR one more time.
---
-
To unsubscribe, e-mail:
Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/22938
@cloud-fan @HyukjinKwon Do you agree with the proposed changes, or there is
anything which blocks the PR for now?
---
-
To
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22938
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98701/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22938
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22938
**[Test build #98701 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98701/testReport)**
for PR 22938 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22938
**[Test build #98701 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98701/testReport)**
for PR 22938 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22938
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22938
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98660/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22938
**[Test build #98660 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98660/testReport)**
for PR 22938 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22938
**[Test build #98660 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98660/testReport)**
for PR 22938 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22938
**[Test build #98655 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98655/testReport)**
for PR 22938 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22938
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98655/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22938
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22938
**[Test build #98655 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98655/testReport)**
for PR 22938 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22938
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22938
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98565/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22938
**[Test build #98565 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98565/testReport)**
for PR 22938 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22938
**[Test build #98565 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98565/testReport)**
for PR 22938 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22938
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98555/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22938
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22938
**[Test build #98555 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98555/testReport)**
for PR 22938 at commit
Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/22938
I made a fix for broken array and map in `JsonToStructs` because inside of
`FailureSafeParser` is not clear from where the call came. I am still not sure
that wrapping actual type by `StructType`
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22938
**[Test build #98555 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98555/testReport)**
for PR 22938 at commit
Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/22938
At least it doesn't fail on the cases
https://github.com/apache/spark/pull/22938/files#diff-6626026091295ad8c0dfb66ecbcd04b1R568
and
Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/22938
I guess the problem belongs to `FailureSafeParser`, in particular
Github user attilapiros commented on the issue:
https://github.com/apache/spark/pull/22938
@HyukjinKwon Sure, the test would be for invalid JSON array:
```Scala
test("from_json - input=invalid JSON array, schema=array, output=array") {
val input = """[{"a": 1},
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22938
@attilapiros, mind showing rough small test codes for it please? just want
to see if this is something we should fix or not.
---
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22938
Yea, looks fine in general. Will take a look within this week or weekends.
---
-
To unsubscribe, e-mail:
Github user attilapiros commented on the issue:
https://github.com/apache/spark/pull/22938
@MaxGekk I have checked out your PR and played a little bit with it:
created a new unit test as a copy of "from_json - input=array, schema=array,
output=array" with an invalid JSON.
I
Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/22938
@HyukjinKwon Are you ok with the changes?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22938
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22938
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98527/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22938
**[Test build #98527 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98527/testReport)**
for PR 22938 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22938
**[Test build #98527 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98527/testReport)**
for PR 22938 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22938
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98452/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22938
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22938
**[Test build #98452 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98452/testReport)**
for PR 22938 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22938
**[Test build #98452 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98452/testReport)**
for PR 22938 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22938
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22938
**[Test build #98448 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98448/testReport)**
for PR 22938 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22938
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98448/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22938
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22938
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98444/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22938
**[Test build #98444 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98444/testReport)**
for PR 22938 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22938
**[Test build #98448 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98448/testReport)**
for PR 22938 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22938
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22938
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98439/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22938
**[Test build #98439 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98439/testReport)**
for PR 22938 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22938
**[Test build #98444 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98444/testReport)**
for PR 22938 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22938
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22938
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22938
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22938
add to whitelist
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22938
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22938
**[Test build #98439 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98439/testReport)**
for PR 22938 at commit
66 matches
Mail list logo
