Github user heary-cao commented on the issue:
https://github.com/apache/spark/pull/23084
@cloud-fan,thanks
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/23084
thanks, merging to master!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/23084
I think it's safer to only catch the spark-thrown OOM, not the system OOM,
so LGTM
---
-
To unsubscribe, e-mail:
Github user heary-cao commented on the issue:
https://github.com/apache/spark/pull/23084
so this PR is just code cleanup, not a real bug. thanks.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user heary-cao commented on the issue:
https://github.com/apache/spark/pull/23084
I think `growAndRehash` always thrown `SparkOutOfMemoryError`. catch
`SparkOutOfMemoryError` or `OutOfMemoryError` will make `canGrowArray = false`.
please correct if i understand something
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/23084
> for example, HashAggregateExec will carry out spill the map and fallback
to sort-based
Do you mean this patch change nothing for this case?
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23084
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99046/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23084
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23084
**[Test build #99046 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99046/testReport)**
for PR 23084 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23084
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23084
**[Test build #99046 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99046/testReport)**
for PR 23084 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23084
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user heary-cao commented on the issue:
https://github.com/apache/spark/pull/23084
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23084
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99045/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23084
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23084
**[Test build #99045 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99045/testReport)**
for PR 23084 at commit
Github user heary-cao commented on the issue:
https://github.com/apache/spark/pull/23084
@cloud-fan, I think not kill executor. the memory allocate fails, and the
caller is notified to perform other operations. for example, HashAggregateExec
will carry out spill the map and fallback
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23084
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23084
**[Test build #99045 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99045/testReport)**
for PR 23084 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23084
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23084
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99002/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23084
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23084
**[Test build #99002 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99002/testReport)**
for PR 23084 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23084
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23084
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99006/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23084
**[Test build #99006 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99006/testReport)**
for PR 23084 at commit
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/23084
I think that we need to take care of
`UnsafeExternalSorterSuite.testGetIterator`, too.
---
-
To unsubscribe, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23084
**[Test build #99006 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99006/testReport)**
for PR 23084 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23084
**[Test build #99002 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99002/testReport)**
for PR 23084 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23084
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23084
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/23084
good catch! thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/23084
add to whitelist
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/23084
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user heary-cao commented on the issue:
https://github.com/apache/spark/pull/23084
cc @cloud-fan @kiszk @dongjoon-hyun
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23084
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23084
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
37 matches
Mail list logo
