Github user srowen commented on the issue:
https://github.com/apache/spark/pull/23150
Merged to master
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23150
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23150
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99608/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23150
**[Test build #99608 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99608/testReport)**
for PR 23150 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23150
**[Test build #4449 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4449/testReport)**
for PR 23150 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23150
**[Test build #4449 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4449/testReport)**
for PR 23150 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23150
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23150
**[Test build #99608 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99608/testReport)**
for PR 23150 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23150
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/23150
@srowen I think this PR is ready.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23150
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23150
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99575/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23150
**[Test build #99575 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99575/testReport)**
for PR 23150 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23150
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23150
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23150
**[Test build #99575 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99575/testReport)**
for PR 23150 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23150
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99556/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23150
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23150
**[Test build #99556 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99556/testReport)**
for PR 23150 at commit
Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/23150
> they pass right? is there another test you were unable to add?
For now everything has been passed. I run all test localy on different
timezones (set via jvm parameter `-Duser.timezone`).
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23150
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23150
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23150
**[Test build #99556 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99556/testReport)**
for PR 23150 at commit
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/23150
It makes sense that parsing depends on a timezone, though that's set as an
option in the parser typically. The tests should generally test "GMT" for this
reason. If there's a default code path for
Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/23150
> ... if it's ready from your side @MaxGekk
@srowen I just think how I could reduce number of changes in tests. In some
cases, test behavior depends on current time zone on my laptop.
Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/23150
@HyukjinKwon May I ask you to look at this PR.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23150
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23150
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99510/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23150
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23150
**[Test build #99510 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99510/testReport)**
for PR 23150 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23150
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23150
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23150
**[Test build #99510 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99510/testReport)**
for PR 23150 at commit
Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/23150
jenkins, retest this, please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23150
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23150
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99507/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23150
**[Test build #99507 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99507/testReport)**
for PR 23150 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23150
**[Test build #99507 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99507/testReport)**
for PR 23150 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23150
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23150
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23150
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99447/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23150
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23150
**[Test build #99447 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99447/testReport)**
for PR 23150 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23150
**[Test build #99447 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99447/testReport)**
for PR 23150 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23150
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23150
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/23150
Looks like that kind of fallback logic was there for compatibility with
Spark 1.x and 2.0; see some comments about 'backwards compatibility' in for
example
Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/23150
Some tests didn't pass on new changes till I set time zone explicitly. The
tests use the same functions for checking correctness as the code that is
supposed to test. I think need more
Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/23150
I have to correct timestamp/date pattern in a few test to follow ISO 8601
(see [Patterns for Formatting and
Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/23150
> Are there any other behavior changes with the new code, besides being
able to parse microseconds?
The main one is new parser doesn't have the fallback to
`DateTimeUtils.stringToTime` if
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/23150
The code looks good at a glance. So the flag lets people select the old
behavior; that keeps it pretty safe. Are there any other behavior changes with
the new code, besides being able to parse
Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/23150
@srowen @HyukjinKwon @viirya @mgaido91 May I ask you to look at the PR. The
changes are related to another PR which you have reviewed already.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23150
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23150
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99327/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23150
**[Test build #99327 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99327/testReport)**
for PR 23150 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23150
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23150
**[Test build #99327 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99327/testReport)**
for PR 23150 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23150
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/23150
jenkins, retest this, please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23150
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99316/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23150
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23150
**[Test build #99316 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99316/testReport)**
for PR 23150 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23150
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23150
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23150
**[Test build #99316 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99316/testReport)**
for PR 23150 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23150
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99296/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23150
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23150
**[Test build #99296 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99296/testReport)**
for PR 23150 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23150
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23150
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23150
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23150
**[Test build #99296 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99296/testReport)**
for PR 23150 at commit
72 matches
Mail list logo
