Github user JkSelf commented on the issue:
https://github.com/apache/spark/pull/23204
@cloud-fan the new ticket is in
[here](https://github.com/apache/spark/pull/23269 ). I will close this ticket.
---
-
To
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23204
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23204
**[Test build #99894 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99894/testReport)**
for PR 23204 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23204
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99894/
Test FAILed.
---
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/23204
can we follow
https://github.com/apache/spark/pull/23204#issuecomment-445510026 and create a
new ticket?
---
-
To
Github user LuciferYang commented on the issue:
https://github.com/apache/spark/pull/23204
ok~ already close #23214
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user JkSelf commented on the issue:
https://github.com/apache/spark/pull/23204
@cloud-fan @dongjoon-hyun update the patch, please help review if you have
time. Thanks.
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23204
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23204
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23204
**[Test build #99894 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99894/testReport)**
for PR 23204 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/23204
If we can quickly finish #23214 (within several days), let's go for it. But
if we can't, I'd suggest we do the partial revert first to fix the perf
regression, and add back the metrics later.
Github user LuciferYang commented on the issue:
https://github.com/apache/spark/pull/23204
@cloud-fan If we decide to partial revert SPARK-21052 and no need for
#23214, I will close it.
---
-
To unsubscribe,
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/23204
+1
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23204
@cloud-fan and @JkSelf .
For the partial revert, we had better create a new Apache JIRA issue. That
will be a more cleaner way to backport.
---
Github user JkSelf commented on the issue:
https://github.com/apache/spark/pull/23204
@cloud-fan ok, i will revert as your comments later.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user JkSelf commented on the issue:
https://github.com/apache/spark/pull/23204
The result of all queries in tpcds with 1TB data scale is in [tpcds
result](https://docs.google.com/spreadsheets/d/18a5BdOlmm8euTaRodyeWum9yu92mbWWu6JbhGXtr7yE/edit#gid=0)
---
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/23204
according to
https://github.com/apache/spark/pull/23214#issuecomment-443999282 , the hash
join metrics is wrongly implemented. I think it's fine to revert it and
re-implement it later.
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23204
Hi, @LuciferYang . If we are not going to revert this, could you close this
PR?
---
-
To unsubscribe, e-mail:
Github user LuciferYang commented on the issue:
https://github.com/apache/spark/pull/23204
@cloud-fan @viirya #23214 maybe reslove this problem and we needn't revert
this patch.
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23204
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99615/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23204
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23204
**[Test build #99615 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99615/testReport)**
for PR 23204 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23204
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23204
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23204
**[Test build #99615 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99615/testReport)**
for PR 23204 at commit
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/23204
Is this observable in general hash join query, except for TPC-DS Q19?
---
-
To unsubscribe, e-mail:
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/23204
I'm fine to revert it if it caused a significant performance regression, we
should revisit it later, with different ideas, like updating the metrics for
each batch instead of each record.
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/23204
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user JkSelf commented on the issue:
https://github.com/apache/spark/pull/23204
**Cluster info:**
 | Master Node | Worker Nodes
-- | -- | --
Node | 1x | 4x
Processor | Intel(R) Xeon(R) Platinum 8170 CPU @ 2.10GHz | Intel(R) Xeon(R)
Platinum 8180 CPU @
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23204
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23204
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23204
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
32 matches
Mail list logo
