[GitHub] spark issue #23247: [SPARK-26294][CORE]Delete Unnecessary If statement
Github user srowen commented on the issue: https://github.com/apache/spark/pull/23247 Merged to master --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #23247: [SPARK-26294][CORE]Delete Unnecessary If statement
Github user wangjiaochun commented on the issue: https://github.com/apache/spark/pull/23247 ok! thanks, I will focus on commit bug later. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #23247: [SPARK-26294][CORE]Delete Unnecessary If statement
Github user wangjiaochun commented on the issue: https://github.com/apache/spark/pull/23247 > @wangjiaochun, I think you better stop fixing trivial stuff in each PR. Those stuff can be fixed when the codes around here is fixed, or let other people fix it later. ok! thanks, I will focus on commit bug later. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #23247: [SPARK-26294][CORE]Delete Unnecessary If statement
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23247 **[Test build #4456 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4456/testReport)** for PR 23247 at commit [`d5aea03`](https://github.com/apache/spark/commit/d5aea03764159914942eac2d3e5565ee9862424f). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #23247: [SPARK-26294][CORE]Delete Unnecessary If statement
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23247 **[Test build #4456 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4456/testReport)** for PR 23247 at commit [`d5aea03`](https://github.com/apache/spark/commit/d5aea03764159914942eac2d3e5565ee9862424f). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #23247: [SPARK-26294][CORE]Delete Unnecessary If statement
Github user srowen commented on the issue: https://github.com/apache/spark/pull/23247 These aren't worth the time it takes us to review them and merge them, honestly. Little cleanup can be OK if it makes an appreciable difference in speed or readability, and if you can find many instances of the same issue. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #23247: [SPARK-26294][CORE]Delete Unnecessary If statement
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/23247 @wangjiaochun, I think you better stop fixing trivial stuff in each PR. Those stuff can be fixed when the codes around here is fixed, or let other people fix it later. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #23247: [SPARK-26294][CORE]Delete Unnecessary If statement
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23247 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #23247: [SPARK-26294][CORE]Delete Unnecessary If statement
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23247 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #23247: [SPARK-26294][CORE]Delete Unnecessary If statement
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23247 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
