Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/9826
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/9826#issuecomment-158858659
LGTM. Merged into master and branch-1.6. Thanks! (The Jenkins test failure
is irrelevant. The PR build doesn't compile doc anyway. So I verified the
changes on my local
Github user thunterdb commented on the pull request:
https://github.com/apache/spark/pull/9826#issuecomment-158541369
@mengxr comment addressed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9826#issuecomment-15855
**[Test build #46457 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46457/consoleFull)**
for PR 9826 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9826#issuecomment-158566695
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9826#issuecomment-158566697
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9826#issuecomment-158544511
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9826#issuecomment-158544509
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9826#issuecomment-158551115
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9826#issuecomment-158551112
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/9826#issuecomment-158545655
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/9826#issuecomment-158553130
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9826#issuecomment-158555643
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9826#issuecomment-158555642
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/9826#issuecomment-158562807
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9826#issuecomment-158563254
**[Test build #46457 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46457/consoleFull)**
for PR 9826 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9826#issuecomment-158177674
**[Test build #46343 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46343/consoleFull)**
for PR 9826 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9826#issuecomment-158178053
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9826#issuecomment-158178060
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user thunterdb commented on the pull request:
https://github.com/apache/spark/pull/9826#issuecomment-158169615
@mengxr with the fixes, the top menu breaks before the side menu :-)
**
for PR 9826 at commit
Github user thunterdb commented on a diff in the pull request:
https://github.com/apache/spark/pull/9826#discussion_r45381998
--- Diff: docs/_includes/nav-left-wrapper-ml.html ---
@@ -0,0 +1,6 @@
+
+ML
--- End diff --
sure
---
If your project is set up
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9826#issuecomment-158232920
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9826#issuecomment-158232917
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/9826#issuecomment-158206117
nice! I wonder if there's something more general we can do. This is useful
across all pages in the docs so it would be worth investigating if there are
existing
Github user thunterdb commented on the pull request:
https://github.com/apache/spark/pull/9826#issuecomment-158229760
@mengxr based on our discussions, here is a slightly updated version:
- menu is fixed
- menu disappears under the page (but it looks half covered in the
Github user thunterdb commented on the pull request:
https://github.com/apache/spark/pull/9826#issuecomment-158220169
@andrewor14 this is a different issue: the SIPs show the table of contents
within one document, which we already have with the `{:toc}` directive. This PR
adds the
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/9826#issuecomment-158312175
@thunterdb Could you try the following CSS:
~~~css
.left-menu-wrapper {
position: absolute;
height: 100%;
width: 256px;
margin-top:
GitHub user thunterdb opened a pull request:
https://github.com/apache/spark/pull/9826
[SPARK-11835] Adds a sidebar menu to MLlib's documentation
This PR adds a sidebar menu when browsing the user guide of MLlib. It uses
a YAML file to describe the structure of the documentation.
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/9826#issuecomment-157932361
Great work! Shall we hide the side-nav-bar if width is not sufficient? See
attached screenshot:
**
for PR 9826 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9826#issuecomment-157919279
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9826#issuecomment-157919180
**[Test build #46280 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46280/consoleFull)**
for PR 9826 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9826#issuecomment-157919278
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9826#discussion_r45293904
--- Diff: docs/_includes/nav-left-wrapper-ml.html ---
@@ -0,0 +1,6 @@
+
+ML
+{% include nav-left.html nav=include.nav-ml %}
+MLlib
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9826#discussion_r45293893
--- Diff: docs/_data/menu-ml.yaml ---
@@ -0,0 +1,10 @@
+- text: Feature extraction, transformation, and selection
+ url: ml-features.html
+- text:
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9826#discussion_r45293897
--- Diff: docs/_data/menu-mllib.yaml ---
@@ -0,0 +1,75 @@
+- text: Data types
+ url: /mllib-data-types.html
+- text: Basic statistics
+ url:
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9826#discussion_r45293902
--- Diff: docs/_includes/nav-left-wrapper-ml.html ---
@@ -0,0 +1,6 @@
+
+ML
--- End diff --
Shall we use `spark.ml package` and
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9826#discussion_r45293895
--- Diff: docs/_data/menu-mllib.yaml ---
@@ -0,0 +1,75 @@
+- text: Data types
+ url: /mllib-data-types.html
--- End diff --
remove `/`
40 matches
Mail list logo
