[GitHub] spark pull request: [SPARK-14962][SQL] Do not push down isnotnull/...

2016-05-06 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/12777#discussion_r62408994 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcFilters.scala --- @@ -56,29 +55,35 @@ import org.apache.spark.sql.sources._ *

[GitHub] spark pull request: [SPARK-14962][SQL] Do not push down isnotnull/...

2016-05-06 Thread tedyu
Github user tedyu commented on a diff in the pull request: https://github.com/apache/spark/pull/12777#discussion_r62393964 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcFilters.scala --- @@ -56,29 +55,35 @@ import org.apache.spark.sql.sources._ * known

[GitHub] spark pull request: [SPARK-14962][SQL] Do not push down isnotnull/...

2016-05-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12777 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-14962][SQL] Do not push down isnotnull/...

2016-05-06 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/12777#issuecomment-217511291 LGTM, merging to master and branch-2.0. Thanks for fixing this! And yes, `OrcTableScan` should be safe to remove now. --- If your project is set up for it,

[GitHub] spark pull request: [SPARK-14962][SQL] Do not push down isnotnull/...

2016-05-06 Thread HyukjinKwon
Github user HyukjinKwon commented on the pull request: https://github.com/apache/spark/pull/12777#issuecomment-217391825 Hi @yhuai Would you mind taking a look for this please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-14962][SQL] Do not push down isnotnull/...

2016-04-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12777#issuecomment-215741758 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14962][SQL] Do not push down isnotnull/...

2016-04-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12777#issuecomment-215741756 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14962][SQL] Do not push down isnotnull/...

2016-04-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12777#issuecomment-215741463 **[Test build #57333 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57333/consoleFull)** for PR 12777 at commit

[GitHub] spark pull request: [SPARK-14962][SQL] Do not push down isnotnull/...

2016-04-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12777#issuecomment-215708308 **[Test build #57333 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57333/consoleFull)** for PR 12777 at commit

[GitHub] spark pull request: [SPARK-14962][SQL] Do not push down isnotnull/...

2016-04-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12777#issuecomment-215705582 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14962][SQL] Do not push down isnotnull/...

2016-04-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12777#issuecomment-215705583 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14962][SQL] Do not push down isnotnull/...

2016-04-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12777#issuecomment-215705461 **[Test build #57330 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57330/consoleFull)** for PR 12777 at commit

[GitHub] spark pull request: [SPARK-14962][SQL] Do not push down isnotnull/...

2016-04-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12777#issuecomment-215701364 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14962][SQL] Do not push down isnotnull/...

2016-04-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12777#issuecomment-215701361 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14962][SQL] Do not push down isnotnull/...

2016-04-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12777#issuecomment-215701233 **[Test build #57329 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57329/consoleFull)** for PR 12777 at commit

[GitHub] spark pull request: [SPARK-14962][SQL] Do not push down isnotnull/...

2016-04-29 Thread HyukjinKwon
Github user HyukjinKwon commented on the pull request: https://github.com/apache/spark/pull/12777#issuecomment-215697713 BTW, during doing this, I realised there is a unused classe and functions due to the change of `HadoopFsRelation`. - The class `OrcTableScan` is not used

[GitHub] spark pull request: [SPARK-14962][SQL] Do not push down isnotnull/...

2016-04-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12777#issuecomment-215695460 **[Test build #57330 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57330/consoleFull)** for PR 12777 at commit

[GitHub] spark pull request: [SPARK-14962][SQL] Do not push down isnotnull/...

2016-04-29 Thread HyukjinKwon
Github user HyukjinKwon commented on the pull request: https://github.com/apache/spark/pull/12777#issuecomment-215692521 @liancheng @yhuai Could you please take a look please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-14962][SQL] Do not push down isnotnull/...

2016-04-29 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/12777#discussion_r61565675 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcFilters.scala --- @@ -56,29 +55,35 @@ import org.apache.spark.sql.sources._ *

[GitHub] spark pull request: [SPARK-14962][SQL] Do not push down isnotnull/...

2016-04-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12777#issuecomment-215692092 **[Test build #57329 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57329/consoleFull)** for PR 12777 at commit

[GitHub] spark pull request: [SPARK-14962][SQL] Do not push down isnotnull/...

2016-04-29 Thread HyukjinKwon
GitHub user HyukjinKwon opened a pull request: https://github.com/apache/spark/pull/12777 [SPARK-14962][SQL] Do not push down isnotnull/isnull on unsuportted types. ## What changes were proposed in this pull request? https://issues.apache.org/jira/browse/SPARK-14962