[GitHub] spark pull request #13966: [SPARK-16276][SQL] Implement elt SQL function

2016-06-30 Thread janplus
Github user janplus commented on a diff in the pull request: https://github.com/apache/spark/pull/13966#discussion_r69237086 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -162,6 +163,46 @@ case class

[GitHub] spark pull request #13966: [SPARK-16276][SQL] Implement elt SQL function

2016-06-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/13966 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #13966: [SPARK-16276][SQL] Implement elt SQL function

2016-06-30 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13966#discussion_r69229664 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -162,6 +163,46 @@ case class

[GitHub] spark pull request #13966: [SPARK-16276][SQL] Implement elt SQL function

2016-06-30 Thread petermaxlee
Github user petermaxlee commented on a diff in the pull request: https://github.com/apache/spark/pull/13966#discussion_r69184719 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -162,6 +163,46 @@ case class

[GitHub] spark pull request #13966: [SPARK-16276][SQL] Implement elt SQL function

2016-06-30 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13966#discussion_r69142873 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -162,6 +163,46 @@ case class

[GitHub] spark pull request #13966: [SPARK-16276][SQL] Implement elt SQL function

2016-06-30 Thread janplus
Github user janplus commented on a diff in the pull request: https://github.com/apache/spark/pull/13966#discussion_r69098161 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -162,6 +163,46 @@ case class

[GitHub] spark pull request #13966: [SPARK-16276][SQL] Implement elt SQL function

2016-06-29 Thread petermaxlee
Github user petermaxlee commented on a diff in the pull request: https://github.com/apache/spark/pull/13966#discussion_r69070865 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -162,6 +163,46 @@ case class

[GitHub] spark pull request #13966: [SPARK-16276][SQL] Implement elt SQL function

2016-06-29 Thread petermaxlee
Github user petermaxlee commented on a diff in the pull request: https://github.com/apache/spark/pull/13966#discussion_r69070679 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -162,6 +163,46 @@ case class

[GitHub] spark pull request #13966: [SPARK-16276][SQL] Implement elt SQL function

2016-06-29 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13966#discussion_r69057382 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -162,6 +163,46 @@ case class

[GitHub] spark pull request #13966: [SPARK-16276][SQL] Implement elt SQL function

2016-06-29 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13966#discussion_r69057266 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -162,6 +163,46 @@ case class

[GitHub] spark pull request #13966: [SPARK-16276][SQL] Implement elt SQL function

2016-06-29 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/13966#discussion_r69057034 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala --- @@ -265,6 +265,7 @@ object FunctionRegistry {

[GitHub] spark pull request #13966: [SPARK-16276][SQL] Implement elt SQL function

2016-06-29 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13966#discussion_r69056414 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala --- @@ -265,6 +265,7 @@ object FunctionRegistry {

[GitHub] spark pull request #13966: [SPARK-16276][SQL] Implement elt SQL function

2016-06-29 Thread petermaxlee
Github user petermaxlee commented on a diff in the pull request: https://github.com/apache/spark/pull/13966#discussion_r69004793 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -162,6 +163,46 @@ case class

[GitHub] spark pull request #13966: [SPARK-16276][SQL] Implement elt SQL function

2016-06-29 Thread petermaxlee
Github user petermaxlee commented on a diff in the pull request: https://github.com/apache/spark/pull/13966#discussion_r69004576 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/StringExpressionsSuite.scala --- @@ -75,6 +75,28 @@ class

[GitHub] spark pull request #13966: [SPARK-16276][SQL] Implement elt SQL function

2016-06-29 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13966#discussion_r68930580 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/StringExpressionsSuite.scala --- @@ -75,6 +75,28 @@ class

[GitHub] spark pull request #13966: [SPARK-16276][SQL] Implement elt SQL function

2016-06-29 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13966#discussion_r68930450 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -162,6 +163,46 @@ case class

[GitHub] spark pull request #13966: [SPARK-16276][SQL] Implement elt SQL function

2016-06-29 Thread petermaxlee
Github user petermaxlee commented on a diff in the pull request: https://github.com/apache/spark/pull/13966#discussion_r68895355 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -162,6 +163,46 @@ case class

[GitHub] spark pull request #13966: [SPARK-16276][SQL] Implement elt SQL function

2016-06-29 Thread petermaxlee
Github user petermaxlee commented on a diff in the pull request: https://github.com/apache/spark/pull/13966#discussion_r68894703 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -162,6 +162,42 @@ case class

[GitHub] spark pull request #13966: [SPARK-16276][SQL] Implement elt SQL function

2016-06-29 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13966#discussion_r68890695 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -162,6 +162,42 @@ case class

[GitHub] spark pull request #13966: [SPARK-16276][SQL] Implement elt SQL function

2016-06-28 Thread petermaxlee
Github user petermaxlee commented on a diff in the pull request: https://github.com/apache/spark/pull/13966#discussion_r6095 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -162,6 +162,42 @@ case class

[GitHub] spark pull request #13966: [SPARK-16276][SQL] Implement elt SQL function

2016-06-28 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13966#discussion_r68887526 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -162,6 +162,42 @@ case class

[GitHub] spark pull request #13966: [SPARK-16276][SQL] Implement elt SQL function

2016-06-28 Thread petermaxlee
GitHub user petermaxlee opened a pull request: https://github.com/apache/spark/pull/13966 [SPARK-16276][SQL] Implement elt SQL function ## What changes were proposed in this pull request? This patch implements the elt function, as it is implemented in Hive. ## How was