Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/13998
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/13998#discussion_r69224534
--- Diff:
external/kafka-0-10/src/main/scala/org/apache/spark/streaming/kafka010/ConsumerStrategy.scala
---
@@ -36,7 +36,7 @@ import
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/13998#discussion_r69216207
--- Diff:
external/kafka-0-10/src/test/java/org/apache/spark/streaming/kafka010/JavaConsumerStrategySuite.java
---
@@ -44,37 +44,39 @@ public void
Github user koeninger commented on a diff in the pull request:
https://github.com/apache/spark/pull/13998#discussion_r69202911
--- Diff:
external/kafka-0-10/src/test/java/org/apache/spark/streaming/kafka010/JavaConsumerStrategySuite.java
---
@@ -44,37 +44,39 @@ public void
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/13998#discussion_r69201508
--- Diff:
external/kafka-0-10/src/test/java/org/apache/spark/streaming/kafka010/JavaConsumerStrategySuite.java
---
@@ -44,37 +44,39 @@ public void
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/13998#discussion_r69199519
--- Diff:
external/kafka-0-10/src/main/scala/org/apache/spark/streaming/kafka010/ConsumerStrategy.scala
---
@@ -51,11 +51,10 @@ trait ConsumerStrategy[K, V] {
Github user koeninger commented on a diff in the pull request:
https://github.com/apache/spark/pull/13998#discussion_r69196487
--- Diff:
external/kafka-0-10/src/main/scala/org/apache/spark/streaming/kafka010/ConsumerStrategy.scala
---
@@ -68,8 +67,7 @@ trait ConsumerStrategy[K,
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/13998#discussion_r69186052
--- Diff:
external/kafka-0-10/src/main/scala/org/apache/spark/streaming/kafka010/ConsumerStrategy.scala
---
@@ -68,8 +67,7 @@ trait ConsumerStrategy[K, V]
Github user koeninger commented on a diff in the pull request:
https://github.com/apache/spark/pull/13998#discussion_r69182103
--- Diff:
external/kafka-0-10/src/main/scala/org/apache/spark/streaming/kafka010/ConsumerStrategy.scala
---
@@ -68,8 +67,7 @@ trait ConsumerStrategy[K,
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/13998#discussion_r69181531
--- Diff:
external/kafka-0-10/src/main/scala/org/apache/spark/streaming/kafka010/ConsumerStrategy.scala
---
@@ -68,8 +67,7 @@ trait ConsumerStrategy[K, V]
GitHub user koeninger opened a pull request:
https://github.com/apache/spark/pull/13998
[SPARK-12177][Streaming][Kafka] limit api surface area
## What changes were proposed in this pull request?
This is an alternative to the refactoring proposed by
11 matches
Mail list logo
