[GitHub] spark pull request #17999: [SPARK-20751][SQL] Add built-in SQL Function - CO...

2017-05-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17999 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #17999: [SPARK-20751][SQL] Add built-in SQL Function - CO...

2017-05-18 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17999#discussion_r117300361 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala --- @@ -544,6 +544,24 @@ case class Sqrt(child:

[GitHub] spark pull request #17999: [SPARK-20751][SQL] Add built-in SQL Function - CO...

2017-05-18 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17999#discussion_r117298871 --- Diff: sql/core/src/test/resources/sql-tests/inputs/operators.sql --- @@ -32,6 +32,7 @@ select 1 - 2; select 2 * 5; select 5 % 3;

[GitHub] spark pull request #17999: [SPARK-20751][SQL] Add built-in SQL Function - CO...

2017-05-18 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17999#discussion_r117298713 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/MathFunctionsSuite.scala --- @@ -274,6 +274,13 @@ class MathFunctionsSuite extends QueryTest with

[GitHub] spark pull request #17999: [SPARK-20751][SQL] Add built-in SQL Function - CO...

2017-05-18 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17999#discussion_r117298560 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -1991,6 +1991,14 @@ object functions { def tan(columnName: String):

[GitHub] spark pull request #17999: [SPARK-20751][SQL] Add built-in SQL Function - CO...

2017-05-18 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/17999#discussion_r117278957 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -1991,6 +1991,22 @@ object functions { def tan(columnName: String):

[GitHub] spark pull request #17999: [SPARK-20751][SQL] Add built-in SQL Function - CO...

2017-05-16 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17999#discussion_r116860631 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -1991,6 +1991,22 @@ object functions { def tan(columnName: String):

[GitHub] spark pull request #17999: [SPARK-20751][SQL] Add built-in SQL Function - CO...

2017-05-16 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/17999#discussion_r116842254 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -1991,6 +1991,22 @@ object functions { def tan(columnName: String):

[GitHub] spark pull request #17999: [SPARK-20751][SQL] Add built-in SQL Function - CO...

2017-05-16 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/17999#discussion_r116842201 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -1991,6 +1991,22 @@ object functions { def tan(columnName: String):

[GitHub] spark pull request #17999: [SPARK-20751][SQL] Add built-in SQL Function - CO...

2017-05-16 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17999#discussion_r116812132 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala --- @@ -544,6 +544,28 @@ case class Sqrt(child:

[GitHub] spark pull request #17999: [SPARK-20751][SQL] Add built-in SQL Function - CO...

2017-05-16 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17999#discussion_r116811946 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala --- @@ -544,6 +544,28 @@ case class Sqrt(child:

[GitHub] spark pull request #17999: [SPARK-20751][SQL] Add built-in SQL Function - CO...

2017-05-16 Thread wangyum
GitHub user wangyum opened a pull request: https://github.com/apache/spark/pull/17999 [SPARK-20751][SQL] Add built-in SQL Function - COT ## What changes were proposed in this pull request? Add built-in SQL Function - COT. ## How was this patch tested? unit