[GitHub] spark pull request #20095: [SPARK-22126][ML] Added fitMultiple method with d...

2018-05-07 Thread WeichenXu123
Github user WeichenXu123 commented on a diff in the pull request: https://github.com/apache/spark/pull/20095#discussion_r186381507 --- Diff: mllib/src/main/scala/org/apache/spark/ml/Estimator.scala --- @@ -79,7 +82,52 @@ abstract class Estimator[M <: Model[M]] extends

[GitHub] spark pull request #20095: [SPARK-22126][ML] Added fitMultiple method with d...

2017-12-30 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/20095#discussion_r159127966 --- Diff: mllib/src/main/scala/org/apache/spark/ml/Estimator.scala --- @@ -79,7 +82,52 @@ abstract class Estimator[M <: Model[M]] extends PipelineStage {

[GitHub] spark pull request #20095: [SPARK-22126][ML] Added fitMultiple method with d...

2017-12-30 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/20095#discussion_r159131555 --- Diff: mllib/src/main/scala/org/apache/spark/ml/Estimator.scala --- @@ -79,7 +82,52 @@ abstract class Estimator[M <: Model[M]] extends PipelineStage {

[GitHub] spark pull request #20095: [SPARK-22126][ML] Added fitMultiple method with d...

2017-12-28 Thread MrBago
Github user MrBago commented on a diff in the pull request: https://github.com/apache/spark/pull/20095#discussion_r159011656 --- Diff: mllib/src/main/scala/org/apache/spark/ml/Estimator.scala --- @@ -79,7 +82,51 @@ abstract class Estimator[M <: Model[M]] extends PipelineStage {

[GitHub] spark pull request #20095: [SPARK-22126][ML] Added fitMultiple method with d...

2017-12-28 Thread MrBago
Github user MrBago commented on a diff in the pull request: https://github.com/apache/spark/pull/20095#discussion_r159007817 --- Diff: mllib/src/main/scala/org/apache/spark/ml/Estimator.scala --- @@ -79,7 +82,51 @@ abstract class Estimator[M <: Model[M]] extends PipelineStage {

[GitHub] spark pull request #20095: [SPARK-22126][ML] Added fitMultiple method with d...

2017-12-28 Thread MrBago
Github user MrBago commented on a diff in the pull request: https://github.com/apache/spark/pull/20095#discussion_r159006471 --- Diff: mllib/src/main/scala/org/apache/spark/ml/Estimator.scala --- @@ -79,7 +82,51 @@ abstract class Estimator[M <: Model[M]] extends PipelineStage {

[GitHub] spark pull request #20095: [SPARK-22126][ML] Added fitMultiple method with d...

2017-12-28 Thread WeichenXu123
Github user WeichenXu123 commented on a diff in the pull request: https://github.com/apache/spark/pull/20095#discussion_r158930992 --- Diff: mllib/src/main/scala/org/apache/spark/ml/Estimator.scala --- @@ -79,7 +82,51 @@ abstract class Estimator[M <: Model[M]] extends

[GitHub] spark pull request #20095: [SPARK-22126][ML] Added fitMultiple method with d...

2017-12-28 Thread WeichenXu123
Github user WeichenXu123 commented on a diff in the pull request: https://github.com/apache/spark/pull/20095#discussion_r158929523 --- Diff: mllib/src/main/scala/org/apache/spark/ml/Estimator.scala --- @@ -79,7 +82,51 @@ abstract class Estimator[M <: Model[M]] extends

[GitHub] spark pull request #20095: [SPARK-22126][ML] Added fitMultiple method with d...

2017-12-28 Thread WeichenXu123
Github user WeichenXu123 commented on a diff in the pull request: https://github.com/apache/spark/pull/20095#discussion_r158931079 --- Diff: mllib/src/main/scala/org/apache/spark/ml/Estimator.scala --- @@ -79,7 +82,51 @@ abstract class Estimator[M <: Model[M]] extends

[GitHub] spark pull request #20095: [SPARK-22126][ML] Added fitMultiple method with d...

2017-12-27 Thread MrBago
GitHub user MrBago opened a pull request: https://github.com/apache/spark/pull/20095 [SPARK-22126][ML] Added fitMultiple method with default implementation …mator. Update TrainValidationSplit & CrossValidator to use fitMultiple method. ## What changes were