Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21510
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/21510#discussion_r195074091
--- Diff: core/src/main/scala/org/apache/spark/ui/WebUI.scala ---
@@ -88,41 +90,41 @@ private[spark] abstract class WebUI(
handlers += renderHandler
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/21510#discussion_r194632125
--- Diff: core/src/main/scala/org/apache/spark/ui/WebUI.scala ---
@@ -88,41 +90,41 @@ private[spark] abstract class WebUI(
handlers +=
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21510#discussion_r194484175
--- Diff: core/src/main/scala/org/apache/spark/ui/WebUI.scala ---
@@ -88,41 +90,41 @@ private[spark] abstract class WebUI(
handlers += renderHandler
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/21510#discussion_r194309780
--- Diff: core/src/main/scala/org/apache/spark/ui/WebUI.scala ---
@@ -101,12 +101,12 @@ private[spark] abstract class WebUI(
}
/**
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21510#discussion_r194266907
--- Diff: core/src/main/scala/org/apache/spark/ui/WebUI.scala ---
@@ -101,12 +101,12 @@ private[spark] abstract class WebUI(
}
/**
-
GitHub user jaceklaskowski opened a pull request:
https://github.com/apache/spark/pull/21510
[SPARK-24490][WebUI] Use WebUI.addStaticHandler in web UIs
`WebUI` defines `addStaticHandler` that web UIs don't use (and simply
introduce duplication). Let's clean them up and remove
