Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21570
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21570#discussion_r198710399
--- Diff:
core/src/test/java/org/apache/spark/memory/TestMemoryConsumer.java ---
@@ -43,6 +47,12 @@ void free(long size) {
used -= size;
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21570#discussion_r198224083
--- Diff:
sql/core/src/test/java/test/org/apache/spark/sql/execution/sort/RecordBinaryComparatorSuite.java
---
@@ -0,0 +1,255 @@
+/*
+ * Licensed to
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21570#discussion_r198177547
--- Diff:
sql/core/src/test/java/test/org/apache/spark/sql/execution/sort/RecordBinaryComparatorSuite.java
---
@@ -0,0 +1,255 @@
+/*
+ *
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21570#discussion_r197328626
--- Diff:
sql/core/src/test/java/test/org/apache/spark/sql/execution/sort/RecordBinaryComparatorSuite.java
---
@@ -0,0 +1,255 @@
+/*
+ * Licensed to
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21570#discussion_r196437321
--- Diff:
sql/core/src/test/java/test/org/apache/spark/sql/execution/sort/RecordBinaryComparatorSuite.java
---
@@ -0,0 +1,255 @@
+/*
+ *
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21570#discussion_r195922982
--- Diff:
core/src/test/java/org/apache/spark/memory/TestMemoryConsumer.java ---
@@ -43,6 +45,12 @@ void free(long size) {
used -= size;
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21570#discussion_r195891897
--- Diff:
sql/core/src/test/java/test/org/apache/spark/sql/execution/sort/RecordBinaryComparatorSuite.java
---
@@ -0,0 +1,255 @@
+/*
+ * Licensed
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21570#discussion_r195891774
--- Diff:
core/src/test/java/org/apache/spark/memory/TestMemoryConsumer.java ---
@@ -43,6 +45,12 @@ void free(long size) {
used -= size;
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21570#discussion_r195891644
--- Diff:
sql/core/src/test/java/test/org/apache/spark/sql/execution/sort/RecordBinaryComparatorSuite.java
---
@@ -0,0 +1,255 @@
+/*
+ * Licensed
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21570#discussion_r195640246
--- Diff:
sql/core/src/test/java/test/org/apache/spark/sql/execution/sort/RecordBinaryComparatorSuite.java
---
@@ -0,0 +1,255 @@
+/*
+ * Licensed to
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21570#discussion_r195640161
--- Diff:
sql/core/src/test/java/test/org/apache/spark/sql/execution/sort/RecordBinaryComparatorSuite.java
---
@@ -0,0 +1,255 @@
+/*
+ * Licensed to
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21570#discussion_r195639885
--- Diff:
sql/core/src/test/java/test/org/apache/spark/sql/execution/sort/RecordBinaryComparatorSuite.java
---
@@ -0,0 +1,255 @@
+/*
+ * Licensed to
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21570#discussion_r195636719
--- Diff:
sql/core/src/test/java/test/org/apache/spark/sql/execution/sort/RecordBinaryComparatorSuite.java
---
@@ -0,0 +1,255 @@
+/*
+ * Licensed to
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21570#discussion_r195636548
--- Diff:
sql/core/src/test/java/test/org/apache/spark/sql/execution/sort/RecordBinaryComparatorSuite.java
---
@@ -0,0 +1,255 @@
+/*
+ * Licensed to
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21570#discussion_r195634729
--- Diff:
sql/core/src/test/java/test/org/apache/spark/sql/execution/sort/RecordBinaryComparatorSuite.java
---
@@ -0,0 +1,255 @@
+/*
+ * Licensed to
GitHub user jiangxb1987 opened a pull request:
https://github.com/apache/spark/pull/21570
[SPARK-24564][TEST] Add test suite for RecordBinaryComparator
## What changes were proposed in this pull request?
Add a new test suite to test RecordBinaryComparator.
## How
17 matches
Mail list logo
