Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21652
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21652#discussion_r203871861
--- Diff: bin/docker-image-tool.sh ---
@@ -135,7 +135,7 @@ BASEDOCKERFILE=
PYDOCKERFILE=
NOCACHEARG=
BUILD_PARAMS=
-while getopts
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/21652#discussion_r203446470
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesSuite.scala
---
@@ -29,25
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21652#discussion_r203313358
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/TestConstants.scala
---
@@ -16,7 +16,7
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21652#discussion_r203303708
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesSuite.scala
---
@@ -29,25
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/21652#discussion_r203178554
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesSuite.scala
---
@@ -29,25
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21652#discussion_r203158126
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/PythonTestsSuite.scala
---
@@ -0,0
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21652#discussion_r203155672
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesSuite.scala
---
@@ -29,25
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/21652#discussion_r203105805
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesSuite.scala
---
@@ -29,25
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/21652#discussion_r203105117
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/PythonTestsSuite.scala
---
@@ -0,0
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21652#discussion_r203101189
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesSuite.scala
---
@@ -29,25
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21652#discussion_r203099369
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/PythonTestsSuite.scala
---
@@ -0,0
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21652#discussion_r202007781
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesSuite.scala
---
@@ -232,6
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21652#discussion_r202007703
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/SecretsTestsSuite.scala
---
@@ -0,0
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21652#discussion_r201370977
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesSuite.scala
---
@@ -232,6
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21652#discussion_r201360341
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/SecretsTestsSuite.scala
---
@@ -0,0
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21652#discussion_r201358932
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/BasicTestsSuite.scala
---
@@ -0,0
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21652#discussion_r201359068
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/SecretsTestsSuite.scala
---
@@ -0,0
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21652#discussion_r201358773
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/BasicTestsSuite.scala
---
@@ -0,0
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21652#discussion_r201358555
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesSuite.scala
---
@@ -31,19
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21652#discussion_r201358259
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/SecretsTestsSuite.scala
---
@@ -0,0
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21652#discussion_r200556220
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/SecretsTestsSuite.scala
---
@@ -0,0
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21652#discussion_r200556018
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/SecretsTestsSuite.scala
---
@@ -0,0
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21652#discussion_r200555201
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesSuite.scala
---
@@ -232,6
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/21652#discussion_r200515051
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/SecretsTestsSuite.scala
---
@@ -0,0
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/21652#discussion_r200514990
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesSuite.scala
---
@@ -31,19
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/21652#discussion_r200514722
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/BasicTestsSuite.scala
---
@@ -0,0
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/21652#discussion_r200514767
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/BasicTestsSuite.scala
---
@@ -0,0
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21652#discussion_r200136389
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesSuite.scala
---
@@ -150,6
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21652#discussion_r200135218
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesSuite.scala
---
@@ -265,6
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21652#discussion_r200082423
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesSuite.scala
---
@@ -74,10
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21652#discussion_r199610386
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesSuite.scala
---
@@ -150,6
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21652#discussion_r199610464
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesSuite.scala
---
@@ -74,10
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21652#discussion_r199610357
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesSuite.scala
---
@@ -265,6
Github user ssuchter commented on a diff in the pull request:
https://github.com/apache/spark/pull/21652#discussion_r199610045
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesSuite.scala
---
@@ -74,10
Github user ssuchter commented on a diff in the pull request:
https://github.com/apache/spark/pull/21652#discussion_r199609986
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesSuite.scala
---
@@ -74,10
Github user ssuchter commented on a diff in the pull request:
https://github.com/apache/spark/pull/21652#discussion_r199609501
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesSuite.scala
---
@@ -265,6
Github user foxish commented on a diff in the pull request:
https://github.com/apache/spark/pull/21652#discussion_r199608693
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesSuite.scala
---
@@ -74,10
Github user foxish commented on a diff in the pull request:
https://github.com/apache/spark/pull/21652#discussion_r199608853
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesSuite.scala
---
@@ -150,6
GitHub user skonto opened a pull request:
https://github.com/apache/spark/pull/21652
[SPARK-24551][K8s] Add integration tests for secrets
## What changes were proposed in this pull request?
- Adds integration tests for env and mount secrets.
## How was this patch
40 matches
Mail list logo