[GitHub] spark pull request #21700: [SPARK-24717][SS] Split out max retain version of...

2018-07-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/21700 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #21700: [SPARK-24717][SS] Split out max retain version of...

2018-07-18 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/spark/pull/21700#discussion_r203577783 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/HDFSBackedStateStoreProvider.scala --- @@ -270,11 +273,43 @@

[GitHub] spark pull request #21700: [SPARK-24717][SS] Split out max retain version of...

2018-07-18 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/spark/pull/21700#discussion_r203577561 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/StateStoreSuite.scala --- @@ -64,21 +66,143 @@ class StateStoreSuite

[GitHub] spark pull request #21700: [SPARK-24717][SS] Split out max retain version of...

2018-07-18 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/21700#discussion_r203573819 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/HDFSBackedStateStoreProvider.scala --- @@ -270,11 +273,43 @@ private[state]

[GitHub] spark pull request #21700: [SPARK-24717][SS] Split out max retain version of...

2018-07-18 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/21700#discussion_r203573621 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/StateStoreSuite.scala --- @@ -64,21 +66,143 @@ class StateStoreSuite extends

[GitHub] spark pull request #21700: [SPARK-24717][SS] Split out max retain version of...

2018-07-18 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/21700#discussion_r203573306 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/StateStoreSuite.scala --- @@ -64,21 +66,143 @@ class StateStoreSuite extends

[GitHub] spark pull request #21700: [SPARK-24717][SS] Split out max retain version of...

2018-07-17 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/spark/pull/21700#discussion_r202933053 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/HDFSBackedStateStoreProvider.scala --- @@ -270,11 +273,42 @@

[GitHub] spark pull request #21700: [SPARK-24717][SS] Split out max retain version of...

2018-07-17 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/spark/pull/21700#discussion_r202932784 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/StateStoreSuite.scala --- @@ -64,21 +64,122 @@ class StateStoreSuite

[GitHub] spark pull request #21700: [SPARK-24717][SS] Split out max retain version of...

2018-07-17 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/21700#discussion_r202927242 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/StateStoreSuite.scala --- @@ -64,21 +64,122 @@ class StateStoreSuite extends

[GitHub] spark pull request #21700: [SPARK-24717][SS] Split out max retain version of...

2018-07-17 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/21700#discussion_r202919419 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/StateStoreSuite.scala --- @@ -64,21 +64,122 @@ class StateStoreSuite extends

[GitHub] spark pull request #21700: [SPARK-24717][SS] Split out max retain version of...

2018-07-17 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/21700#discussion_r202925739 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/StateStoreSuite.scala --- @@ -99,43 +102,84 @@ class StateStoreSuite extends

[GitHub] spark pull request #21700: [SPARK-24717][SS] Split out max retain version of...

2018-07-17 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/21700#discussion_r202926467 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/StateStoreSuite.scala --- @@ -64,21 +64,122 @@ class StateStoreSuite extends

[GitHub] spark pull request #21700: [SPARK-24717][SS] Split out max retain version of...

2018-07-17 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/21700#discussion_r202920067 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/StateStoreSuite.scala --- @@ -64,21 +64,122 @@ class StateStoreSuite extends

[GitHub] spark pull request #21700: [SPARK-24717][SS] Split out max retain version of...

2018-07-17 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/21700#discussion_r202922272 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/StateStoreSuite.scala --- @@ -64,21 +64,122 @@ class StateStoreSuite extends

[GitHub] spark pull request #21700: [SPARK-24717][SS] Split out max retain version of...

2018-07-17 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/21700#discussion_r202927538 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/StateStoreSuite.scala --- @@ -99,43 +102,84 @@ class StateStoreSuite extends

[GitHub] spark pull request #21700: [SPARK-24717][SS] Split out max retain version of...

2018-07-17 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/21700#discussion_r202917836 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/HDFSBackedStateStoreProvider.scala --- @@ -270,11 +273,42 @@ private[state]

[GitHub] spark pull request #21700: [SPARK-24717][SS] Split out max retain version of...

2018-07-17 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/21700#discussion_r202920190 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/StateStoreSuite.scala --- @@ -64,21 +64,122 @@ class StateStoreSuite extends

[GitHub] spark pull request #21700: [SPARK-24717][SS] Split out max retain version of...

2018-07-17 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/21700#discussion_r202918769 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/HDFSBackedStateStoreProvider.scala --- @@ -270,11 +273,42 @@ private[state]

[GitHub] spark pull request #21700: [SPARK-24717][SS] Split out max retain version of...

2018-07-11 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/spark/pull/21700#discussion_r201866930 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/StateStoreSuite.scala --- @@ -99,43 +102,84 @@ class StateStoreSuite

[GitHub] spark pull request #21700: [SPARK-24717][SS] Split out max retain version of...

2018-07-11 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/spark/pull/21700#discussion_r201866279 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/StateStoreSuite.scala --- @@ -64,6 +64,63 @@ class StateStoreSuite

[GitHub] spark pull request #21700: [SPARK-24717][SS] Split out max retain version of...

2018-07-11 Thread jose-torres
Github user jose-torres commented on a diff in the pull request: https://github.com/apache/spark/pull/21700#discussion_r201792030 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/HDFSBackedStateStoreProvider.scala --- @@ -239,8 +241,9 @@

[GitHub] spark pull request #21700: [SPARK-24717][SS] Split out max retain version of...

2018-07-11 Thread jose-torres
Github user jose-torres commented on a diff in the pull request: https://github.com/apache/spark/pull/21700#discussion_r201793040 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/StateStoreSuite.scala --- @@ -64,6 +64,63 @@ class StateStoreSuite

[GitHub] spark pull request #21700: [SPARK-24717][SS] Split out max retain version of...

2018-07-10 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/spark/pull/21700#discussion_r201562690 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/HDFSBackedStateStoreProvider.scala --- @@ -239,8 +241,9 @@

[GitHub] spark pull request #21700: [SPARK-24717][SS] Split out max retain version of...

2018-07-10 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/spark/pull/21700#discussion_r201515401 --- Diff: sql/core/src/main/java/org/apache/spark/sql/streaming/state/BoundedSortedMap.java --- @@ -0,0 +1,145 @@ +/* + * Licensed to the

[GitHub] spark pull request #21700: [SPARK-24717][SS] Split out max retain version of...

2018-07-10 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/spark/pull/21700#discussion_r201477277 --- Diff: sql/core/src/main/java/org/apache/spark/sql/streaming/state/BoundedSortedMap.java --- @@ -0,0 +1,145 @@ +/* + * Licensed to the

[GitHub] spark pull request #21700: [SPARK-24717][SS] Split out max retain version of...

2018-07-10 Thread jose-torres
Github user jose-torres commented on a diff in the pull request: https://github.com/apache/spark/pull/21700#discussion_r201407516 --- Diff: sql/core/src/main/java/org/apache/spark/sql/streaming/state/BoundedSortedMap.java --- @@ -0,0 +1,145 @@ +/* + * Licensed to the

[GitHub] spark pull request #21700: [SPARK-24717][SS] Split out max retain version of...

2018-07-05 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/spark/pull/21700#discussion_r200249847 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/HDFSBackedStateStoreProvider.scala --- @@ -240,7 +244,11 @@

[GitHub] spark pull request #21700: [SPARK-24717][SS] Split out max retain version of...

2018-07-05 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/spark/pull/21700#discussion_r200249732 --- Diff: sql/core/src/main/java/org/apache/spark/sql/streaming/state/BoundedSortedMap.java --- @@ -0,0 +1,79 @@ +/* + * Licensed to the

[GitHub] spark pull request #21700: [SPARK-24717][SS] Split out max retain version of...

2018-07-05 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/spark/pull/21700#discussion_r200249261 --- Diff: sql/core/src/main/java/org/apache/spark/sql/streaming/state/BoundedSortedMap.java --- @@ -0,0 +1,79 @@ +/* + * Licensed to the

[GitHub] spark pull request #21700: [SPARK-24717][SS] Split out max retain version of...

2018-07-05 Thread tedyu
Github user tedyu commented on a diff in the pull request: https://github.com/apache/spark/pull/21700#discussion_r200248889 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/HDFSBackedStateStoreProvider.scala --- @@ -240,7 +244,11 @@ private[state]

[GitHub] spark pull request #21700: [SPARK-24717][SS] Split out max retain version of...

2018-07-05 Thread tedyu
Github user tedyu commented on a diff in the pull request: https://github.com/apache/spark/pull/21700#discussion_r200242174 --- Diff: sql/core/src/main/java/org/apache/spark/sql/streaming/state/BoundedSortedMap.java --- @@ -0,0 +1,79 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #21700: [SPARK-24717][SS] Split out max retain version of...

2018-07-05 Thread tedyu
Github user tedyu commented on a diff in the pull request: https://github.com/apache/spark/pull/21700#discussion_r200242876 --- Diff: sql/core/src/main/java/org/apache/spark/sql/streaming/state/BoundedSortedMap.java --- @@ -0,0 +1,79 @@ +/* + * Licensed to the Apache