Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21849
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21849#discussion_r216058998
--- Diff:
core/src/test/java/org/apache/spark/launcher/SparkLauncherSuite.java ---
@@ -227,6 +220,82 @@ public void testInProcessLauncherDoesNotKillJvm()
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21849#discussion_r216058203
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/ChildProcAppHandle.java ---
@@ -46,6 +47,25 @@ public synchronized void disconnect() {
}
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21849#discussion_r216059482
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/OutputRedirector.java ---
@@ -61,6 +62,10 @@ private void redirect() {
while ((line =
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21849#discussion_r216058842
--- Diff: project/MimaExcludes.scala ---
@@ -106,7 +106,10 @@ object MimaExcludes {
Github user sahilTakiar commented on a diff in the pull request:
https://github.com/apache/spark/pull/21849#discussion_r214110048
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/OutputRedirector.java ---
@@ -17,6 +17,8 @@
package org.apache.spark.launcher;
Github user sahilTakiar commented on a diff in the pull request:
https://github.com/apache/spark/pull/21849#discussion_r214109949
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/ChildProcAppHandle.java ---
@@ -46,6 +47,18 @@ public synchronized void disconnect() {
Github user sahilTakiar commented on a diff in the pull request:
https://github.com/apache/spark/pull/21849#discussion_r214109901
--- Diff:
core/src/test/java/org/apache/spark/launcher/SparkLauncherSuite.java ---
@@ -227,6 +220,82 @@ public void
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21849#discussion_r210120533
--- Diff:
core/src/test/java/org/apache/spark/launcher/SparkLauncherSuite.java ---
@@ -227,6 +220,82 @@ public void testInProcessLauncherDoesNotKillJvm()
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21849#discussion_r210121595
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/OutputRedirector.java ---
@@ -17,6 +17,8 @@
package org.apache.spark.launcher;
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21849#discussion_r210120851
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/ChildProcAppHandle.java ---
@@ -46,6 +47,18 @@ public synchronized void disconnect() {
}
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21849#discussion_r210121238
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/InProcessAppHandle.java ---
@@ -63,6 +71,7 @@ synchronized void start(String appName, Method
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21849#discussion_r210120953
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/ChildProcAppHandle.java ---
@@ -46,6 +47,18 @@ public synchronized void disconnect() {
}
GitHub user sahilTakiar opened a pull request:
https://github.com/apache/spark/pull/21849
[SPARK-24243][CORE] Expose exceptions from InProcessAppHandle
## What changes were proposed in this pull request?
Adds a new method to `SparkAppHandle` called `getError` which returns
14 matches
Mail list logo
