[GitHub] spark pull request #22370: don't link to deprecated function

2018-09-11 Thread MichaelChirico
Github user MichaelChirico closed the pull request at: https://github.com/apache/spark/pull/22370 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #22370: don't link to deprecated function

2018-09-10 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/22370#discussion_r216539411 --- Diff: R/pkg/R/catalog.R --- @@ -69,7 +69,6 @@ createExternalTable <- function(x, ...) { #' @param ... additional named parameters as options

[GitHub] spark pull request #22370: don't link to deprecated function

2018-09-10 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/22370#discussion_r216229836 --- Diff: R/pkg/R/catalog.R --- @@ -69,7 +69,6 @@ createExternalTable <- function(x, ...) { #' @param ... additional named parameters as options

[GitHub] spark pull request #22370: don't link to deprecated function

2018-09-10 Thread MichaelChirico
Github user MichaelChirico commented on a diff in the pull request: https://github.com/apache/spark/pull/22370#discussion_r216222159 --- Diff: R/pkg/R/catalog.R --- @@ -69,7 +69,6 @@ createExternalTable <- function(x, ...) { #' @param ... additional named parameters as options

[GitHub] spark pull request #22370: don't link to deprecated function

2018-09-10 Thread MichaelChirico
Github user MichaelChirico commented on a diff in the pull request: https://github.com/apache/spark/pull/22370#discussion_r216222094 --- Diff: R/pkg/R/catalog.R --- @@ -69,7 +69,6 @@ createExternalTable <- function(x, ...) { #' @param ... additional named parameters as options

[GitHub] spark pull request #22370: don't link to deprecated function

2018-09-10 Thread MichaelChirico
Github user MichaelChirico commented on a diff in the pull request: https://github.com/apache/spark/pull/22370#discussion_r216220254 --- Diff: R/pkg/R/catalog.R --- @@ -69,7 +69,6 @@ createExternalTable <- function(x, ...) { #' @param ... additional named parameters as options

[GitHub] spark pull request #22370: don't link to deprecated function

2018-09-10 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/22370#discussion_r216217235 --- Diff: R/pkg/R/catalog.R --- @@ -69,7 +69,6 @@ createExternalTable <- function(x, ...) { #' @param ... additional named parameters as options

[GitHub] spark pull request #22370: don't link to deprecated function

2018-09-08 Thread MichaelChirico
GitHub user MichaelChirico opened a pull request: https://github.com/apache/spark/pull/22370 don't link to deprecated function Seems misleading to (without qualification) link to a deprecated function ## What changes were proposed in this pull request? (Please fill