[GitHub] spark pull request #22930: [SPARK-24869][SQL] Fix SaveIntoDataSourceCommand'...

2018-11-12 Thread wangyum
Github user wangyum closed the pull request at: https://github.com/apache/spark/pull/22930 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #22930: [SPARK-24869][SQL] Fix SaveIntoDataSourceCommand'...

2018-11-04 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/22930#discussion_r230609078 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/SaveIntoDataSourceCommand.scala --- @@ -37,13 +37,12 @@ case class

[GitHub] spark pull request #22930: [SPARK-24869][SQL] Fix SaveIntoDataSourceCommand'...

2018-11-02 Thread wangyum
Github user wangyum commented on a diff in the pull request: https://github.com/apache/spark/pull/22930#discussion_r230471897 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/test/DataFrameReaderWriterSuite.scala --- @@ -56,10 +62,6 @@ class DefaultSource with

[GitHub] spark pull request #22930: [SPARK-24869][SQL] Fix SaveIntoDataSourceCommand'...

2018-11-02 Thread wangyum
Github user wangyum commented on a diff in the pull request: https://github.com/apache/spark/pull/22930#discussion_r230471768 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/test/TestSQLContext.scala --- @@ -39,7 +39,10 @@ private[spark] class TestSparkSession(sc:

[GitHub] spark pull request #22930: [SPARK-24869][SQL] Fix SaveIntoDataSourceCommand'...

2018-11-02 Thread wangyum
GitHub user wangyum opened a pull request: https://github.com/apache/spark/pull/22930 [SPARK-24869][SQL] Fix SaveIntoDataSourceCommand's input Dataset does not use cached data ## What changes were proposed in this pull request? This PR fix 2 things: 1. Fix