Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22991
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22991#discussion_r236230624
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala ---
@@ -209,6 +215,9 @@ final class OneVsRestModel private[ml] (
Github user zhengruifeng commented on a diff in the pull request:
https://github.com/apache/spark/pull/22991#discussion_r236110139
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala ---
@@ -219,14 +225,20 @@ final class OneVsRestModel private[ml] (
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22991#discussion_r235929179
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala ---
@@ -219,14 +225,20 @@ final class OneVsRestModel private[ml] (
GitHub user zhengruifeng opened a pull request:
https://github.com/apache/spark/pull/22991
[SPARK-25989][ML] OneVsRestModel handle empty outputCols incorrectly
## What changes were proposed in this pull request?
ignore empty output columns
## How was this patch tested?
