[GitHub] spark pull request #23028: [SPARK-26053][SQL] Enhance LikeSimplification

2018-11-13 Thread wangyum
Github user wangyum commented on a diff in the pull request: https://github.com/apache/spark/pull/23028#discussion_r233317201 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala --- @@ -504,6 +504,19 @@ object LikeSimplification extends

[GitHub] spark pull request #23028: [SPARK-26053][SQL] Enhance LikeSimplification

2018-11-13 Thread wangyum
Github user wangyum closed the pull request at: https://github.com/apache/spark/pull/23028 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #23028: [SPARK-26053][SQL] Enhance LikeSimplification

2018-11-13 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/23028#discussion_r233315756 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala --- @@ -504,6 +504,19 @@ object LikeSimplification extends

[GitHub] spark pull request #23028: [SPARK-26053][SQL] Enhance LikeSimplification

2018-11-13 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/23028#discussion_r233315067 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala --- @@ -504,6 +504,19 @@ object LikeSimplification extends

[GitHub] spark pull request #23028: [SPARK-26053][SQL] Enhance LikeSimplification

2018-11-13 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/23028#discussion_r233315192 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala --- @@ -504,6 +504,19 @@ object LikeSimplification extends

[GitHub] spark pull request #23028: [SPARK-26053][SQL] Enhance LikeSimplification

2018-11-13 Thread wangyum
GitHub user wangyum opened a pull request: https://github.com/apache/spark/pull/23028 [SPARK-26053][SQL] Enhance LikeSimplification ## What changes were proposed in this pull request? This PR enhance `LikeSimplification` in 2 cases: 1. null like col -> null 2.