GitHub user vanzin opened a pull request:
https://github.com/apache/spark/pull/23220
[SPARK-25877][k8s] Move all feature logic to feature classes.
This change makes the driver and executor builders a lot simpler
by encapsulating almost all feature logic into the respective
feature classes. The only logic that remains is the creation of
the initial pod, which needs to happen before anything else so
is better to be left in the builder class.
Most feature classes already behave fine when the config has nothing
they should handle, but a few minor tweaks had to be added. Unit
tests were also updated or added to account for these.
The builder suites were simplified a lot and just test the remaining
pod-related code in the builders themselves.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vanzin/spark SPARK-25877
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/23220.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #23220
----
commit a13bafd8e48d8a03fa35c6ff6817f03908f17e2d
Author: Marcelo Vanzin <vanzin@...>
Date: 2018-12-04T19:42:31Z
[SPARK-25877][k8s] Move all feature logic to feature classes.
This change makes the driver and executor builders a lot simpler
by encapsulating almost all feature logic into the respective
feature classes. The only logic that remains is the creation of
the initial pod, which needs to happen before anything else so
is better to be left in the builder class.
Most feature classes already behave fine when the config has nothing
they should handle, but a few minor tweaks had to be added. Unit
tests were also updated or added to account for these.
The builder suites were simplified a lot and just test the remaining
pod-related code in the builders themselves.
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
