[GitHub] spark pull request #23268: [Hive][Minor] Refactor on HiveShim and Add Unit T...

Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/23268#discussion_r240110126 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveShim.scala --- @@ -53,19 +53,12 @@ private[hive] object HiveShim { * This

[GitHub] spark pull request #23268: [Hive][Minor] Refactor on HiveShim and Add Unit T...

Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/23268#discussion_r240107064 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveShim.scala --- @@ -53,19 +53,12 @@ private[hive] object HiveShim { * This

[GitHub] spark pull request #23268: [Hive][Minor] Refactor on HiveShim and Add Unit T...

Github user maomaoChibei commented on a diff in the pull request: https://github.com/apache/spark/pull/23268#discussion_r240107003 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveShim.scala --- @@ -53,19 +53,12 @@ private[hive] object HiveShim { * This

[GitHub] spark pull request #23268: [Hive][Minor] Refactor on HiveShim and Add Unit T...

Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/23268#discussion_r240105070 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveShim.scala --- @@ -53,19 +53,12 @@ private[hive] object HiveShim { * This

[GitHub] spark pull request #23268: [Hive][Minor] Refactor on HiveShim and Add Unit T...

Github user sadhen commented on a diff in the pull request: https://github.com/apache/spark/pull/23268#discussion_r240103941 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveShim.scala --- @@ -53,19 +53,12 @@ private[hive] object HiveShim { * This function

[GitHub] spark pull request #23268: [Hive][Minor] Refactor on HiveShim and Add Unit T...

Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/23268#discussion_r240101927 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveShim.scala --- @@ -53,19 +53,12 @@ private[hive] object HiveShim { * This

[GitHub] spark pull request #23268: [Hive][Minor] Refactor on HiveShim and Add Unit T...

Github user sadhen commented on a diff in the pull request: https://github.com/apache/spark/pull/23268#discussion_r240098806 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveShim.scala --- @@ -53,19 +53,12 @@ private[hive] object HiveShim { * This function

[GitHub] spark pull request #23268: [Hive][Minor] Refactor on HiveShim and Add Unit T...

Github user sadhen commented on a diff in the pull request: https://github.com/apache/spark/pull/23268#discussion_r240098620 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveShim.scala --- @@ -53,19 +53,12 @@ private[hive] object HiveShim { * This function

[GitHub] spark pull request #23268: [Hive][Minor] Refactor on HiveShim and Add Unit T...

Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/23268#discussion_r240097931 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveShim.scala --- @@ -53,19 +53,12 @@ private[hive] object HiveShim { * This

[GitHub] spark pull request #23268: [Hive][Minor] Refactor on HiveShim and Add Unit T...

Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/23268#discussion_r240097105 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveShim.scala --- @@ -53,19 +53,12 @@ private[hive] object HiveShim { * This

[GitHub] spark pull request #23268: [Hive][Minor] Refactor on HiveShim and Add Unit T...

GitHub user sadhen opened a pull request: https://github.com/apache/spark/pull/23268 [Hive][Minor] Refactor on HiveShim and Add Unit Tests ## What changes were proposed in this pull request? Refactor on HiveShim, and add Unit Tests. ## How was this patch tested?