Re: [Rpm-maint] [rpm-software-management/rpm] RPM 4.18.2 bugfix update (PR #2744)

2023-11-10 Thread Panu Matilainen
Seems we have some more last-minute candidates :innocent: https://github.com/rpm-software-management/rpm/pull/2759 and https://github.com/rpm-software-management/rpm/pull/2758/commits/6773676e2e62e35d347c54f2f15e8f0354e4893b -- Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Replace rpm2cpio with rpm2archive (PR #2758)

2023-11-10 Thread Panu Matilainen
@pmatilai pushed 9 commits. 7ebb3c2021f36c590a7fec2cae0762c72e57cd12 Split the two rpm2archive tests to separate test-cases 436d25180607100fc0d50466914656949718afc2 Use the expected rpm2cpio-like syntax for rpm2archive tests 1b045a8f77961ab5abe7b9bd39175f76be219aac Fix some invalid rpm2cpio

[Rpm-maint] [rpm-software-management/rpm] Fix sbit removal if fchmodat() doesn't support AT_SYMLINK_NOFOLLOW (PR #2759)

2023-11-10 Thread Panu Matilainen
glibc versions prior to 2020 know about AT_SYMLINK_NOFOLLOW but dont actually implement it for fchmodat() and returns ENOSYS when used. We dont check the return code in removeSBITS() so this silently fails on those older versions. We already verify the thing is not a link in the fstatat()

Re: [Rpm-maint] [rpm-software-management/rpm] Fix sbit removal if fchmodat() doesn't support AT_SYMLINK_NOFOLLOW (PR #2759)

2023-11-10 Thread Panu Matilainen
Merged #2759 into master. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2759#event-10922865994 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] RPM 4.18.2 bugfix update (PR #2744)

2023-11-10 Thread Michal Domonkos
Friday is the perfect release day :smile: -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2744#issuecomment-1805366104 You are receiving this because you are subscribed to this thread. Message ID:

Re: [Rpm-maint] [rpm-software-management/rpm] Replace rpm2cpio with rpm2archive (PR #2758)

2023-11-10 Thread Michal Domonkos
@dmnks commented on this pull request. > @@ -141,10 +163,20 @@ static int process_package(rpmts ts, const char * > filename) exit(EXIT_FAILURE); } } -if (archive_write_set_format_pax_restricted(a) != ARCHIVE_OK) { - fprintf(stderr, "Error: Format pax

[Rpm-maint] [rpm-software-management/rpm] RFE: rename LONGFOO size tags to FOO (Issue #2760)

2023-11-10 Thread Panu Matilainen
All the 64bit size tags in rpm 4.x were added as secondary "long" variants to avoid breaking existing software and to keep within v4 specifications as much as we can, but for v6 where all sizes are to be 64bit, typing LONGSIZE when you just want SIZE wont be cutting it. I think we need to

Re: [Rpm-maint] [rpm-software-management/rpm] Replace rpm2cpio with rpm2archive (PR #2758)

2023-11-10 Thread Michal Domonkos
@dmnks commented on this pull request. > @@ -141,10 +163,20 @@ static int process_package(rpmts ts, const char * > filename) exit(EXIT_FAILURE); } } -if (archive_write_set_format_pax_restricted(a) != ARCHIVE_OK) { - fprintf(stderr, "Error: Format pax

Re: [Rpm-maint] [rpm-software-management/rpm] Replace rpm2cpio with rpm2archive (PR #2758)

2023-11-10 Thread Michal Domonkos
@dmnks commented on this pull request. > @@ -141,10 +163,20 @@ static int process_package(rpmts ts, const char * > filename) exit(EXIT_FAILURE); } } -if (archive_write_set_format_pax_restricted(a) != ARCHIVE_OK) { - fprintf(stderr, "Error: Format pax

Re: [Rpm-maint] [rpm-software-management/rpm] Replace rpm2cpio with rpm2archive (PR #2758)

2023-11-10 Thread Panu Matilainen
@pmatilai commented on this pull request. > @@ -141,10 +163,20 @@ static int process_package(rpmts ts, const char * > filename) exit(EXIT_FAILURE); } } -if (archive_write_set_format_pax_restricted(a) != ARCHIVE_OK) { - fprintf(stderr, "Error: Format pax

Re: [Rpm-maint] [rpm-software-management/rpm] Make rpmfiSetFX() return code meaningful (318efba)

2023-11-10 Thread Remi Collet
Make sense Was affected, trying to build test code developed on 4.18 on EL-8 and EL-9 Finally have to ignore the return value for now => https://git.remirepo.net/cgit/tools/php-rpminfo.git/commit/?id=9f7298ac633f610af96b0b915e49596bb5520aeb -- Reply to this email directly or view it on

Re: [Rpm-maint] [rpm-software-management/rpm] RPM 4.18.2 bugfix update (PR #2744)

2023-11-10 Thread Michal Domonkos
Added the following commits: * 37b963fa5 Allow piping from rpm2archive * 5e22e0c58 rpm2archive: Properly parse popt options * 7feccb696 rpm2archive: Don't print usage on no arguments * 37ec18d86 Fix silent wait when missing input RPM package * f8b4c99bd Properly document our different macro types

Re: [Rpm-maint] [rpm-software-management/rpm] Replace rpm2cpio with rpm2archive (PR #2758)

2023-11-10 Thread Michal Domonkos
@dmnks approved this pull request. Looks good! > @@ -237,6 +273,12 @@ int main(int argc, const char *argv[]) optCon = poptGetContext(NULL, argc, argv, optionsTable, 0); poptSetOtherOptionHelp(optCon, "[OPTIONS]* "); + +if (rstreq(basename(argv[0]), "rpm2cpio")) { Clever! :smile:

Re: [Rpm-maint] [rpm-software-management/rpm] Replace rpm2cpio with rpm2archive (PR #2758)

2023-11-10 Thread Panu Matilainen
Merged #2758 into master. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2758#event-10925576772 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Replace rpm2cpio with rpm2archive (PR #2758)

2023-11-10 Thread Panu Matilainen
Okay, I guess we'll just merge then. Thanks for the eyeballs :smile: -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2758#issuecomment-1805795055 You are receiving this because you are subscribed to this thread. Message ID:

Re: [Rpm-maint] [rpm-software-management/rpm] RPM 4.18.2 bugfix update (PR #2744)

2023-11-10 Thread Michal Domonkos
@dmnks pushed 12 commits. 05aea6131018578d61655ac98e74903e8670fb27 Allow piping from rpm2archive 10f6c7316c44959bbaee5bdf15f101beb4b9e8cf rpm2archive: Properly parse popt options 0091cc4e5b467d7d380b286f4483cf5b1b2ea364 rpm2archive: Don't print usage on no arguments