Re: [Rails-core] Incrementally upgrade rails 4.1 to 4.2

2019-01-13 Thread Rob Zolkos
This post should help http://www.recursion.org/incremental-rails-upgrade/ You want to be checking the rails versions at various points in your code and gemfile. 4.1 to 4.2 is pretty easy compared to Major versions (although even they are getting easier) On Sun, Jan 13, 2019 at 5:32 PM wrote:

Re: [Rails-core] Re: [ActiveStorage] Feature Request: attachment validations

2018-11-26 Thread Rob Zolkos
Rails 6 will have validations for AS https://github.com/rails/rails/commit/e8682c5bf051517b0b265e446aa1a7eccfd47bf7#diff-c76fb6202b7f95a08fe12f40c4999ac9R11 On Mon, Nov 26, 2018 at 3:36 PM wrote: > Hi all, > > I think this is one of the essential features that are missing in Active > Storage.

Re: [Rails-core] [Feature][Generator Testing] More details in assert_file failure message

2018-09-11 Thread Rob Zolkos
I think a more helpful exception message is handy for the developer. I don't think we would need the list of existing files in the folder (this could be huge). A simple "Expected file x was not found" would be sufficient. On Wed, Sep 12, 2018 at 3:18 AM Dana Scheider wrote: > > I realized

Re: [Rails-core] Re: Making first/last deterministic when using UUID primary keys

2018-09-06 Thread Rob Zolkos
Rails already has default_scope for situations like this class Model < ApplicationRecord default_scope { order("created_at) } end Would this be sufficient? On Thu, Sep 6, 2018 at 6:24 PM Tekin Suleyman wrote: > > > On 30 Aug 2018, at 12:15, Tekin Suleyman wrote: > > Hiya, > > I’m working on