On Sat, 2 Sept 2023 at 12:43, 'Martin R' via sage-devel
wrote:
>
> Actually, it seems that I have already found an instance of the problem you
> describe, except that I do not understand it.
>
> In sage/algebras/jordan_algebra.py we have two "def __ne__", one in
> JordanAlgebraSymmetricBilinear
Thank you!
On Saturday, 2 September 2023 at 13:44:46 UTC+2 Oscar Benjamin wrote:
> On Sat, 2 Sept 2023 at 12:15, 'Martin R' via sage-devel
> wrote:
> >
> > On Saturday, 2 September 2023 at 11:39:12 UTC+2 Oscar Benjamin wrote:
> >
> > On Sat, 2 Sept 2023 at 08:44, 'Martin R' via sage-devel
> >
On Sat, 2 Sept 2023 at 12:15, 'Martin R' via sage-devel
wrote:
>
> On Saturday, 2 September 2023 at 11:39:12 UTC+2 Oscar Benjamin wrote:
>
> On Sat, 2 Sept 2023 at 08:44, 'Martin R' via sage-devel
> wrote:
>
> ...
>
> It is easy for this sort of thing to be overlooked in test code and in fact
>
Actually, it seems that I have already found an instance of the problem you
describe, except that I do not understand it.
In sage/algebras/jordan_algebra.py we have two "def __ne__", one in
JordanAlgebraSymmetricBilinear and one in SpecialJordanAlgebra.
If I remove them (moving the tests to
On Saturday, 2 September 2023 at 11:39:12 UTC+2 Oscar Benjamin wrote:
On Sat, 2 Sept 2023 at 08:44, 'Martin R' via sage-devel
wrote:
...
It is easy for this sort of thing to be overlooked in test code and in
fact
messing with __eq__/__ne__ (more so __eq__) can invalidate much of the
On Sat, 2 Sept 2023 at 08:44, 'Martin R' via sage-devel
wrote:
>
> If I understand correctly, in python3 it is no longer necessary to implement
> __ne__, if it is simply the negation of __eq__.
>
> There are currently about 200 definitions of the form
>
> def __ne__(self, other):
>
Tobias activated the functionality today (see
https://github.com/sagemath/sage/issues/35927#issuecomment-1703696369).
Kwankyu Lee schrieb am Freitag, 1. September 2023 um 22:36:56 UTC+2:
> How is this going?
>
> On Friday, August 4, 2023 at 1:54:13 AM UTC+9 seb@gmail.com wrote:
>
>> I've
If I understand correctly, in python3 it is no longer necessary to
implement __ne__, if it is simply the negation of __eq__.
There are currently about 200 definitions of the form
def __ne__(self, other):
return not (self == other)
I think it would be good to remove them. Travis
