Re: [sage-devel] automatic tests keep failling

2023-12-19 Thread Kwankyu Lee
Call me a Luddite, but let me remind you that "disputed PRs on CI" appear to be the only way to engage in discussions where the project is heading, and whether it is sustainable this way. That is a noble discussion. I humbly respect that. But we should not stop the machines, for that. --

Re: [sage-devel] automatic tests keep failling

2023-12-19 Thread Dima Pasechnik
On 19 December 2023 21:21:13 GMT, Kwankyu Lee wrote: > > >I would have assumed that no-one would look at a PR whose automatic tests >were failing, since that *should* indicate that something is wrong with the >PR. > > >+++1 > > > My complaint is that even with a PR based on the current

Re: [sage-devel] automatic tests keep failling

2023-12-19 Thread Kwankyu Lee
I would have assumed that no-one would look at a PR whose automatic tests were failing, since that *should* indicate that something is wrong with the PR. +++1 My complaint is that even with a PR based on the current develop branch, tests are failing which are not caused by the PR.

Re: [sage-devel] automatic tests keep failling

2023-12-19 Thread John Cremona
On Tue, 19 Dec 2023, 19:44 Matthias Koeppe, wrote: > Meanwhile various PRs that make improvements to the CI are waiting for > review: > - https://github.com/sagemath/sage/pull/36726 > - https://github.com/sagemath/sage/pull/36694 > - https://github.com/sagemath/sage/pull/36829 > -

Re: [sage-devel] automatic tests keep failling

2023-12-19 Thread Matthias Koeppe
Meanwhile various PRs that make improvements to the CI are waiting for review: - https://github.com/sagemath/sage/pull/36726 - https://github.com/sagemath/sage/pull/36694 - https://github.com/sagemath/sage/pull/36829 - https://github.com/sagemath/sage/pull/36498 On Tuesday, December 19, 2023 at

Re: [sage-devel] automatic tests keep failling

2023-12-19 Thread Dima Pasechnik
On 19 December 2023 14:49:19 GMT, John Cremona wrote: >On Tue, 19 Dec 2023 at 14:20, Dima Pasechnik wrote: > >> On Tue, Dec 19, 2023 at 1:54 PM John Cremona >> wrote: >> > >> > I am finding it impossible to get simple PRs to get past the automatic >> testing workflow system, which are

Re: [sage-devel] automatic tests keep failling

2023-12-19 Thread John Cremona
On Tue, 19 Dec 2023 at 14:20, Dima Pasechnik wrote: > On Tue, Dec 19, 2023 at 1:54 PM John Cremona > wrote: > > > > I am finding it impossible to get simple PRs to get past the automatic > testing workflow system, which are repeatedly failing for reasons which > have noting to do with any code

Re: [sage-devel] automatic tests keep failling

2023-12-19 Thread Dima Pasechnik
On Tue, Dec 19, 2023 at 1:54 PM John Cremona wrote: > > I am finding it impossible to get simple PRs to get past the automatic > testing workflow system, which are repeatedly failing for reasons which have > noting to do with any code I have changed. > > Two current examples are > > -

[sage-devel] automatic tests keep failling

2023-12-19 Thread John Cremona
I am finding it impossible to get simple PRs to get past the automatic testing workflow system, which are repeatedly failing for reasons which have noting to do with any code I have changed. Two current examples are - https://github.com/sagemath/sage/pull/36786 ( a simple bugfix which I

[sage-devel] Re: Help fixing doctest warnings

2023-12-19 Thread Kwankyu Lee
I openen as issue https://github.com/sagemath/sage/issues/36920 On Tuesday, December 19, 2023 at 8:41:32 PM UTC+9 Kwankyu Lee wrote: > Hi, > > The string "sig_on_count() # check sig_on/off pairings (virtual doctest)" > is from src/sage/doctest/sources.py line 234. > As I understand it, the

[sage-devel] Re: Help fixing doctest warnings

2023-12-19 Thread Kwankyu Lee
Hi, The string "sig_on_count() # check sig_on/off pairings (virtual doctest)" is from src/sage/doctest/sources.py line 234. As I understand it, the warning is caused by a bug in the method _create_doctests() in the same file, which fails to add optional tags correctly to the string. Matthias