Re: [sage-devel] A Challenge - what is wrong with this *simple* patch?

2010-01-15 Thread Peter Jeremy
On 2010-Jan-14 22:15:19 +, Dr. David Kirkby david.kir...@onetel.net wrote: Here's the patch. http://trac.sagemath.org/sage_trac/attachment/ticket/7898/singular-variables-to-names.patch I'm ambivalent about using 'cp' or '$CP' etc (though there are slight debugging advantages to the latter)

Re: [sage-devel] A Challenge - what is wrong with this *simple* patch?

2010-01-15 Thread Robert Miller
Another victim of 7818 :) On Fri, Jan 15, 2010 at 12:35 PM, Peter Jeremy peterjer...@acm.org wrote: On 2010-Jan-14 22:15:19 +, Dr. David Kirkby david.kir...@onetel.net wrote: Here's the patch. http://trac.sagemath.org/sage_trac/attachment/ticket/7898/singular-variables-to-names.patch I'm

[sage-devel] A Challenge - what is wrong with this *simple* patch?

2010-01-14 Thread Dr. David Kirkby
I submitted a patch which I believe is very simple and should not break anything, but it could not be merged into sage-4.3.1.rc0 because it breaks the Singular installation on Sage. (It was marked as fixed, then changed to 'needs work' as it fails.) Can anyone spot what is wrong with it?

Re: [sage-devel] A Challenge - what is wrong with this *simple* patch?

2010-01-14 Thread Tim Daly
Dr. David Kirkby wrote: I submitted a patch which I believe is very simple and should not break anything, but it could not be merged into sage-4.3.1.rc0 because it breaks the Singular installation on Sage. (It was marked as fixed, then changed to 'needs work' as it fails.) Can anyone spot

Re: [sage-devel] A Challenge - what is wrong with this *simple* patch?

2010-01-14 Thread Dr. David Kirkby
Tim Daly wrote: Dr. David Kirkby wrote: I submitted a patch which I believe is very simple and should not break anything, but it could not be merged into sage-4.3.1.rc0 because it breaks the Singular installation on Sage. (It was marked as fixed, then changed to 'needs work' as it fails.)