Martin Albrecht reviewed the code (https://trac.sagemath.org/ticket/22986#comment:5) and asked whether the SBox class should be available in the global namespace. I don't have a opinion here, so I can just remove that import, or does someone think it should be available?
Am Mittwoch, 10. Mai 2017 15:19:20 UTC+2 schrieb Friedrich Wiemer: > > Martin Albrecht commented on issue 20336 ( > https://trac.sagemath.org/ticket/20336#comment:10) that the SBox code > should be moved from crypto.mq.SBox to some other place. I think that this > is a simple enough issue to get started contributing to the sage > development, so I'd like to work on this. Do you have any opinion, where > the code should go to? My suggestion would be crypto.sbox. > > Another nice thing would be, to have common sboxes available in this > module, like the AES sbox etc. I have a list of SBoxes from a colleague > that I could add. But again, I have no idea, what the best structure would > be. Maybe a dictionary of the form: > sboxes['AES'] = SBox([...]) > sboxes['PRESENT'] = SBox([...]) > sboxes['Skinny'] = SBox([...]) > ? > > Thanks for your answers in advance, cheers > Friedrich > -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To post to this group, send email to sage-devel@googlegroups.com. Visit this group at https://groups.google.com/group/sage-devel. For more options, visit https://groups.google.com/d/optout.
