Re: [sage-devel] Re: keywords in github

2023-09-29 Thread William Stein 
On Fri, Sep 29, 2023 at 4:13 AM kcrisman  wrote:
> GitHub search is terrible, and I don't understand why.  I often (not on this 
> project) search for words (not just text strings) that I know I present 
> multiple times in the codebase, and get no results at all.  Sort of defeats 
> the point of a web-based interface if you end up needing to use a local 
> terminal anyway.

GitHub *CODE* search is extremely good, as of May 2023:

https://github.blog/2023-05-08-github-code-search-is-generally-available/

"Second, we’ve built a new code search engine, completely from
scratch. It is incredibly fast (about twice as fast as the old code
search), far more capable (supporting substring queries, regular
expressions, and symbol search), and understands code, putting the
most relevant results first."

GitHub *issue* search is weak, being some sort of relatively simple
index on the words, as mentioned elsewhere in this thread.  I hope the
group that massively improved code search will do the same for issue
search.

 William




-- 
William (http://wstein.org)

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/CACLE5GAM8eepFBrVrpBuH_aT1p-0XEJmkMVoV2_tyjFYviiPhw%40mail.gmail.com.

Re: [sage-devel] What's the point of GF(2, impl='ntl')?

2023-09-29 Thread Vincent Delecroix 
I definitely agree about tests! There should be a generic "test suite"
that should systematically be run with these all different
implementations. It is a bit ridiculous that your example was not
caught.

On Fri, 29 Sept 2023 at 17:53, John H Palmieri  wrote:
>
> First, an error in the original message: it should have been 
> "identity_matrix(F, 1)". That doesn't make any difference in the behavior. A 
> little exploration suggests that the problem goes away if you make the 
> identity matrix sparse: the problem may be with multiplying a dense matrix 
> with a vector. I'm not sure about this, though.
>
> This is with the most recent beta, built from scratch on several different OS 
> X machines. It also happens on Sagecell. I have not yet opened an issue, 
> because there are deeper existential questions: if linear algebra over this 
> field is broken, and if there are no doctests to detect that it's broken, how 
> viable is this implementation? How long has it been broken? Why has no one 
> noticed? What is it used for? Should we keep it?
>
> I think that if someone wanted to add a new implementation of a field to Sage 
> today, we would insist on doctests verifying that it worked as a drop-in 
> replacement for the existing implementations everywhere in Sage where fields 
> get used. GF(2, impl='ntl') does not meet this standard. Someone can 
> presumably fix this one bug, but is someone willing to add all of the 
> doctests that should really be added?
>
> On Friday, September 29, 2023 at 12:32:14 AM UTC-7 Vincent Delecroix wrote:
>>
>> What is your sage version? How did you install it? Did you open an
>> issue on github?
>>
>> Best
>> Vincent
>>
>> On Tue, 26 Sept 2023 at 07:00, John H Palmieri  wrote:
>> >
>> > Setup:
>> >
>> > sage: F = GF(2, impl='ntl')
>> > sage: m_ntl = identity_matrix(1, F)
>> > sage: v_ntl = vector(F, (1,))
>> >
>> > Now consider
>> >
>> > sage: m_ntl * v_ntl
>> > sage: v_ntl * m_ntl
>> >
>> > I'm trying to multiply a 1x1 matrix by a 1-dimensional vector, in one 
>> > order or the other. Here's what happens: the first line fails with a 
>> > SignalError, and the second actually crashes Sage. If we are defining a 
>> > field that can't do linear algebra, shouldn't there be big warnings posted 
>> > somewhere? If we are defining a field like this, are there any 
>> > expectations that it should work broadly with Sage types and 
>> > constructions? I just discovered that cup products in mod 2 cohomology 
>> > don't work when "mod 2" means coefficients in GF(2, impl='ntl'), and I 
>> > don't know if I should bother trying to fix this.
>> >
>> > For what it's worth, I get the same with `GF(2, impl='givaro')`. Also for 
>> > what it's worth, explicitly converting `v_ntl` to a matrix allows the 
>> > matrix multiplication to work.
>> >
>> > I see this on two different OS X machines, one Intel and one Apple Silicon.
>> >
>> > --
>> > John
>> >
>> > --
>> > You received this message because you are subscribed to the Google Groups 
>> > "sage-devel" group.
>> > To unsubscribe from this group and stop receiving emails from it, send an 
>> > email to sage-devel+...@googlegroups.com.
>> > To view this discussion on the web visit 
>> > https://groups.google.com/d/msgid/sage-devel/faeffb72-3b16-4f37-90c4-f969e4d5c017n%40googlegroups.com.
>
> --
> You received this message because you are subscribed to the Google Groups 
> "sage-devel" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to sage-devel+unsubscr...@googlegroups.com.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/sage-devel/378f06a5-2008-42fb-8642-32019a3a4976n%40googlegroups.com.

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/CAGEwAA%3DumacWP1W0CbyT40a9oPO6B_ejDcqc7HbZkck2Y_5kBg%40mail.gmail.com.

Re: [sage-devel] What's the point of GF(2, impl='ntl')?

2023-09-29 Thread John H Palmieri 
First, an error in the original message: it should have been 
"identity_matrix(F, 1)". That doesn't make any difference in the behavior. 
A little exploration suggests that the problem goes away if you make the 
identity matrix sparse: the problem may be with multiplying a dense matrix 
with a vector. I'm not sure about this, though.

This is with the most recent beta, built from scratch on several different 
OS X machines. It also happens on Sagecell. I have not yet opened an issue, 
because there are deeper existential questions: if linear algebra over this 
field is broken, and if there are no doctests to detect that it's broken, 
how viable is this implementation? How long has it been broken? Why has no 
one noticed? What is it used for? Should we keep it?

I think that if someone wanted to add a new implementation of a field to 
Sage today, we would insist on doctests verifying that it worked as a 
drop-in replacement for the existing implementations everywhere in Sage 
where fields get used. GF(2, impl='ntl') does not meet this standard. 
Someone can presumably fix this one bug, but is someone willing to add all 
of the doctests that should really be added?

On Friday, September 29, 2023 at 12:32:14 AM UTC-7 Vincent Delecroix wrote:

> What is your sage version? How did you install it? Did you open an
> issue on github?
>
> Best
> Vincent
>
> On Tue, 26 Sept 2023 at 07:00, John H Palmieri  
> wrote:
> >
> > Setup:
> >
> > sage: F = GF(2, impl='ntl')
> > sage: m_ntl = identity_matrix(1, F)
> > sage: v_ntl = vector(F, (1,))
> >
> > Now consider
> >
> > sage: m_ntl * v_ntl
> > sage: v_ntl * m_ntl
> >
> > I'm trying to multiply a 1x1 matrix by a 1-dimensional vector, in one 
> order or the other. Here's what happens: the first line fails with a 
> SignalError, and the second actually crashes Sage. If we are defining a 
> field that can't do linear algebra, shouldn't there be big warnings posted 
> somewhere? If we are defining a field like this, are there any expectations 
> that it should work broadly with Sage types and constructions? I just 
> discovered that cup products in mod 2 cohomology don't work when "mod 2" 
> means coefficients in GF(2, impl='ntl'), and I don't know if I should 
> bother trying to fix this.
> >
> > For what it's worth, I get the same with `GF(2, impl='givaro')`. Also 
> for what it's worth, explicitly converting `v_ntl` to a matrix allows the 
> matrix multiplication to work.
> >
> > I see this on two different OS X machines, one Intel and one Apple 
> Silicon.
> >
> > --
> > John
> >
> > --
> > You received this message because you are subscribed to the Google 
> Groups "sage-devel" group.
> > To unsubscribe from this group and stop receiving emails from it, send 
> an email to sage-devel+...@googlegroups.com.
> > To view this discussion on the web visit 
> https://groups.google.com/d/msgid/sage-devel/faeffb72-3b16-4f37-90c4-f969e4d5c017n%40googlegroups.com
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/378f06a5-2008-42fb-8642-32019a3a4976n%40googlegroups.com.

Re: [sage-devel] What's the point of GF(2, impl='ntl')?

2023-09-29 Thread Dima Pasechnik 
On Fri, Sep 29, 2023 at 8:32 AM Vincent Delecroix
<20100.delecr...@gmail.com> wrote:
>
> What is your sage version? How did you install it? Did you open an
> issue on github?

I can confirm this happens on Linux, with a recent Sage beta, too.

This is now https://github.com/sagemath/sage/issues/36361

>
> Best
> Vincent
>
> On Tue, 26 Sept 2023 at 07:00, John H Palmieri  wrote:
> >
> > Setup:
> >
> > sage: F = GF(2, impl='ntl')
> > sage: m_ntl = identity_matrix(1, F)
> > sage: v_ntl = vector(F, (1,))
> >
> > Now consider
> >
> > sage: m_ntl * v_ntl
> > sage: v_ntl * m_ntl
> >
> > I'm trying to multiply a 1x1 matrix by a 1-dimensional vector, in one order 
> > or the other. Here's what happens: the first line fails with a SignalError, 
> > and the second actually crashes Sage. If we are defining a field that can't 
> > do linear algebra, shouldn't there be big warnings posted somewhere? If we 
> > are defining a field like this, are there any expectations that it should 
> > work broadly with Sage types and constructions? I just discovered that cup 
> > products in mod 2 cohomology don't work when "mod 2" means coefficients in 
> > GF(2, impl='ntl'), and I don't know if I should bother trying to fix this.
> >
> > For what it's worth, I get the same with `GF(2, impl='givaro')`. Also for 
> > what it's worth, explicitly converting `v_ntl` to a matrix allows the 
> > matrix multiplication to work.
> >
> > I see this on two different OS X machines, one Intel and one Apple Silicon.
> >
> > --
> > John
> >
> > --
> > You received this message because you are subscribed to the Google Groups 
> > "sage-devel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an 
> > email to sage-devel+unsubscr...@googlegroups.com.
> > To view this discussion on the web visit 
> > https://groups.google.com/d/msgid/sage-devel/faeffb72-3b16-4f37-90c4-f969e4d5c017n%40googlegroups.com.
>
> --
> You received this message because you are subscribed to the Google Groups 
> "sage-devel" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to sage-devel+unsubscr...@googlegroups.com.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/sage-devel/CAGEwAAm37d_yY%2B7AYbUV2dtVwXBGwE412yLGjcPi1wSCO%2BjfvA%40mail.gmail.com.

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/CAAWYfq3C7VqTiDRzCjZLbEx6vdm8G0zJg6QVwKOXwAWU9s_M6A%40mail.gmail.com.

Re: [sage-devel] Re: keywords in github

2023-09-29 Thread kcrisman 


On Thursday, September 28, 2023 at 3:52:30 PM UTC-4 Dima Pasechnik wrote:

it should be possible to search for patterns in commit messages across PRs 
- this info is in the git tree. 

GitHub metadata is harder to search, and I am quite surprised how limited 
their search options are.



GitHub search is terrible, and I don't understand why.  I often (not on 
this project) search for words (not just text strings) that I know I 
present multiple times in the codebase, and get no results at all.  Sort of 
defeats the point of a web-based interface if you end up needing to use a 
local terminal anyway.

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/935aca45-721f-416d-a750-ef54d0b3c5afn%40googlegroups.com.

Re: [sage-devel] Re: keywords in github

2023-09-29 Thread Dima Pasechnik 
On Fri, 29 Sept 2023, 08:30 'Martin R' via sage-devel, <
sage-devel@googlegroups.com> wrote:

> It was possible to click on a keyword in the ticket description and get
> all the tickets with the same keyword.
>

one can use GitHub's labels for this.
(the only problem here is that not anyone can create new labels)

>
> On Thursday, 28 September 2023 at 21:46:57 UTC+2 Matthias Koeppe wrote:
>
>> On Trac, keywords were completely free-form; there was nothing to click,
>> and there wasn't an agreement whether multiple keywords are separated by
>> whitespaces or commas or semicolons.
>>
>> In the migration, we did a frequency count of words and phrases used
>> there and transformed some of the most frequently used key words and
>> phrases to "c: " labels or other labels. See
>> https://github.com/sagemath/trac-to-github/blob/master/migrate.cfg.sagetracmigrationarchive#L44
>>
>> On Thursday, September 28, 2023 at 10:28:00 AM UTC-7 Martin R wrote:
>>
>>> I would like to have trac keywords back.  Searching issues in github
>>> seems quite difficult, for example, it seems that wildcards are not
>>> supported:
>>>
>>> "is:pr is:open lazypower" finds nothing wereas "is:pr is:open
>>> lazypowerseries" does.
>>>
>>> On trac, I used keywords to collect the issues that concerned me and
>>> make them available on one click.  I.e., whenever someone submitted
>>> something about "FriCAS", I added that keyword, or "LazyPowerSeries", or
>>> "species".  Of course, I can add keywords myself now, as I could do on
>>> trac, but on trac it was easier to remember the keywords I used, because
>>> they were available by one click.
>>>
>>> Is there another way to achieve something similar?
>>>
>>> Martin
>>>
>> --
> You received this message because you are subscribed to the Google Groups
> "sage-devel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to sage-devel+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/sage-devel/7f3eb969-8ab8-4b9d-9ff6-d3b967884d71n%40googlegroups.com
> 
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/CAAWYfq3a8VzQNb1hF6A7G9yLc0zHbKCxF-nio7P2spTJ_mndbA%40mail.gmail.com.

[sage-devel] Re: keywords in github

2023-09-29 Thread Ricardo Buring 
As for another way to achieve something similar: there are Projects where 
you can make a table of issues (and you can add extra columns to the table, 
such as a Notes column).

You can do it privately:

https://docs.github.com/en/issues/planning-and-tracking-with-projects/learning-about-projects/quickstart-for-projects#creating-a-user-project

or it can be done on the organization level:

https://docs.github.com/en/issues/planning-and-tracking-with-projects/learning-about-projects/quickstart-for-projects#creating-an-organization-project

I'm not sure how the latter works permission-wise. Anyway, something to 
consider.

Best regards,
Ricardo

On Thursday, September 28, 2023 at 7:28:00 PM UTC+2 Martin R wrote:

> I would like to have trac keywords back.  Searching issues in github seems 
> quite difficult, for example, it seems that wildcards are not supported: 
>
> "is:pr is:open lazypower" finds nothing wereas "is:pr is:open 
> lazypowerseries" does.
>
> On trac, I used keywords to collect the issues that concerned me and make 
> them available on one click.  I.e., whenever someone submitted something 
> about "FriCAS", I added that keyword, or "LazyPowerSeries", or "species".  
> Of course, I can add keywords myself now, as I could do on trac, but on 
> trac it was easier to remember the keywords I used, because they were 
> available by one click.
>
> Is there another way to achieve something similar?
>
> Martin
>

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/bb79a42a-83d6-4785-8947-1647085d2791n%40googlegroups.com.

Re: [sage-devel] What's the point of GF(2, impl='ntl')?

2023-09-29 Thread Vincent Delecroix 
What is your sage version? How did you install it? Did you open an
issue on github?

Best
Vincent

On Tue, 26 Sept 2023 at 07:00, John H Palmieri  wrote:
>
> Setup:
>
> sage: F = GF(2, impl='ntl')
> sage: m_ntl = identity_matrix(1, F)
> sage: v_ntl = vector(F, (1,))
>
> Now consider
>
> sage: m_ntl * v_ntl
> sage: v_ntl * m_ntl
>
> I'm trying to multiply a 1x1 matrix by a 1-dimensional vector, in one order 
> or the other. Here's what happens: the first line fails with a SignalError, 
> and the second actually crashes Sage. If we are defining a field that can't 
> do linear algebra, shouldn't there be big warnings posted somewhere? If we 
> are defining a field like this, are there any expectations that it should 
> work broadly with Sage types and constructions? I just discovered that cup 
> products in mod 2 cohomology don't work when "mod 2" means coefficients in 
> GF(2, impl='ntl'), and I don't know if I should bother trying to fix this.
>
> For what it's worth, I get the same with `GF(2, impl='givaro')`. Also for 
> what it's worth, explicitly converting `v_ntl` to a matrix allows the matrix 
> multiplication to work.
>
> I see this on two different OS X machines, one Intel and one Apple Silicon.
>
> --
> John
>
> --
> You received this message because you are subscribed to the Google Groups 
> "sage-devel" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to sage-devel+unsubscr...@googlegroups.com.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/sage-devel/faeffb72-3b16-4f37-90c4-f969e4d5c017n%40googlegroups.com.

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/CAGEwAAm37d_yY%2B7AYbUV2dtVwXBGwE412yLGjcPi1wSCO%2BjfvA%40mail.gmail.com.

[sage-devel] Re: keywords in github

2023-09-29 Thread 'Martin R' via sage-devel 
It was possible to click on a keyword in the ticket description and get all 
the tickets with the same keyword.

On Thursday, 28 September 2023 at 21:46:57 UTC+2 Matthias Koeppe wrote:

> On Trac, keywords were completely free-form; there was nothing to click, 
> and there wasn't an agreement whether multiple keywords are separated by 
> whitespaces or commas or semicolons.
>
> In the migration, we did a frequency count of words and phrases used there 
> and transformed some of the most frequently used key words and phrases to 
> "c: " labels or other labels. See 
> https://github.com/sagemath/trac-to-github/blob/master/migrate.cfg.sagetracmigrationarchive#L44
>
> On Thursday, September 28, 2023 at 10:28:00 AM UTC-7 Martin R wrote:
>
>> I would like to have trac keywords back.  Searching issues in github 
>> seems quite difficult, for example, it seems that wildcards are not 
>> supported: 
>>
>> "is:pr is:open lazypower" finds nothing wereas "is:pr is:open 
>> lazypowerseries" does.
>>
>> On trac, I used keywords to collect the issues that concerned me and make 
>> them available on one click.  I.e., whenever someone submitted something 
>> about "FriCAS", I added that keyword, or "LazyPowerSeries", or "species".  
>> Of course, I can add keywords myself now, as I could do on trac, but on 
>> trac it was easier to remember the keywords I used, because they were 
>> available by one click.
>>
>> Is there another way to achieve something similar?
>>
>> Martin
>>
>

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/7f3eb969-8ab8-4b9d-9ff6-d3b967884d71n%40googlegroups.com.