Re: [sane-devel] Proposal to disallow direct pushes to the master branch

2019-10-26 Thread Rolf Bensch
Hi Povilas, Am 24.10.19 um 19:19 schrieb Povilas Kanapickas: > > I think it's not completely true that changing code in a certain backend > affects only that backend. The problem is that by default all backends > are built and any compile errors will affect every user of sane > backends. Using

Re: [sane-devel] Proposal to disallow direct pushes to the master branch

2019-10-26 Thread Rolf Bensch
Hi Povilas, Am 24.10.19 um 19:19 schrieb Povilas Kanapickas: > > I think it's not completely true that changing code in a certain backend > affects only that backend. The problem is that by default all backends > are built and any compile errors will affect every user of sane > backends. Using

Re: [sane-devel] Proposal to disallow direct pushes to the master branch

2019-10-24 Thread Povilas Kanapickas
Hi Olaf, On 10/21/19 1:25 AM, Olaf Meeuwissen wrote: >> What do you think about this? > > So while I certainly agree that using GitLab merge requests is a good > idea (and should be encouraged), I am not completely convinced that it > should be made the *only* way to push code changes. > > I

Re: [sane-devel] Proposal to disallow direct pushes to the master branch

2019-10-24 Thread Povilas Kanapickas
Hi Rolf, On 10/12/19 6:22 PM, Rolf Bensch wrote: > Hi Povilas, > > I think using branches depends on the complexity of the changes|fixes. > > Document file updates and simple fixes which don't change "my" backend's > functional structure can be committed directly into master. > > If new code

Re: [sane-devel] Proposal to disallow direct pushes to the master branch

2019-10-20 Thread Olaf Meeuwissen
Hi Povilas, # I've been mulling this over for a bit, hence the belated reply. # Please note that there is actually an [issue][0] on this topic as well. # # [0]: https://gitlab.com/sane-project/ops/issues/5 # # @llagendijk> Thanks for reminding me. Povilas Kanapickas writes: > Hi, > > Currently

Re: [sane-devel] Proposal to disallow direct pushes to the master branch

2019-10-12 Thread Rolf Bensch
Hi Povilas, I think using branches depends on the complexity of the changes|fixes. Document file updates and simple fixes which don't change "my" backend's functional structure can be committed directly into master. If new code touches my backend's functional structure, other backends or sane

[sane-devel] Proposal to disallow direct pushes to the master branch

2019-10-11 Thread Povilas Kanapickas
Hi, Currently there are two ways to submit code to the sane-project/backends repository: directly pushing to master and creating a merge request on GitLab. I'd like to propose we only allow the use of the latter option. Direct pushes have the risk of accidentally breaking the build or tests. Our