Re: [sane-devel] Requiring GitLab merge requests for all changes

2022-06-01 Thread m. allan noah
I thought I'd reanimate this discussion to see if I could get a little help. I've been working on SANE for many years, even before we used git. I've been committing and pushing to master from the beginning. I pretty much use the command line exclusively. I've never had a problem I could not

Re: [sane-devel] Requiring GitLab merge requests for all changes

2022-01-03 Thread Povilas Kanapickas
On 1/2/22 6:30 PM, Ralph Little wrote> On 2022-01-02 3:14 a.m., Povilas Kanapickas wrote: >> On 1/2/22 5:07 AM, Ralph Little wrote: > Personally, I always make changes to branches. I don't believe that > there should be functional changes direct to master, even for small > corrections.

Re: [sane-devel] Requiring GitLab merge requests for all changes

2022-01-02 Thread Ralph Little
On 2022-01-02 3:14 a.m., Povilas Kanapickas wrote: On 1/2/22 5:07 AM, Ralph Little wrote: Personally, I always make changes to branches. I don't believe that there should be functional changes direct to master, even for small corrections. I don't know if I would necessarily go all the way to

Re: [sane-devel] Requiring GitLab merge requests for all changes

2022-01-02 Thread Povilas Kanapickas
On 1/2/22 5:07 AM, Ralph Little wrote: > Hi, > > On 2022-01-01 6:56 p.m., Povilas Kanapickas wrote: >> On 12/31/21 12:36 AM, Ralph Little wrote: >>> Hi, >>> >>> On 2021-12-29 1:46 p.m., Povilas Kanapickas wrote: Hello, What do you think about requiring merge requests for all

Re: [sane-devel] Requiring GitLab merge requests for all changes

2022-01-01 Thread Ralph Little
Hi, On 2022-01-01 6:56 p.m., Povilas Kanapickas wrote: On 12/31/21 12:36 AM, Ralph Little wrote: Hi, On 2021-12-29 1:46 p.m., Povilas Kanapickas wrote: Hello, What do you think about requiring merge requests for all incoming changes on the sane-backends repository? This mostly doesn't

Re: [sane-devel] Requiring GitLab merge requests for all changes

2022-01-01 Thread Povilas Kanapickas
On 12/31/21 12:36 AM, Ralph Little wrote: > Hi, > > On 2021-12-29 1:46 p.m., Povilas Kanapickas wrote: >> Hello, >> >> What do you think about requiring merge requests for all incoming >> changes on the sane-backends repository? >> >> This mostly doesn't change the current process because the

Re: [sane-devel] Requiring GitLab merge requests for all changes

2021-12-31 Thread Wolfram Sang
> What do you think about requiring merge requests for all incoming > changes on the sane-backends repository? I am all for it. I think there _always_ should be room for review, regardless how unlikely it is that someone will actually do it. > I can only think a single reasonable exception for

Re: [sane-devel] Requiring GitLab merge requests for all changes

2021-12-30 Thread Ralph Little
Hi, On 2021-12-29 1:46 p.m., Povilas Kanapickas wrote: Hello, What do you think about requiring merge requests for all incoming changes on the sane-backends repository? This mostly doesn't change the current process because the majority of changes land to master via merge requests already. If

[sane-devel] Requiring GitLab merge requests for all changes

2021-12-29 Thread Povilas Kanapickas
Hello, What do you think about requiring merge requests for all incoming changes on the sane-backends repository? This mostly doesn't change the current process because the majority of changes land to master via merge requests already. If the developer does not think a true review is necessary