Re: [sane-devel] Proposed Upgrade (pu) branches on GitLab

Stef writes: > On 16/09/2015 13:07, Olaf Meeuwissen wrote: >> Hi devs, >> [...] >> I would appreciate it if some of you could take a look at these branches >> and merge them to Alioth's master. >> [...] >> - pu/protect-niash-option-access-315132 because it fixes a slightly far >> fetched

Re: [sane-devel] [PATCH v3 1/2] add PNG format to scanimage

Hi Matteo, Sorry for not replying earlier. I've reviewed your patch in more detail and things look okay. There do not seem to be any leaks (only scanned a single image) as the valgrind output is the same as for PNM output. There is one showstopper though. The 1-bit scans come out inverted. I

Re: [sane-devel] [PATCH v3 2/2] add JPEG support to scanimage

Hi Matteo, I also reviewed and tested this in more detail. The PNG remarks hold here as well and the 1-bit output is inverted. In addition, during testing I used --format=jpg which a bit to my surprise led to a PNM image. I know that was my fault but I thought that recognizing this common

Re: [sane-devel] [PATCH v3 1/2] add PNG format to scanimage

2015-09-17 15:02 GMT+02:00 Olaf Meeuwissen : > Hi Matteo, > > Sorry for not replying earlier. > > I've reviewed your patch in more detail and things look okay. There do > not seem to be any leaks (only scanned a single image) as the valgrind > output is the same as for

Re: [sane-devel] [PATCH v3 2/2] add JPEG support to scanimage

2015-09-17 15:08 GMT+02:00 Olaf Meeuwissen : > Hi Matteo, > > I also reviewed and tested this in more detail. The PNG remarks hold > here as well and the 1-bit output is inverted. > > In addition, during testing I used --format=jpg which a bit to my > surprise led to a