Re: [sane-devel] [PATCH 1/2] add PNG format to scanimage

2015-09-13 Thread Olaf Meeuwissen
Matteo Croce writes: > 2015-09-12 9:13 GMT+02:00 Olaf Meeuwissen : >> Hi Matteo, >> >> Thanks for taking the trouble to add optional PNG and JPEG output >> support! >> >> I've done a quick review of both patches and there are a few things that >> I'd like to point out:

Re: [sane-devel] [PATCH 1/2] add PNG format to scanimage

2015-09-13 Thread Matteo Croce
2015-09-13 11:15 GMT+02:00 Olaf Meeuwissen : > Matteo Croce writes: > >> 2015-09-12 9:13 GMT+02:00 Olaf Meeuwissen : >>> Hi Matteo, >>> >>> Thanks for taking the trouble to add optional PNG and JPEG output >>> support! >>> >>> I've done a quick

Re: [sane-devel] [PATCH 1/2] add PNG format to scanimage

2015-09-12 Thread Matteo Croce
2015-09-12 9:13 GMT+02:00 Olaf Meeuwissen : > Hi Matteo, > > Thanks for taking the trouble to add optional PNG and JPEG output > support! > > I've done a quick review of both patches and there are a few things that > I'd like to point out: > > - Why do you let users

Re: [sane-devel] [PATCH 1/2] add PNG format to scanimage

2015-09-12 Thread Olaf Meeuwissen
Hi Matteo, Thanks for taking the trouble to add optional PNG and JPEG output support! I've done a quick review of both patches and there are a few things that I'd like to point out: - Why do you let users select PNG/JPEG outputs even when the support is not available when HAVE_LIBPNG and/or

[sane-devel] [PATCH 1/2] add PNG format to scanimage

2015-09-10 Thread Matteo Croce
--- acinclude.m4 | 13 + configure.in | 1 + frontend/Makefile.am | 2 +- frontend/scanimage.c | 137 +++ 4 files changed, 143 insertions(+), 10 deletions(-) diff --git a/acinclude.m4 b/acinclude.m4 index a8f1b7c..41a2ea4