Re: RFR: 8145337: [JVMCI] JVMCI initialization with SecurityManager installed fails: java.security.AccessControlException: access denied

(dropping jdk9-dev. security-libs is the appropriate list to review security permission) > On Jan 23, 2017, at 1:56 PM, Doug Simon wrote: > > Both jdk.vm.ci and jdk.vm.compiler require a number of permissions when a > security manager is present. Since neither of these

Re: RFR[9] 8062731: Cipher object can be created without calling Cipher.getInstance

Fixed, thanks for the review! Valerie On 1/25/2017 5:15 PM, Bradford Wetmore wrote: Looks ok. One minor nit: 258: indention problem. Brad On 1/23/2017 12:28 PM, Valerie Peng wrote: Hi Brad, Would you have time to review this? I changed the code to base the trust decision on the

RFR: 8037325: Class.getConstructor() performance regression

Hey, your extraction of methodName() made me aware of another small thing. What about rewriting argumentTypesToString() to avoid creating the StringJoiner if not needed? private static String argumentTypesToString(Class[] argTypes) { if (argTypes != null) { StringJoiner

RFR: 8145337: [JVMCI] JVMCI initialization with SecurityManager installed fails: java.security.AccessControlException: access denied

Both jdk.vm.ci and jdk.vm.compiler require a number of permissions when a security manager is present. Since neither of these modules is accessible to application code, it should be ok to give them all permissions. This seems to be the approach for a number of other modules including

Re: RFR 8168075: Custom system class loader + security manager + malformed policy file = recursive initialization

Thanks. The fix for 8168075 was already pushed, but Mandy agreed to correct the copyright headers along with the other cleanup activity she is doing for 8172808. On 1/24/2017 8:20 PM, Weijun Wang wrote: The copyright header for src is different from that for test. You need to mention the

Re: Review Request JDK-8172808: Handle sun.security.util.Resources bundle in ResourcesMgr in the same way as AuthResources

Looks good. --Sean On 1/25/17 11:37 AM, Mandy Chung wrote: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8172808/webrev.01/ This includes a simple patch from Adam to fixup the copyright headers in the fix for JDK-8168075. Mandy On Jan 24, 2017, at 2:25 PM, Mandy Chung