> On Feb 1, 2017, at 3:07 AM, Doug Simon wrote:
>
> I’ve reworked the webrev as requested to make jdk.vm.compiler a
> non-upgradeable platform module, this allowing it to be mentioned in
> default.policy:
>
> http://cr.openjdk.java.net/~dnsimon/8145337/
Looks good.
On 2/1/17 4:27 PM, Doug Simon wrote:
Can I now consider this change reviewed and integrate it?
Yes.
--Sean
AOT tool jaotc does not run with SecurityManager. We assume it runs in secure
environment and it does not access any external resources.
Thanks
Vladimir
> On Feb 1, 2017, at 12:03 PM, Doug Simon wrote:
>
>
>> On 1 Feb 2017, at 20:54, Sean Mullan
Couple of comments:
- jdk.vm.ci is already loaded by the boot loader so it is implicitly
granted AllPermission and does not need an entry in default.policy.
- all internal APIs in the jdk.vm.compiler module will now be restricted
by default by SecurityManager::checkPackageAccess(), so if you
Looks fine to me.
--Sean
On 2/1/17 10:24 AM, Sergei Kovalev wrote:
Hi team,
Please review a small fix for tests.
Bug ID: https://bugs.openjdk.java.net/browse/JDK-8173763
WebReview: http://cr.openjdk.java.net/~skovalev/8173763/webrev.00/
Issue: Two tests failing during execution with module
> On 30 Jan 2017, at 21:55, Mandy Chung wrote:
>
>
>> On Jan 30, 2017, at 10:38 AM, Doug Simon wrote:
>>
>> I’ve extended the webrev with that change - please re-review:
>>
>> http://cr.openjdk.java.net/~dnsimon/8145337_make/webrev
>>
>
> +1
I’ve reworked the webrev as requested to make jdk.vm.compiler a non-upgradeable
platform module, this allowing it to be mentioned in default.policy:
http://cr.openjdk.java.net/~dnsimon/8145337/
-Doug
> On 30 Jan 2017, at 22:53, Mandy Chung wrote:
>
>>
>> On Jan 30,