Hi Bernd,
On 10/31/18 9:39 PM, Bernd Eckenfels wrote:
http://cr.openjdk.java.net/~dlong/8212605/webrev.1/src/java.base/share/classes/java/security/AccessController.java.udiff.html
In checkContext should the security manager be null checked first instead of
last to optimize for the typical
http://cr.openjdk.java.net/~dlong/8212605/webrev.1/src/java.base/share/classes/java/security/AccessController.java.udiff.html
In checkContext should the security manager be null checked first instead of
last to optimize for the typical case? (If the side effects in that expression
are desired
I think it's a good idea, but I believe it would require a CSR request.
Do you mind if I file a separate issue for
jdk.internal.vm.annotation.Hidden?
dl
On 10/31/18 6:11 PM, Vladimir Ivanov wrote:
Dean,
src/java.base/share/classes/java/security/AccessController.java:
+ /**
+ *
Thanks Ioi.
dl
On 10/31/18 6:01 PM, Ioi Lam wrote:
On 10/31/18 5:13 PM, dean.l...@oracle.com wrote:
On 10/31/18 4:06 PM, David Holmes wrote:
Hi Dean,
Looking only at the hotspot changes. The removal of the DoPrivileged
and related privileged_stack code seems okay. I have a few related
Thanks David.
dl
On 10/31/18 5:54 PM, David Holmes wrote:
Hi Dean,
On 1/11/2018 10:13 AM, dean.l...@oracle.com wrote:
On 10/31/18 4:06 PM, David Holmes wrote:
Hi Dean,
Looking only at the hotspot changes. The removal of the DoPrivileged
and related privileged_stack code seems okay. I have
Hi Sean
Do you also plan to remove the IDENTITYDB command and
doImportIdentityDatabase() in keytool/Main? The command is undocumented (also
not shown in "keytool -help") and the method is a no-op now.
There are also 2 strings in keytool/Resources that contain the "identity" word.
Thanks
Max
Hello Dean & David,
Interesting reading. Is DomainCombiner still being considered for
deprecation?
Our code makes heavy use of AccessController.doPrivileged.
Regards,
Peter.
"Hot Spots - Method","Self time [%]","Self time","Self time (CPU)","Samples"
Hi Dean,
On 1/11/2018 10:13 AM, dean.l...@oracle.com wrote:
On 10/31/18 4:06 PM, David Holmes wrote:
Hi Dean,
Looking only at the hotspot changes. The removal of the DoPrivileged
and related privileged_stack code seems okay. I have a few related
comments:
On 10/31/18 4:06 PM, David Holmes wrote:
Hi Dean,
Looking only at the hotspot changes. The removal of the DoPrivileged
and related privileged_stack code seems okay. I have a few related
comments:
src/hotspot/share/classfile/systemDictionary.hpp
You added the java_security_AccessController
Hi Dean,
Looking only at the hotspot changes. The removal of the DoPrivileged and
related privileged_stack code seems okay. I have a few related comments:
src/hotspot/share/classfile/systemDictionary.hpp
You added the java_security_AccessController class after
https://bugs.openjdk.java.net/browse/JDK-8212605
http://cr.openjdk.java.net/~dlong/8212605/webrev.1
This change implements AccessController.doPrivileged in Java. This
gives a performance improvement while also being useful to Project Loom
by removing the Java --> native --> Java transition.
On 10/31/18 5:25 PM, Nico Williams wrote:
I think you should put braces around the conditional statements on lines
332, 357, & 359. It would read better and avoid accidental bugs.
Is that part of a published Java style?
(Personally, I dislike braces for single statement blocks. But we'll
On Wed, Oct 31, 2018 at 05:22:27PM +0800, Weijun Wang wrote:
> > On Oct 30, 2018, at 10:28 PM, Sean Mullan wrote:
> >
> > I think you should put braces around the conditional statements on lines
> > 332, 357, & 359. It would read better and avoid accidental bugs.
Is that part of a published
On 10/31/2018 8:52 AM, Chris Hegarty wrote:
Xuelei,
On 30/10/18 20:55, Xuelei Fan wrote:
Hi,
For the current HttpsURLConnection, there is not much security
parameters exposed in the public APIs. An application may need richer
information for the underlying TLS connections, for example the
Xuelei,
On 30/10/18 20:55, Xuelei Fan wrote:
Hi,
For the current HttpsURLConnection, there is not much security
parameters exposed in the public APIs. An application may need richer
information for the underlying TLS connections, for example the
negotiated TLS protocol version.
Please
Looks fine to me.
--Sean
On 10/30/18 2:58 PM, Rajan Halade wrote:
Please review this fix to update test certificates used in QuoVadis CA
tests.
Webrev: http://cr.openjdk.java.net/~rhalade/8207059/webrev.00/
Thanks,
Rajan
Copying Nico the original author.
> On Oct 30, 2018, at 10:28 PM, Sean Mullan wrote:
>
> I think you should put braces around the conditional statements on lines 332,
> 357, & 359. It would read better and avoid accidental bugs.
>
> Where does delegatedCred get used? It seems to be never
Hi Rajan, thanks for looking into it.
Change looks good to me (not a Reviewer however).
The QuoVadisCA.javatest passed on linux x86_64 (run with current
jdk/jdk build).
Would be probably a good idea to bring this also into jdk11 .
Thanks, Matthias
> -Original Message-
18 matches
Mail list logo
