On Wed, 18 May 2022 14:46:42 GMT, Alexey Ivanov wrote:
> Replaces usages of articles that follow each other in all combinations:
> a/the, an?/an?, the/the…
>
> It's the last issue in the series, and it still touches different areas of
> the code.
Marked as reviewed by iris (Reviewer).
On Wed, 18 May 2022 13:27:24 GMT, Alexey Ivanov wrote:
> Replaces usages of articles that follow each other in all combinations:
> a/the, an?/an?, the/the…
>
> Also, I fixed a couple of spelling mistakes.
Marked as reviewed by iris (Reviewer).
-
PR:
On Sat, 7 May 2022 01:04:03 GMT, Jonathan Gibbons wrote:
> Please review a fix to remove incorrect use of the `@serial` tag from the doc
> comments for methods such as `readObject` and `readResolve`. The tag has no
> effect in this position other than to trigger warnings from the standard
>
On Thu, 14 Apr 2022 19:07:09 GMT, Magnus Ihse Bursie wrote:
> I ran `codespell` on the `src/java.base` directory, and accepted those
> changes where it indeed discovered real typos.
>
> (Due to false positives this can unfortunately not be run automatically)
>
> The majority of fixes are in
On Wed, 6 Apr 2022 17:45:13 GMT, Naoto Sato wrote:
> This is a follow-on task after deprecating the Locale constructors
> (https://bugs.openjdk.java.net/browse/JDK-8282819). Most of the changes are
> simple replacements to Locale constructors with `Locale.of()` or Locale
> constants, such as
On Sun, 20 Mar 2022 13:30:01 GMT, Andrey Turbanov wrote:
> Fix repeated type `exeption`
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/7879
On Tue, 8 Mar 2022 08:02:16 GMT, Xue-Lei Andrew Fan wrote:
>> Please review this small API enhancement to add the usual constructors
>> taking a cause to javax.net.ssl exceptions. The use of initCause in the
>> JSSE implementation code is updated to use the new constructors accordingly.
>>
On Fri, 18 Mar 2022 21:00:40 GMT, Bradford Wetmore wrote:
>> Xue-Lei Andrew Fan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> more test case udpate
>
> test/jdk/javax/net/ssl/SSLException/CheckSSLHandshakeException.java line 2:
>
>>
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote:
> Hi
>
> I have reviewed the code for removing double semicolons at the end of lines
>
> all the best
> matteo
Nice tidy of the code.
Is there anything that can be done to prevent re-introduction of this trivial
problem? Perhaps a new
On Tue, 1 Feb 2022 21:11:39 GMT, Joe Darcy wrote:
> The references to JOSS, the Java Object Serialization Specification, are not
> done consistently in the API javadoc. This should be improved.
>
> I'll update copyright years before pushing.
Marked as reviewed by iris (Reviewer).
On Wed, 19 Jan 2022 22:18:32 GMT, Weijun Wang wrote:
> Two edits.
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/7147
On Sun, 26 Sep 2021 15:10:52 GMT, Andrey Turbanov wrote:
> In couple of classes, result part of arrays of Pattern.split is compared with
> `null`. Pattern.split (and hence String.split) never returns `null` in array
> elements. Such comparisons are redundant.
Marked as reviewed by iris
On Tue, 2 Nov 2021 16:30:56 GMT, Pavel Rappo wrote:
> This PR follows up one of the recent PRs, where I used a non-canonical
> modifier order. Since the problem was noticed [^1], why not to address it at
> mass?
>
> As far as I remember, the first mass-canonicalization of modifiers took place
On Wed, 22 Sep 2021 15:38:33 GMT, Pavel Rappo wrote:
>> 8274075: Fix miscellaneous typos in java.base
>
> Pavel Rappo has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add missing "the"
>
> (Spotted by Brian Burkhalter.)
Marked as
On Tue, 21 Sep 2021 13:16:02 GMT, Pavel Rappo wrote:
>> 8274075: Fix miscellaneous typos in java.base
>
> Pavel Rappo has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Tweak wording for Throwable constructor parameters
Marked as reviewed by
On Wed, 1 Sep 2021 07:37:53 GMT, Andrey Turbanov
wrote:
> There are few places in code where manual while loop is used with Iterator to
> iterate over Collection.
> Instead of manual while cycles it's preferred to use enhanced-for cycle
> instead: it's less verbose, makes code easier to read
On Wed, 26 May 2021 02:22:42 GMT, Tagir F. Valeev wrote:
>> Inspired by PR#4088. Most of the changes are done automatically using
>> IntelliJ IDEA refactoring. Some manual adjustments are also performed,
>> including indentations, moving comments, extracting common cast out of
>> switch
On Fri, 19 Mar 2021 18:23:00 GMT, Alex Blewitt
wrote:
> Additional changes found in `java.base` of `final private` -> `private
> final`. Filed with existing bug because it's the same module; can change to a
> different bug number if required.
Marked as reviewed by iris (Reviewer).
On Thu, 11 Mar 2021 01:13:12 GMT, Bradford Wetmore wrote:
> Disable the "missing" target for java.smartcardio from doclint.
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/2930
On Tue, 9 Mar 2021 22:19:28 GMT, Bradford Wetmore wrote:
>> Fix various things pointed out by the most recent doclint run in the
>> security-libs area.
>>
>> This is docs only: I will be checking doccheck/doclint, and will be running
>> tier1/tier2 tests. Minor spot checks on generated
On Sat, 6 Mar 2021 07:31:09 GMT, Bradford Wetmore wrote:
> Fix various things pointed out by the most recent doclint run in the
> security-libs area.
>
> This is docs only: I will be checking doccheck/doclint, and will be running
> tier1/tier2 tests. Minor spot checks on generated files.
On Mon, 8 Mar 2021 18:48:30 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my code for updating the code in the `java.io`,
> `java.math`, and `java.text` packages to make use of the `instanceof` pattern
> variable?
>
> Kind regards,
> Patrick
Marked as reviewed by iris
On Thu, 22 Oct 2020 17:16:23 GMT, Jonathan Gibbons wrote:
> The change is (just) to remove legacy usages of a JDK-private custom tag.
Nice clean-up.
-
Marked as reviewed by iris (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/814
Hi, Sean.
These changes look good.
Thanks,
iris
-Original Message-
From: Sean Mullan
Sent: Wednesday, January 2, 2019 12:43 PM
To: security Dev OpenJDK ; IRIS,CLARK
Subject: RFR (12): 8215318: Amend the Standard Algorithm Names specification to
clarify that names can be defined
Hi, Anthony, Brad, Max, Sean, and Valerie.
Just a quick thanks to all for your time in reviewing this issue. I pushed the
changeset this morning to verona/stage. Expect the changeset to get to jdk9/*
when we Verona is complete, later this summer.
Regards,
iris
-Original Message-
if you have any additional concerns.
Thanks,
iris
-Original Message-
From: Sean Mullan
Sent: Thursday, July 09, 2015 9:23 AM
To: Weijun Wang; Iris Clark; security-dev@openjdk.java.net
Subject: Re: RFR: (s) 8130696: Security Providers need to have their version
numbers updated for JDK 9
Hi, Max.
Thanks for taking the time to review.
Regards,
iris
-Original Message-
From: Weijun Wang
Sent: Wednesday, July 08, 2015 8:57 PM
To: Iris Clark; security-dev@openjdk.java.net
Subject: Re: RFR: (s) 8130696: Security Providers need to have their version
numbers updated for JDK 9
On 7/7/2015 10:48 AM, Iris Clark wrote:
Hi.
Please review changes to resolve the following bug:
8130696: Security Providers need to have their version numbers updated for JDK
9 (Verona)
Bug: https://bugs.openjdk.java.net/browse/JDK-8130696
Changeset: http://cr.openjdk.java.net/~iris
Hi.
Please review changes to resolve the following bug:
8130696: Security Providers need to have their version numbers updated for JDK
9 (Verona)
Bug: https://bugs.openjdk.java.net/browse/JDK-8130696
Changeset: http://cr.openjdk.java.net/~iris/verona/8130696/webrev
The
Hi, Jeremy.
As an Author, you can create a changeset but you can't push to the repo until
you're a Committer. Additional details about the differences between Author
and Committer may be found here [1,2].
The diffs to create a changeset are (of course) in your webrev. Your Sponsor
can use
So overall it looks good to me and should be pushed to the staging forest
once you hear from others that commented previously.
I think that means Chris Hegarty, Michael McMahon, and Sergey Bylokhov. Alan,
please correct me if I'm wrong.
Thanks,
iris
-Original Message-
From: Alan
31 matches
Mail list logo
