Re: RFR: 8319332: Security properties files inclusion

2023-11-02 Thread Alan Bateman
On Thu, 2 Nov 2023 22:20:02 GMT, Martin Balao wrote: >> src/java.base/share/classes/java/security/Security.java line 243: >> >>> 241: if (connection instanceof FileURLConnection >>> fileConnection) { >>> 242: // A local file URL can be interpreted as a Path >>> 243:

Re: RFR: 8319332: Security properties files inclusion

2023-11-02 Thread Martin Balao
On Thu, 2 Nov 2023 20:07:28 GMT, Alan Bateman wrote: >> The implementation of this proposal is based on the requirements, >> specification and design choices described in the [JDK-8319332] ticket and >> its respective CSR [JDK-8319333]. What follows are implementation notes >> organized per

Re: RFR: 8308453: Convert JKS test keystores in test/jdk/javax/net/ssl/etc to PKCS12 [v11]

2023-11-02 Thread Weijun Wang
On Thu, 2 Nov 2023 18:43:19 GMT, Kevin Driver wrote: >> JDK-8308453: JSSE regression test keystore migration from JKS to PKCS12 > > Kevin Driver has updated the pull request incrementally with one additional > commit since the last revision: > > code review comments Looks good to me. BTW,

Re: RFR: 8319332: Security properties files inclusion

2023-11-02 Thread Alan Bateman
On Thu, 2 Nov 2023 19:07:48 GMT, Francisco Ferrari Bihurriet wrote: > The implementation of this proposal is based on the requirements, > specification and design choices described in the [JDK-8319332] ticket and > its respective CSR [JDK-8319333]. What follows are implementation notes >

RFR: 8319332: Security properties files inclusion

2023-11-02 Thread Francisco Ferrari Bihurriet
The implementation of this proposal is based on the requirements, specification and design choices described in the [JDK-8319332] ticket and its respective CSR [JDK-8319333]. What follows are implementation notes organized per functional component, with the purpose of assisting to navigate the

Re: RFR: 8308453: Convert JKS test keystores in test/jdk/javax/net/ssl/etc to PKCS12 [v11]

2023-11-02 Thread Kevin Driver
> JDK-8308453: JSSE regression test keystore migration from JKS to PKCS12 Kevin Driver has updated the pull request incrementally with one additional commit since the last revision: code review comments - Changes: - all: https://git.openjdk.org/jdk/pull/16159/files - new:

Integrated: 8317374: Add Let's Encrypt ISRG Root X2

2023-11-02 Thread Rajan Halade
On Wed, 1 Nov 2023 16:10:23 GMT, Rajan Halade wrote: > This PR is to add new TLS root certificates from Let's Encrypt. This CA has > gone through > https://www.oracle.com/java/technologies/javase/carootcertsprogram.html > process. > > > The release-note is at >

Integrated: 8319213: Compatibility.java reads both stdout and stderr of JdkUtils

2023-11-02 Thread Weijun Wang
On Wed, 1 Nov 2023 14:03:08 GMT, Weijun Wang wrote: > There might be more warnings from the java launcher. Better ignore them now. This pull request has now been integrated. Changeset: 84f4f747 Author:Weijun Wang URL:

Re: RFR: 8319213: Compatibility.java reads both stdout and stderr of JdkUtils

2023-11-02 Thread Rajan Halade
On Wed, 1 Nov 2023 14:03:08 GMT, Weijun Wang wrote: > There might be more warnings from the java launcher. Better ignore them now. Marked as reviewed by rhalade (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/16450#pullrequestreview-1710918172

Re: RFR: 8317374: Add Let's Encrypt ISRG Root X2

2023-11-02 Thread Sean Mullan
On Wed, 1 Nov 2023 16:10:23 GMT, Rajan Halade wrote: > This PR is to add new TLS root certificates from Let's Encrypt. This CA has > gone through > https://www.oracle.com/java/technologies/javase/carootcertsprogram.html > process. > > > The release-note is at >

Integrated: 8317332: Prepare security for permissive-

2023-11-02 Thread Julian Waters
On Sat, 30 Sep 2023 06:26:10 GMT, Julian Waters wrote: > Prepares java.security.jgss for the permissive- compiler switch by > > - Adding scopes so goto doesn't jump over unitialized locals in sspi.cpp > - Adding a static modifier to a mismatched method declaration in > NativeCreds.c, as the

Re: RFR: 8317332: Prepare security for permissive- [v3]

2023-11-02 Thread Julian Waters
On Tue, 3 Oct 2023 02:55:09 GMT, Julian Waters wrote: >> Prepares java.security.jgss for the permissive- compiler switch by >> >> - Adding scopes so goto doesn't jump over unitialized locals in sspi.cpp >> - Adding a static modifier to a mismatched method declaration in >> NativeCreds.c, as