On Thu, 11 Apr 2024 16:29:00 GMT, Ben Perez wrote:
> Updated `getService` to check whether `getProvider` returns null when
> checking for preferred providers and `continue` the loop if that is the case.
> Added `NullPreferredList` test.
This pull request has now been integrated.
> Updated `getService` to check whether `getProvider` returns null when
> checking for preferred providers and `continue` the loop if that is the case.
> Added `NullPreferredList` test.
Ben Perez has updated the pull request with a new target base due to a merge or
a rebase. The in
Updated `getService` to check whether `getProvider` returns null when checking
for preferred providers and `continue` the loop if that is the case. Added
`NullPreferredList` test.
-
Commit messages:
- Fixed and renamed test, getService now continues loop instead of returning
null
On Mon, 1 Apr 2024 17:39:07 GMT, Ben Perez wrote:
> Removed `PrivateKeyUsagePeriod` from method javadoc and added several
> commonly used extensions
This pull request has now been integrated.
Changeset: 316361b9
Author: Ben Perez
Committer: Sean Mullan
URL:
https://git.openj
> Removed `PrivateKeyUsagePeriod` from method javadoc and added several
> commonly used extensions
Ben Perez has updated the pull request incrementally with one additional commit
since the last revision:
Added Authority Information Access OID
-
Changes:
- all:
> Removed `PrivateKeyUsagePeriod` from method javadoc and added several
> commonly used extensions
Ben Perez has updated the pull request incrementally with one additional commit
since the last revision:
Updated copyright
-
Changes:
- all: https://git.openjdk.org/jd
Removed `PrivateKeyUsagePeriod` from method javadoc and added several commonly
used extensions
-
Commit messages:
- removed PrivateKeyUsagePeriod from table and added several other commonly
used extensions
Changes: https://git.openjdk.org/jdk/pull/18565/files
Webrev:
On Fri, 15 Dec 2023 20:34:21 GMT, Ben Perez wrote:
> Refactored PKCS9Attribute to use a hash map instead of multiple arrays. The
> key for the hash map is an `ObjectIdentifier` and the values are a record
> `AttributeInfo` that stores the information previously contained in the
ut prior to this refactor the
> aforementioned OIDs were treated differently than unknown OIDs.
Ben Perez has updated the pull request incrementally with one additional commit
since the last revision:
Added comment to EncodeDecode test
-
Changes:
- all: http
ut prior to this refactor the
> aforementioned OIDs were treated differently than unknown OIDs.
Ben Perez has updated the pull request incrementally with one additional commit
since the last revision:
Added EncodeDecode.java test
-
Changes:
- all: https://git.openjdk.org/jd
ut prior to this refactor the
> aforementioned OIDs were treated differently than unknown OIDs.
Ben Perez has updated the pull request incrementally with one additional commit
since the last revision:
Refactor to simplify lambda expressions in AttributeInfo. Added new test
-
C
ut prior to this refactor the
> aforementioned OIDs were treated differently than unknown OIDs.
Ben Perez has updated the pull request incrementally with one additional commit
since the last revision:
Added comments for new functions
-
Changes:
- all: https://git.openjdk.or
On Thu, 11 Jan 2024 23:42:31 GMT, Ben Perez wrote:
>> Refactored PKCS9Attribute to use a hash map instead of multiple arrays. The
>> key for the hash map is an `ObjectIdentifier` and the values are a record
>> `AttributeInfo` that stores the information previously contained
ut prior to this refactor the
> aforementioned OIDs were treated differently than unknown OIDs.
Ben Perez has updated the pull request incrementally with one additional commit
since the last revision:
removed calls to Class.forName
-
Changes:
- all: https://git.openjdk.or
ut prior to this refactor the
> aforementioned OIDs were treated differently than unknown OIDs.
Ben Perez has updated the pull request incrementally with one additional commit
since the last revision:
Added encoding and value functionality to AttributeInfo to replace large
swi
On Wed, 10 Jan 2024 02:53:15 GMT, Valerie Peng wrote:
>> src/java.base/share/classes/sun/security/pkcs/PKCS9Attribute.java line 321:
>>
>>> 319:
>>> 320: this.oid = oid;
>>> 321: info = oidMap.get(oid);
>>
>> What if `info` is `null` (there is no entry for the specified OID)?
On Tue, 2 Jan 2024 21:54:19 GMT, Weijun Wang wrote:
>> Do you think we can remove `PKCS9Attributes.getAttributes()` entirely or
>> should we just modify it to not use `PKCS9_OIDS` anymore?
>
> I think we can remove both. There is no need to keep a useless method as long
> as it's not an
ut prior to this refactor the
> aforementioned OIDs were treated differently than unknown OIDs.
Ben Perez has updated the pull request incrementally with one additional commit
since the last revision:
Minor fixes to make the code more readable, inlined init(), removed
PKCS9Attributes.
On Thu, 21 Dec 2023 17:01:08 GMT, Weijun Wang wrote:
>> Refactored PKCS9Attribute to use a hash map instead of multiple arrays. The
>> key for the hash map is an `ObjectIdentifier` and the values are a record
>> `AttributeInfo` that stores the information previously contained in the
>> arrays
On Thu, 21 Dec 2023 16:27:43 GMT, Weijun Wang wrote:
>> Refactored PKCS9Attribute to use a hash map instead of multiple arrays. The
>> key for the hash map is an `ObjectIdentifier` and the values are a record
>> `AttributeInfo` that stores the information previously contained in the
>> arrays
Refactored PKCS9Attribute to use a hash map instead of multiple arrays. The key
for the hash map is an `ObjectIdentifier` and the values are a record
`AttributeInfo` that stores the information previously contained in the arrays
`PKCS9_VALUE_TAGS`, `VALUE_CLASSES`, and `SINGLE_VALUED`.
It
On Mon, 27 Nov 2023 21:45:23 GMT, Ben Perez wrote:
> Updated `X509CertSelector.java`, `SerialNumber.java`, and `SSLLogger` to use
> same debug printing format for X.509 serial numbers. The changes are:
> - `X509CertSelector` was `SN: 83be056904246b1a1756ac95991c74a` and now is
ial number" : 08:3B:E0:56:90:42:46:B1:A1:75:6A:C9:59:91:C7:4A`
Ben Perez has updated the pull request incrementally with one additional commit
since the last revision:
updated copyright
-
Changes:
- all: https://git.openjdk.org/jdk/pull/16834/files
- new: https://g
ial number" : 08:3B:E0:56:90:42:46:B1:A1:75:6A:C9:59:91:C7:4A`
Ben Perez has updated the pull request incrementally with one additional commit
since the last revision:
updated test certs to use new serial number format
-
Changes:
- all: https://git.openjdk.org/jdk/pull
ial number" : 08:3B:E0:56:90:42:46:B1:A1:75:6A:C9:59:91:C7:4A`
Ben Perez has updated the pull request incrementally with one additional commit
since the last revision:
added bug number to test
-
Changes:
- all: https://git.openjdk.org/jdk/pull/16834/files
- new: https://g
ial number" : 08:3B:E0:56:90:42:46:B1:A1:75:6A:C9:59:91:C7:4A`
Ben Perez has updated the pull request incrementally with one additional commit
since the last revision:
added format check to X509CertSelectorTest
-
Changes:
- all: https://git.openjdk.org/jdk/pull/16834/files
ial number" : 08:3B:E0:56:90:42:46:B1:A1:75:6A:C9:59:91:C7:4A`
Ben Perez has updated the pull request incrementally with one additional commit
since the last revision:
refactored serial number printing into a new toString method
-
Changes:
- all: https://git.openjdk.org/jdk
ial number" : 08:3B:E0:56:90:42:46:B1:A1:75:6A:C9:59:91:C7:4A`
Ben Perez has updated the pull request incrementally with one additional commit
since the last revision:
Standardized serial number print format
-
Changes:
- all: https://git.openjdk.org/jdk/pull/16834/files
ial number" : 08:3B:E0:56:90:42:46:B1:A1:75:6A:C9:59:91:C7:4A`
Ben Perez has updated the pull request incrementally with one additional commit
since the last revision:
Replaced formatting function with Debug.toString. Changed toString method in
SerialNumber to use camel case
---
> Updated `X509CertSelector.java` and `SerialNumber.java` to use same debug
> printing format for X.509 serial numbers. The format in `SSLLogger.java` is
> slightly different but now uses the `toString` method in `SerialNumber.java`
> for better readability.
Ben Perez has upda
> Updated `X509CertSelector.java` and `SerialNumber.java` to use same debug
> printing format for X.509 serial numbers. The format in `SSLLogger.java` is
> slightly different but now uses the `toString` method in `SerialNumber.java`
> for better readability.
Ben Perez has upda
Updated `X509CertSelector.java` and `SerialNumber.java` to use same debug
printing format for X.509 serial numbers. The format in `SSLLogger.java` is
slightly different but now uses the `toString` method in `SerialNumber.java`
for better readability.
-
Commit messages:
- Merge
> Modified `getService` method to prevent caching of `ServiceKey`, which was
> negatively impacting multithreaded performance
Ben Perez has updated the pull request incrementally with one additional commit
since the last revision:
changed cache to use threadlocal
-
C
On Fri, 20 Oct 2023 20:52:13 GMT, Ben Perez wrote:
> Updated the `constrains` method in `DNSName.java` to accept certificates with
> a leading period.
This pull request has now been integrated.
Changeset: bfaf5704
Author: Ben Perez
Committer: Sean Mullan
URL:
> Updated the `constrains` method in `DNSName.java` to accept certificates with
> a leading period.
Ben Perez has updated the pull request incrementally with one additional commit
since the last revision:
Updated documentation, minor fixes in test
-
Changes:
- all:
On Fri, 27 Oct 2023 17:05:36 GMT, Anthony Scarpino
wrote:
> I have a few questions:
>
> * The change listed in the bug is not the same as this PR. The bug removes
> the section and leaves only the new ServiceKey(). The condition statement
> left will always be false.
> * This seems like a
> Modified `getService` method to prevent caching of `ServiceKey`, which was
> negatively impacting multithreaded performance
Ben Perez has updated the pull request incrementally with one additional commit
since the last revision:
changed fix to align with bug report
-
C
Modified `getService` method to prevent caching of `ServiceKey`, which was
negatively impacting multithreaded performance
-
Commit messages:
- changed ServiceKey initialization to prevent caching
Changes: https://git.openjdk.org/jdk/pull/16403/files
Webrev:
Updated the `constrains` method in `DNSName.java` to accept certificates with a
leading period.
-
Commit messages:
- removed tabs
- replaced tabs with spaces
- Merge branch 'openjdk:master' into JDK-8311546
- Changed documentation for LeadingPeriod test
- Removed unnecessary
On Wed, 13 Sep 2023 18:08:35 GMT, Ben Perez wrote:
> Updated IllegalStateException exception requirements for `update`, `doFinal`,
> `wrap`, and `unwrap`
This pull request has now been integrated.
Changeset: 991ce84e
Author: Ben Perez
Committer: Valerie Peng
URL:
> Updated IllegalStateException exception requirements for `update`, `doFinal`,
> `wrap`, and `unwrap`
Ben Perez has updated the pull request incrementally with one additional commit
since the last revision:
Wording change for NullCipher doc, added @code tags
-
Changes:
> Updated IllegalStateException exception requirements for `update`, `doFinal`,
> `wrap`, and `unwrap`
Ben Perez has updated the pull request incrementally with one additional commit
since the last revision:
Updated docs for NullCipher to indicate it will not throw and
IllegalStateExc
> Updated IllegalStateException exception requirements for `update`, `doFinal`,
> `wrap`, and `unwrap`
Ben Perez has updated the pull request incrementally with one additional commit
since the last revision:
Updated doc for updateAAD, fixed copywrite
-
Changes:
- all:
On Mon, 25 Sep 2023 23:48:49 GMT, Valerie Peng wrote:
> * Given the current checkCipherState() impl does not check for states for
> NullCipher objects, do we want to also update the javax.crypto.NullCipher
> class javadoc to mention that IllegalStateException is not thrown by various
>
On Mon, 25 Sep 2023 23:48:49 GMT, Valerie Peng wrote:
> * Cipher.updateAAD(...) methods also calls checkCipherState(), so its javadoc
> should be updated as well?
The current documentation for Cipher.updateAAD(...) is:
"@throws IllegalStateException if this {@code Cipher} object is in a wrong
On Thu, 7 Sep 2023 18:12:28 GMT, Ben Perez wrote:
> Replaced "jks" with "pkcs12" in both the spec and fallback for
> `KeyStore.getDefaultType()`
This pull request has now been integrated.
Changeset: 53516aed
Author:Ben Perez
Committer: Sean Mullan
URL:
h
On Thu, 21 Sep 2023 19:08:16 GMT, Sean Mullan wrote:
>> Ben Perez has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixed copyright, refactored test to get rid of runTest
>
> test/jdk/java/security/KeySto
> Replaced "jks" with "pkcs12" in both the spec and fallback for
> `KeyStore.getDefaultType()`
Ben Perez has updated the pull request incrementally with one additional commit
since the last revision:
Changed @run arguments to completely override java.security
-
> Replaced "jks" with "pkcs12" in both the spec and fallback for
> `KeyStore.getDefaultType()`
Ben Perez has updated the pull request incrementally with one additional commit
since the last revision:
Fixed copyright, refactored test to get rid of runTest
-
On Wed, 20 Sep 2023 06:08:11 GMT, Valerie Peng wrote:
>> Ben Perez has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Added test to check that when keystore.type is null it defaults to pkcs12
>
> test/jdk
> Replaced "jks" with "pkcs12" in both the spec and fallback for
> `KeyStore.getDefaultType()`
Ben Perez has updated the pull request incrementally with one additional commit
since the last revision:
Changed test description, fixed indentation
On Wed, 20 Sep 2023 06:02:52 GMT, Valerie Peng wrote:
>> Ben Perez has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Added test to check that when keystore.type is null it defaults to pkcs12
>
> test/jdk
> Replaced "jks" with "pkcs12" in both the spec and fallback for
> `KeyStore.getDefaultType()`
Ben Perez has updated the pull request incrementally with one additional commit
since the last revision:
Added test to check that when keystore.type is
> Updated IllegalStateException exception requirements for `update`, `doFinal`,
> `wrap`, and `unwrap`
Ben Perez has updated the pull request incrementally with one additional commit
since the last revision:
Removed periods at end of IllegalStateException comment
-
C
Updated IllegalStateException exception requirements for `update`, `doFinal`,
`wrap`, and `unwrap`
-
Commit messages:
- Updated IllegalStateException requirement in update, doFinal, wrap, and
unwrap
Changes: https://git.openjdk.org/jdk/pull/15727/files
Webrev:
> Replaced "jks" with "pkcs12" in both the spec and fallback for
> `KeyStore.getDefaultType()`
Ben Perez has updated the pull request incrementally with one additional commit
since the last revision:
Changed KEYSTORE_TYPE spec to indicate pkcs12 default
-
Replaced "jks" with "pkcs12" in both the spec and fallback for
`KeyStore.getDefaultType()`
-
Commit messages:
- removed jks as fallback keystore and replaced with pkcs12
Changes: https://git.openjdk.org/jdk/pull/15625/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=15625=00
On Tue, 18 Jul 2023 19:59:34 GMT, Ben Perez wrote:
> Fixing the bug as stated would cause compatibility issues. E.g. the
> `addProvider` function always adds new providers at position 0 and therefore
> would always throw an error. Instead of changing how the function handles
>
unction spec.
Ben Perez has updated the pull request incrementally with one additional commit
since the last revision:
Added bugid to ChangeProviders
-
Changes:
- all: https://git.openjdk.org/jdk/pull/14925/files
- new: https://git.openjdk.org/jdk/pull/14925/files/1addeebf..1d64b
unction spec.
Ben Perez has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes brought in by
the merge/rebase. The pull request contains seven additional commits since the
last revision:
- Merge branch 'openjdk:mast
unction spec.
Ben Perez has updated the pull request incrementally with one additional commit
since the last revision:
Simplified test in ChangeProviders
-
Changes:
- all: https://git.openjdk.org/jdk/pull/14925/files
- new: https://git.openjdk.org/jdk/pull/14925/files/80b373
unction spec.
Ben Perez has updated the pull request incrementally with one additional commit
since the last revision:
Changed function spec wording, updated test
-
Changes:
- all: https://git.openjdk.org/jdk/pull/14925/files
- new: https://git.openjdk.org/jdk/pull/14925/fi
On Tue, 15 Aug 2023 19:42:44 GMT, Ben Perez wrote:
> Included `null` as an argument to `pkcs71.verify` in SignerOrder.java
This pull request has now been integrated.
Changeset: f143380d
Author: Ben Perez
Committer: Sean Mullan
URL:
https://git.openjdk.org/jdk/com
Included `null` as an argument to `pkcs71.verify` in SignerOrder.java
-
Commit messages:
- updated copyright
- Fixed SignerOrder test and removed from ProblemList
Changes: https://git.openjdk.org/jdk/pull/15296/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=15296=00
Issue:
On Fri, 11 Aug 2023 17:23:52 GMT, Ben Perez wrote:
> Removed PKCS7.verify() since no other code in JDK calls it.
This pull request has now been integrated.
Changeset: 595fdd36
Author: Ben Perez
Committer: Sean Mullan
URL:
https://git.openjdk.org/jdk/com
> Removed PKCS7.verify() since no other code in JDK calls it.
Ben Perez has updated the pull request incrementally with one additional commit
since the last revision:
Updated copyright
-
Changes:
- all: https://git.openjdk.org/jdk/pull/15251/files
- new: ht
> Fixing the bug as stated would cause compatibility issues. E.g. the
> `addProvider` function always adds new providers at position 0 and therefore
> would always throw an error. Instead of changing how the function handles
> indices, we instead have left an `@implNote`
Ben Perez
Removed PKCS7.verify() since no other code in JDK calls it.
-
Commit messages:
- removed verify method that takes no arguments
Changes: https://git.openjdk.org/jdk/pull/15251/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=15251=00
Issue:
> Fixing the bug as stated would cause compatibility issues. E.g. the
> `addProvider` function always adds new providers at position 0 and therefore
> would always throw an error. Instead of changing how the function handles
> indices, we instead have left an `@implNote`
Ben Perez
Fixing the bug as stated would cause compatibility issues. E.g. the
`addProvider` function always adds new providers at position 0 and therefore
would always throw an error. Instead of changing how the function handles
indices, we instead have left an `@implNote`
-
Commit
On Thu, 22 Jun 2023 18:45:14 GMT, Ben Perez wrote:
> Added single-argument `putTime` method to `DerOutputStream` that selects the
> correct encoding based on the `Date` value. Similarly, a `getTime` method was
> added to `DerValue` to automatically call the correct decoding funct
Furthermore, the `encode` method in
> `PKCS9Attribute` was changed to utilize the new `putTime` method.
Ben Perez has updated the pull request incrementally with one additional commit
since the last revision:
Moved UTC date range to constants
-
Changes:
- all: https://git.
Furthermore, the `encode` method in
> `PKCS9Attribute` was changed to utilize the new `putTime` method.
Ben Perez has updated the pull request incrementally with two additional
commits since the last revision:
- Fixed epoch literals to be in milliseconds
- Updated copyright in
Furthermore, the `encode` method in
> `PKCS9Attribute` was changed to utilize the new `putTime` method.
Ben Perez has updated the pull request incrementally with one additional commit
since the last revision:
Replaced depreciated ctor in putTime. Added getTime method to
Added single-argument `putTime` method to `DerOutputStream` that selects the
correct encoding based on the `Date` value. Similarly, a `getTime` method was
added to `DerValue` to automatically call the correct decoding function based
on the date type specified by the `tag`. Furthermore, the
On Mon, 12 Jun 2023 18:49:59 GMT, Ben Perez wrote:
> Changed `getEncoded` for both EC and RSA to return a copy of the internal key
> array to avoid mutability issues.
This pull request has now been integrated.
Changeset: 4eb4f20a
Author: Ben Perez
Committer: Sean Mullan
URL:
> Changed `getEncoded` for both EC and RSA to return a copy of the internal key
> array to avoid mutability issues.
Ben Perez has updated the pull request incrementally with one additional commit
since the last revision:
fixed copyrite date
-
Changes:
- all:
> Changed `getEncoded` for both EC and RSA to return a copy of the internal key
> array to avoid mutability issues.
Ben Perez has updated the pull request incrementally with one additional commit
since the last revision:
added copyrite to test
-
Changes:
- all:
> Changed `getEncoded` for both EC and RSA to return a copy of the internal key
> array to avoid mutability issues.
Ben Perez has updated the pull request incrementally with two additional
commits since the last revision:
- Removed unnecessary imports
- Removed unnecessary module i
On Wed, 14 Jun 2023 20:28:15 GMT, Sean Mullan wrote:
>> Ben Perez has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Changed array copy to be more compact
>
> src/jdk.crypto.mscapi/windows/classes/sun/s
> Changed `getEncoded` for both EC and RSA to return a copy of the internal key
> array to avoid mutability issues.
Ben Perez has updated the pull request incrementally with one additional commit
since the last revision:
Changed array copy to be more compact
-
Changes:
On Thu, 1 Jun 2023 21:17:11 GMT, Ben Perez wrote:
> Fixed `engineInitSign` in `DSA.java` and added `SecureRandomReset.java` to
> DSA tests
This pull request has now been integrated.
Changeset: bed9161c
Author: Ben Perez
Committer: Weijun Wang
URL:
https://git.openjdk.o
On Thu, 25 May 2023 21:17:40 GMT, Ben Perez wrote:
> Changed `namedParams` in XECParameters and EdDSAParameters to be `private
> final`
This pull request has now been integrated.
Changeset: 3c15ad8d
Author: Ben Perez
Committer: Sean Mullan
URL:
https://git.openjdk.org/jdk/
Changed `getEncoded` for both EC and RSA to return a copy of the internal key
array to avoid mutability issues.
-
Commit messages:
- updated copywrite
- Fixed getEncoded for CRSAPublicKey
- Fixed imports and formatting
- Modify getEncoded to return copy of encoding. Added test.
On Thu, 25 May 2023 21:17:40 GMT, Ben Perez wrote:
> Changed `namedParams` in XECParameters and EdDSAParameters to be `private
> final`
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.org/jdk/pull/14162
> Changed `namedParams` in XECParameters and EdDSAParameters to be `private
> final`
Ben Perez has updated the pull request incrementally with one additional commit
since the last revision:
Updated copywrite, added line breaks for readability
-
Changes:
- all:
> Fixed `engineInitSign` in `DSA.java` and added `SecureRandomReset.java` to
> DSA tests
Ben Perez has updated the pull request incrementally with one additional commit
since the last revision:
Formatting changes, updated copywrite
-
Changes:
- all: https://git.openj
On Wed, 7 Jun 2023 07:00:45 GMT, Bernd wrote:
>> Fixed `engineInitSign` in `DSA.java` and added `SecureRandomReset.java` to
>> DSA tests
>
> test/jdk/sun/security/provider/DSA/SecureRandomReset.java line 51:
>
>> 49:
>> 50: // Re-initialize deterministic RNG and sign
>> 51:
Changed `namedParams` in XECParameters and EdDSAParameters to be `private final`
-
Commit messages:
- Formatted to adhere to the blessed modifier order
- Fixed accidental newline
- Formatting changes
- Changed namedParams to be private final static
- Revert "Changed namedParams
On Tue, 6 Jun 2023 14:12:22 GMT, Weijun Wang wrote:
>> Fixed `engineInitSign` in `DSA.java` and added `SecureRandomReset.java` to
>> DSA tests
>
> test/jdk/sun/security/provider/DSA/SecureRandomReset.java line 28:
>
>> 26: * @bug 8308474
>> 27: * @summary Test that calling initSign resets
Fixed `engineInitSign` in `DSA.java` and added `SecureRandomReset.java` to DSA
tests
-
Commit messages:
- Updated copywrite
- Removed redundant call to getSigningRandom, fixed test formatting
- Added test for RNG rest
- Removed misplaced call to getSigningRandom
- Added RNG
91 matches
Mail list logo
