Re: RFR: 8318486: Rename JavaLangAccess.newString/getBytesUTF8NoRepl to FailFast

2023-10-19 Thread Chen Liang
On Thu, 19 Oct 2023 07:25:38 GMT, Alan Bateman wrote: > I assume it's "no replace", meaning it reports the error rather than use the > coder's replacement value. This revelation is too important; I might have to reevaluate my choices, for many contributors have assumed that `NoRepl` was

Re: RFR: 8318486: Rename JavaLangAccess.newString/getBytesUTF8NoRepl to FailFast

2023-10-19 Thread Chen Liang
On Thu, 19 Oct 2023 07:04:50 GMT, Chen Liang wrote: > Please review a patch that renames `JavaLangAccess::newStringUTF8NoRepl` and > `getBytesUTF8NoRepl` to `newStringUTF8FailFast` and `getBytesUTF8FailFast` to > accurately describe these APIs. This also renames other associated methods. > >

Re: RFR: 8318486: Rename JavaLangAccess.newString/getBytesUTF8NoRepl to FailFast

2023-10-19 Thread Alan Bateman
On Thu, 19 Oct 2023 07:04:50 GMT, Chen Liang wrote: > NoRepl means "no replication", which is not what these APIs are for. I assume it's "no replace", meaning it reports the error rather than use the coder's replacement value. I agree it could be renamed but I think look at CodingErrorAction

RFR: 8318486: Rename JavaLangAccess.newString/getBytesUTF8NoRepl to FailFast

2023-10-19 Thread Chen Liang
Please review a patch that renames `JavaLangAccess::newStringUTF8NoRepl` and `getBytesUTF8NoRepl` to `newStringUTF8FailFast` and `getBytesUTF8FailFast` to accurately describe these APIs. This also renames other associated methods. NoRepl means "no replication", which is not what these APIs are