On Fri, 3 May 2024 20:46:46 GMT, Martin Balao wrote:
>> src/java.base/share/conf/security/java.security line 70:
>>
>>> 68: # an error is thrown and explicit profile selection is required. In
>>> order
>>> 69: # to override properties defined in this file, the include statement
>>> may be
>>>
On Fri, 3 May 2024 20:02:29 GMT, Weijun Wang wrote:
>> Francisco Ferrari Bihurriet has updated the pull request incrementally with
>> one additional commit since the last revision:
>>
>> Profiles documentation adjustments.
>>
>> Co-authored-by: Francisco Ferrari
>> Co-authored-by:
> The implementation of this proposal is based on the requirements,
> specification and design choices described in the [JDK-8319332] ticket and
> its respective CSR [JDK-8319333]. What follows are implementation notes
> organized per functional component, with the purpose of assisting to
On Fri, 3 May 2024 19:37:02 GMT, Sean Mullan wrote:
>> Francisco Ferrari Bihurriet has updated the pull request incrementally with
>> one additional commit since the last revision:
>>
>> Profiles documentation adjustments.
>>
>> Co-authored-by: Francisco Ferrari
>> Co-authored-by:
On Fri, 3 May 2024 19:32:56 GMT, Sean Mullan wrote:
>> Francisco Ferrari Bihurriet has updated the pull request incrementally with
>> one additional commit since the last revision:
>>
>> Profiles documentation adjustments.
>>
>> Co-authored-by: Francisco Ferrari
>> Co-authored-by:
On Thu, 2 May 2024 21:24:19 GMT, Francisco Ferrari Bihurriet
wrote:
>> The implementation of this proposal is based on the requirements,
>> specification and design choices described in the [JDK-8319332] ticket and
>> its respective CSR [JDK-8319333]. What follows are implementation notes
>>
On Thu, 2 May 2024 21:24:19 GMT, Francisco Ferrari Bihurriet
wrote:
>> The implementation of this proposal is based on the requirements,
>> specification and design choices described in the [JDK-8319332] ticket and
>> its respective CSR [JDK-8319333]. What follows are implementation notes
>>
On Thu, 2 May 2024 21:07:03 GMT, Weijun Wang wrote:
> The revised text is much clearer. For the last sentence, I would suggest
> rephrasing "In order to prevent profile properties from being overridden" to
> "In order to override properties defined in the main file". Isn't that your
> real
> The implementation of this proposal is based on the requirements,
> specification and design choices described in the [JDK-8319332] ticket and
> its respective CSR [JDK-8319333]. What follows are implementation notes
> organized per functional component, with the purpose of assisting to
On Thu, 2 May 2024 20:34:22 GMT, Francisco Ferrari Bihurriet
wrote:
>> The implementation of this proposal is based on the requirements,
>> specification and design choices described in the [JDK-8319332] ticket and
>> its respective CSR [JDK-8319333]. What follows are implementation notes
>>
On Thu, 2 May 2024 19:07:50 GMT, Weijun Wang wrote:
>> src/java.base/share/conf/security/java.security line 69:
>>
>>> 67: # statement will override any matching property defined in a profile.
>>> In order
>>> 68: # to avoid this behavior, the include statement may be placed at the
>>> end of
> The implementation of this proposal is based on the requirements,
> specification and design choices described in the [JDK-8319332] ticket and
> its respective CSR [JDK-8319333]. What follows are implementation notes
> organized per functional component, with the purpose of assisting to
On Thu, 2 May 2024 19:09:07 GMT, Weijun Wang wrote:
>> Francisco Ferrari Bihurriet has updated the pull request incrementally with
>> one additional commit since the last revision:
>>
>> Profiles documentation adjustments.
>>
>> Co-authored-by: Francisco Ferrari
>> Co-authored-by:
On Thu, 2 May 2024 19:06:00 GMT, Weijun Wang wrote:
>> Francisco Ferrari Bihurriet has updated the pull request incrementally with
>> one additional commit since the last revision:
>>
>> Profiles documentation adjustments.
>>
>> Co-authored-by: Francisco Ferrari
>> Co-authored-by:
On Thu, 2 May 2024 16:45:09 GMT, Francisco Ferrari Bihurriet
wrote:
>> The implementation of this proposal is based on the requirements,
>> specification and design choices described in the [JDK-8319332] ticket and
>> its respective CSR [JDK-8319333]. What follows are implementation notes
>>
On Thu, 2 May 2024 15:57:36 GMT, Weijun Wang wrote:
> Another comment: now that the backward compatibility code is added, is it
> still necessary to update the `DynStatic.java` test?
@wangweij: it's no longer strictly necessary. However, we decided to leave it
that way in order to lead by
On Thu, 2 May 2024 14:59:54 GMT, Weijun Wang wrote:
> In the new `java.security` text, you have "the file profile.security must
> exist". This is not necessary, right? I think what you meant to say is that
> "if the system property is not defined, then it will be expanded to an empty
> string
> The implementation of this proposal is based on the requirements,
> specification and design choices described in the [JDK-8319332] ticket and
> its respective CSR [JDK-8319333]. What follows are implementation notes
> organized per functional component, with the purpose of assisting to
On Thu, 2 May 2024 14:07:13 GMT, Francisco Ferrari Bihurriet
wrote:
>> The implementation of this proposal is based on the requirements,
>> specification and design choices described in the [JDK-8319332] ticket and
>> its respective CSR [JDK-8319333]. What follows are implementation notes
>>
On Thu, 2 May 2024 14:07:13 GMT, Francisco Ferrari Bihurriet
wrote:
>> The implementation of this proposal is based on the requirements,
>> specification and design choices described in the [JDK-8319332] ticket and
>> its respective CSR [JDK-8319333]. What follows are implementation notes
>>
On Thu, 2 May 2024 14:07:13 GMT, Francisco Ferrari Bihurriet
wrote:
>> The implementation of this proposal is based on the requirements,
>> specification and design choices described in the [JDK-8319332] ticket and
>> its respective CSR [JDK-8319333]. What follows are implementation notes
>>
> The implementation of this proposal is based on the requirements,
> specification and design choices described in the [JDK-8319332] ticket and
> its respective CSR [JDK-8319333]. What follows are implementation notes
> organized per functional component, with the purpose of assisting to
On Tue, 23 Apr 2024 17:19:55 GMT, Francisco Ferrari Bihurriet
wrote:
>> The implementation of this proposal is based on the requirements,
>> specification and design choices described in the [JDK-8319332] ticket and
>> its respective CSR [JDK-8319333]. What follows are implementation notes
On Fri, 19 Apr 2024 13:02:03 GMT, Francisco Ferrari Bihurriet
wrote:
>>> In the compatibility risk description of the CSR:
>>>
>>> > In line with the efforts to check invalid URLs (see
>>> > [JDK-8294241](https://bugs.openjdk.org/browse/JDK-8294241): Deprecate URL
>>> > public constructors),
On Tue, 23 Apr 2024 17:19:55 GMT, Francisco Ferrari Bihurriet
wrote:
>> The implementation of this proposal is based on the requirements,
>> specification and design choices described in the [JDK-8319332] ticket and
>> its respective CSR [JDK-8319333]. What follows are implementation notes
On Wed, 1 May 2024 18:34:41 GMT, Weijun Wang wrote:
> I'm seeing
>
> ```
> java.lang.reflect.InvocationTargetException
> at
> java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:118)
> at
On Tue, 23 Apr 2024 17:19:55 GMT, Francisco Ferrari Bihurriet
wrote:
>> The implementation of this proposal is based on the requirements,
>> specification and design choices described in the [JDK-8319332] ticket and
>> its respective CSR [JDK-8319333]. What follows are implementation notes
On Wed, 1 May 2024 15:12:10 GMT, Weijun Wang wrote:
> Just one more question on the system property expansion when it's not
> defined. In your example:
>
> > include ${java.home}/conf/security/profile${SecurityProfile}.security
>
> How bad will it be if we require user to set
On Tue, 23 Apr 2024 17:19:55 GMT, Francisco Ferrari Bihurriet
wrote:
>> The implementation of this proposal is based on the requirements,
>> specification and design choices described in the [JDK-8319332] ticket and
>> its respective CSR [JDK-8319333]. What follows are implementation notes
On Tue, 23 Apr 2024 17:19:55 GMT, Francisco Ferrari Bihurriet
wrote:
>> The implementation of this proposal is based on the requirements,
>> specification and design choices described in the [JDK-8319332] ticket and
>> its respective CSR [JDK-8319333]. What follows are implementation notes
> The implementation of this proposal is based on the requirements,
> specification and design choices described in the [JDK-8319332] ticket and
> its respective CSR [JDK-8319333]. What follows are implementation notes
> organized per functional component, with the purpose of assisting to
On Mon, 22 Apr 2024 20:42:44 GMT, Francisco Ferrari Bihurriet
wrote:
>> The implementation of this proposal is based on the requirements,
>> specification and design choices described in the [JDK-8319332] ticket and
>> its respective CSR [JDK-8319333]. What follows are implementation notes
On Fri, 19 Apr 2024 19:40:53 GMT, Weijun Wang wrote:
>> Francisco Ferrari Bihurriet has updated the pull request with a new target
>> base due to a merge or a rebase. The pull request now contains 11 commits:
>>
>> - Merge 'openjdk/master' into JDK-8319332
>> - Merge 'openjdk/master' into
> The implementation of this proposal is based on the requirements,
> specification and design choices described in the [JDK-8319332] ticket and
> its respective CSR [JDK-8319333]. What follows are implementation notes
> organized per functional component, with the purpose of assisting to
On Fri, 19 Apr 2024 19:40:53 GMT, Weijun Wang wrote:
> Yes, I can see its effect on the relative include. Maybe use the deprecated
> URL constructor as a fallback when the other mechanisms fail?
Yes, that's what we have in mind. We will try to handle it as a local path and
when not possible,
On Wed, 6 Mar 2024 12:19:14 GMT, Francisco Ferrari Bihurriet
wrote:
>> The implementation of this proposal is based on the requirements,
>> specification and design choices described in the [JDK-8319332] ticket and
>> its respective CSR [JDK-8319333]. What follows are implementation notes
>>
On Fri, 19 Apr 2024 13:19:44 GMT, Weijun Wang wrote:
> > > > Is it worth breaking such invalid URLs?
>
> I'm just not sure about the compatibility impact. The example
> "file:///C:\some\path\extra.properties" you gave looks quite innocent and
> could be generated by a casual script.
>
> Can
On Fri, 19 Apr 2024 13:31:42 GMT, Francisco Ferrari Bihurriet
wrote:
>> Oh, I meant the final `else`. What does it mean if a file is neither
>> "regular" nor "directory"? Also I don't quite understand why one uses
>> `toRealPath` and one uses `toAbsolutePath`. Is this related to resolving a
On Fri, 19 Apr 2024 13:02:27 GMT, Weijun Wang wrote:
>> Hi @wangweij, to complement @martinuy's answer, the following commands can
>> trigger this error message in the different described contexts:
>>
>> java -Djava.security.properties=file:///etc
>> -XshowSettings:security:properties
On Fri, 19 Apr 2024 13:02:03 GMT, Francisco Ferrari Bihurriet
wrote:
> > > Is it worth breaking such invalid URLs?
I'm just not sure about the compatibility impact. The example
"file:///C:\some\path\extra.properties" you gave looks quite innocent and could
be generated by a casual script.
On Fri, 19 Apr 2024 08:16:34 GMT, Martin Balao wrote:
>> In the compatibility risk description of the CSR:
>>> In line with the efforts to check invalid URLs (see
>>> [JDK-8294241](https://bugs.openjdk.org/browse/JDK-8294241): Deprecate URL
>>> public constructors), "java.security.properties"
On Fri, 19 Apr 2024 12:58:32 GMT, Francisco Ferrari Bihurriet
wrote:
>> src/java.base/share/classes/java/security/Security.java line 256:
>>
>>> 254: } else if (Files.isDirectory(path)) {
>>> 255: throw new IOException("Is a directory");
>>> 256: } else
On Wed, 17 Apr 2024 14:30:02 GMT, Weijun Wang wrote:
>> Francisco Ferrari Bihurriet has updated the pull request with a new target
>> base due to a merge or a rebase. The pull request now contains 11 commits:
>>
>> - Merge 'openjdk/master' into JDK-8319332
>> - Merge 'openjdk/master' into
On Wed, 17 Apr 2024 14:55:05 GMT, Weijun Wang wrote:
> In the compatibility risk description of the CSR:
>
> > In line with the efforts to check invalid URLs (see
> > [JDK-8294241](https://bugs.openjdk.org/browse/JDK-8294241): Deprecate URL
> > public constructors), "java.security.properties"
On Wed, 17 Apr 2024 14:30:02 GMT, Weijun Wang wrote:
>> Francisco Ferrari Bihurriet has updated the pull request with a new target
>> base due to a merge or a rebase. The pull request now contains 11 commits:
>>
>> - Merge 'openjdk/master' into JDK-8319332
>> - Merge 'openjdk/master' into
On Wed, 17 Apr 2024 14:28:58 GMT, Weijun Wang wrote:
> "If a system property does not have a value, it expands to the empty string."
> What's the benefit? It will be nice if you can include an example on the CSR.
Expanding to the empty string has the advantage that we can parameterize part
of
On Wed, 6 Mar 2024 12:19:14 GMT, Francisco Ferrari Bihurriet
wrote:
>> The implementation of this proposal is based on the requirements,
>> specification and design choices described in the [JDK-8319332] ticket and
>> its respective CSR [JDK-8319333]. What follows are implementation notes
>>
On Wed, 6 Mar 2024 12:19:14 GMT, Francisco Ferrari Bihurriet
wrote:
>> The implementation of this proposal is based on the requirements,
>> specification and design choices described in the [JDK-8319332] ticket and
>> its respective CSR [JDK-8319333]. What follows are implementation notes
>>
On Wed, 6 Mar 2024 12:19:14 GMT, Francisco Ferrari Bihurriet
wrote:
>> The implementation of this proposal is based on the requirements,
>> specification and design choices described in the [JDK-8319332] ticket and
>> its respective CSR [JDK-8319333]. What follows are implementation notes
>>
> The implementation of this proposal is based on the requirements,
> specification and design choices described in the [JDK-8319332] ticket and
> its respective CSR [JDK-8319333]. What follows are implementation notes
> organized per functional component, with the purpose of assisting to
> The implementation of this proposal is based on the requirements,
> specification and design choices described in the [JDK-8319332] ticket and
> its respective CSR [JDK-8319333]. What follows are implementation notes
> organized per functional component, with the purpose of assisting to
On Mon, 8 Jan 2024 18:59:54 GMT, Francisco Ferrari Bihurriet
wrote:
>> The implementation of this proposal is based on the requirements,
>> specification and design choices described in the [JDK-8319332] ticket and
>> its respective CSR [JDK-8319333]. What follows are implementation notes
>>
On Mon, 8 Jan 2024 18:59:54 GMT, Francisco Ferrari Bihurriet
wrote:
>> The implementation of this proposal is based on the requirements,
>> specification and design choices described in the [JDK-8319332] ticket and
>> its respective CSR [JDK-8319333]. What follows are implementation notes
>>
> The implementation of this proposal is based on the requirements,
> specification and design choices described in the [JDK-8319332] ticket and
> its respective CSR [JDK-8319333]. What follows are implementation notes
> organized per functional component, with the purpose of assisting to
> The implementation of this proposal is based on the requirements,
> specification and design choices described in the [JDK-8319332] ticket and
> its respective CSR [JDK-8319333]. What follows are implementation notes
> organized per functional component, with the purpose of assisting to
On Fri, 10 Nov 2023 16:46:15 GMT, Andrew John Hughes wrote:
>> My major concern is that this does not look like a properties file anymore,
>> that the same key have multiple values and you use an undocumented (?)
>> format "key value". That said, this is a clever hack and I wonder why we
>>
> The implementation of this proposal is based on the requirements,
> specification and design choices described in the [JDK-8319332] ticket and
> its respective CSR [JDK-8319333]. What follows are implementation notes
> organized per functional component, with the purpose of assisting to
On Fri, 10 Nov 2023 17:33:33 GMT, Weijun Wang wrote:
> > By "the same key has multiple values", I assume you mean the key "import"?
> > The implementation overrides `put` and swallows these `include` lines so
> > they are never actually added as keys and values.
>
> Yes, I understand this,
On Fri, 10 Nov 2023 16:46:15 GMT, Andrew John Hughes wrote:
> By "the same key has multiple values", I assume you mean the key "import"?
> The implementation overrides `put` and swallows these `include` lines so they
> are never actually added as keys and values.
Yes, I understand this, and
On Thu, 9 Nov 2023 21:36:44 GMT, Weijun Wang wrote:
> My major concern is that this does not look like a properties file anymore,
> that the same key have multiple values and you use an undocumented (?) format
> "key value". That said, this is a clever hack and I wonder why we hadn't used
>
On Fri, 3 Nov 2023 22:18:22 GMT, Francisco Ferrari Bihurriet
wrote:
>> The implementation of this proposal is based on the requirements,
>> specification and design choices described in the [JDK-8319332] ticket and
>> its respective CSR [JDK-8319333]. What follows are implementation notes
>>
On Thu, 9 Nov 2023 21:36:44 GMT, Weijun Wang wrote:
>> Francisco Ferrari Bihurriet has updated the pull request incrementally with
>> one additional commit since the last revision:
>>
>> 8319332: use Path::of(URI) to deal with file URLs
>>
>> Instead of the previously introduced
On Fri, 3 Nov 2023 22:18:22 GMT, Francisco Ferrari Bihurriet
wrote:
>> The implementation of this proposal is based on the requirements,
>> specification and design choices described in the [JDK-8319332] ticket and
>> its respective CSR [JDK-8319333]. What follows are implementation notes
>>
On Thu, 9 Nov 2023 20:46:31 GMT, Kevin Driver wrote:
>> Francisco Ferrari Bihurriet has updated the pull request incrementally with
>> one additional commit since the last revision:
>>
>> 8319332: use Path::of(URI) to deal with file URLs
>>
>> Instead of the previously introduced
On Fri, 3 Nov 2023 22:18:22 GMT, Francisco Ferrari Bihurriet
wrote:
>> The implementation of this proposal is based on the requirements,
>> specification and design choices described in the [JDK-8319332] ticket and
>> its respective CSR [JDK-8319333]. What follows are implementation notes
>>
On Fri, 3 Nov 2023 22:18:22 GMT, Francisco Ferrari Bihurriet
wrote:
>> The implementation of this proposal is based on the requirements,
>> specification and design choices described in the [JDK-8319332] ticket and
>> its respective CSR [JDK-8319333]. What follows are implementation notes
>>
> The implementation of this proposal is based on the requirements,
> specification and design choices described in the [JDK-8319332] ticket and
> its respective CSR [JDK-8319333]. What follows are implementation notes
> organized per functional component, with the purpose of assisting to
On Fri, 3 Nov 2023 05:42:56 GMT, Alan Bateman wrote:
>> Checking for _file_ in the URL scheme is not conclusive evidence that there
>> is a local file path behind. I'll give a couple of examples. In Unix/Linux
>> platforms, an URL of the form `file://example.com/path/to/some/file.txt` is
>>
On Thu, 2 Nov 2023 22:20:02 GMT, Martin Balao wrote:
>> src/java.base/share/classes/java/security/Security.java line 243:
>>
>>> 241: if (connection instanceof FileURLConnection
>>> fileConnection) {
>>> 242: // A local file URL can be interpreted as a Path
>>> 243:
On Thu, 2 Nov 2023 20:07:28 GMT, Alan Bateman wrote:
>> The implementation of this proposal is based on the requirements,
>> specification and design choices described in the [JDK-8319332] ticket and
>> its respective CSR [JDK-8319333]. What follows are implementation notes
>> organized per
On Thu, 2 Nov 2023 19:07:48 GMT, Francisco Ferrari Bihurriet
wrote:
> The implementation of this proposal is based on the requirements,
> specification and design choices described in the [JDK-8319332] ticket and
> its respective CSR [JDK-8319333]. What follows are implementation notes
>
The implementation of this proposal is based on the requirements, specification
and design choices described in the [JDK-8319332] ticket and its respective CSR
[JDK-8319333]. What follows are implementation notes organized per functional
component, with the purpose of assisting to navigate the
72 matches
Mail list logo
