[james-project] 15/21: [Refactoring] StoreCommandParser should not use final variables

[rcordier]

This is an automated email from the ASF dual-hosted git repository.

rcordier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/james-project.git

commit 1b160ba3d77bf0c465eaaf2a5fc31d042d1cdf07
Author: Benoit Tellier <btell...@linagora.com>
AuthorDate: Thu Dec 19 14:37:48 2019 +0700

    [Refactoring] StoreCommandParser should not use final variables
---
 .../org/apache/james/imap/decode/parser/StoreCommandParser.java     | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git 
a/protocols/imap/src/main/java/org/apache/james/imap/decode/parser/StoreCommandParser.java
 
b/protocols/imap/src/main/java/org/apache/james/imap/decode/parser/StoreCommandParser.java
index c8fce8e..a00df86 100644
--- 
a/protocols/imap/src/main/java/org/apache/james/imap/decode/parser/StoreCommandParser.java
+++ 
b/protocols/imap/src/main/java/org/apache/james/imap/decode/parser/StoreCommandParser.java
@@ -46,7 +46,7 @@ public class StoreCommandParser extends 
AbstractUidCommandParser {
 
     @Override
     protected ImapMessage decode(ImapRequestLineReader request, Tag tag, 
boolean useUids, ImapSession session) throws DecodingException {
-        final IdRange[] idSet = request.parseIdRange(session);
+        IdRange[] idSet = request.parseIdRange(session);
         long unchangedSince = -1;
         char next = request.nextWordChar();
         if (next == '(') {
@@ -63,7 +63,7 @@ public class StoreCommandParser extends 
AbstractUidCommandParser {
         MessageManager.FlagsUpdateMode flagsUpdateMode = 
parseFlagsUpdateMode(request, next);
         String directive = request.consumeWord(new 
ImapRequestLineReader.NoopCharValidator());
         boolean silent = parseSilent(directive);
-        final Flags flags = parseFlags(request);
+        Flags flags = parseFlags(request);
 
         request.eol();
         return new StoreRequest(idSet, silent, flags, useUids, tag, 
flagsUpdateMode, unchangedSince);
@@ -72,7 +72,7 @@ public class StoreCommandParser extends 
AbstractUidCommandParser {
     private Flags parseFlags(ImapRequestLineReader request) throws 
DecodingException {
         // Handle all kind of "store-att-flags"
         // See IMAP-281
-        final Flags flags = new Flags();
+        Flags flags = new Flags();
         if (request.nextWordChar() == '(') {
             flags.add(request.flagList());
         } else {


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org