Re: RFR(S): 8071999: SA's buildreplayjars fail with exception

2015-02-09 Thread Roland Westrelin
So it isn't default methods that are the problem but bridge methods? Yes, it looks like it. Roland.

Re: [9] RFR (M) 8054888: Runtime: Add Diagnostic Command that prints the class hierarchy

2015-02-09 Thread Staffan Larsen
On 6 feb 2015, at 21:15, Chris Plummer chris.plum...@oracle.com wrote: I was also thinking it might be a good idea to indicate what the hex value is, although still have figured out the best way of doing this. Maybe just a simple comment before the output. Keep in mind that eventually

Re: [9] RFR (M) 8054888: Runtime: Add Diagnostic Command that prints the class hierarchy

2015-02-09 Thread Staffan Larsen
On 6 feb 2015, at 22:21, Karen Kinnear karen.kinn...@oracle.com wrote: Chris, So I was curious - I was thinking you would printing the hex address of the j.l.ClassLoader class rather than the cld so that if folks were to look at a heap dump later it might be meaningful to them. Is it

Re: [9] RFR (M) 8054888: Runtime: Add Diagnostic Command that prints the class hierarchy

2015-02-09 Thread Chris Plummer
I've attached updated output: I now use the Klass* of the ClassLoader instead of the CLD*, and this is documented in the help output. The Klass* of the ClassLoader now immediately follows the class name, and is also included when printing

Re: [9] RFR (M) 8054888: Runtime: Add Diagnostic Command that prints the class hierarchy

2015-02-09 Thread Chris Plummer
[Once again the attachment went out but the main body was stripped. Not too sure what's going on, but here it is again. Sorry if you are getting this twice.] I've attached updated output: • I now use the Klass* of the ClassLoader instead of the CLD*, and this is documented in the help

Re: [9] RFR (M) 8054888: Runtime: Add Diagnostic Command that prints the class hierarchy

2015-02-09 Thread Chris Plummer
Arrg. Just noticed these emails after I sent my webrev. They got snagged by my openjdk filter for later viewing. I had been expecting all replies to CC me and be in my inbox. serviceability-dev@openjdk.java.net also got removed, so they've been re-added. Anyway, good point on both

Re: RFR 8067447: Factor out the shared implementation of the VM flags manipulation code

2015-02-09 Thread Staffan Larsen
On 9 feb 2015, at 00:13, David Holmes david.hol...@oracle.com wrote: Hi Jaroslav, On 6/02/2015 9:54 PM, Jaroslav Bachorik wrote: On 6.2.2015 06:16, David Holmes wrote: On 6/02/2015 1:17 AM, Jaroslav Bachorik wrote: On 5.2.2015 14:55, Staffan Larsen wrote: Jaroslav, This looks good,

Request for approval: Backport of 8069030

2015-02-09 Thread Dean Long
I would like to backport 8069030 to 8u60: https://bugs.openjdk.java.net/browse/JDK-8069030 http://hg.openjdk.java.net/jdk9/hs-comp/hotspot/rev/5960a65b0f54 The patch applied cleanly. dl

Re: RFR 8067447: Factor out the shared implementation of the VM flags manipulation code

2015-02-09 Thread Jaroslav Bachorik
On 9.2.2015 00:13, David Holmes wrote: Hi Jaroslav, On 6/02/2015 9:54 PM, Jaroslav Bachorik wrote: On 6.2.2015 06:16, David Holmes wrote: On 6/02/2015 1:17 AM, Jaroslav Bachorik wrote: On 5.2.2015 14:55, Staffan Larsen wrote: Jaroslav, This looks good, just a few small comments:

Re: RFR 8067447: Factor out the shared implementation of the VM flags manipulation code

2015-02-09 Thread David Holmes
Hi Jaroslav, // a writable flag Still a few changes needed in writeable.hpp and writeable.cpp But no need for a new webrev. Thanks, David On 9/02/2015 8:48 PM, Jaroslav Bachorik wrote: On 9.2.2015 00:13, David Holmes wrote: Hi Jaroslav, On 6/02/2015 9:54 PM, Jaroslav Bachorik wrote: On