RFR: JDK-8072913: [REDO] GCCause should distinguish jcmd GC.run from System.gc()

Hi all, I've committed JDK-8068589 to add new GCCause - Diagnostic Command. However, it has been backouted because test is failed [1] and it is not considered about concurrent GC: -XX:+ExplicitGCInvokesConcurrent [2]. I've created patch for this enhancement. Could you review it?

8072856: Eliminate ProcessTools.getProcessId dependency on sun.management.VMManagement

Hi, Could I please have a review of this small fix. bug: https://bugs.openjdk.java.net/browse/JDK-8072856 webrev: http://cr.openjdk.java.net/~ykantser/8072856/webrev.00/ Thanks, Katja

Re: 8072856: Eliminate ProcessTools.getProcessId dependency on sun.management.VMManagement

Looks good! -JB- On 11.2.2015 17:42, Yekaterina Kantserova wrote: Hi, Could I please have a review of this small fix. bug: https://bugs.openjdk.java.net/browse/JDK-8072856 webrev: http://cr.openjdk.java.net/~ykantser/8072856/webrev.00/ Thanks, Katja

Re: 8072856: Eliminate ProcessTools.getProcessId dependency on sun.management.VMManagement

+1 This is temporary. When the Process API is available, we can convert to use the new public API. Mandy On 2/11/2015 8:57 AM, Daniel Fuchs wrote: Looks good to me too. JEP 102 Process Updates will provide an easier way to get the current process PID but we don't have that yet :-) best

Re: [9] RFR (M) 8054888: Runtime: Add Diagnostic Command that prints the class hierarchy

On 2/11/15 2:12 AM, Mikael Auno wrote: On 2015-02-11 04:13, Chris Plummer wrote: In general I think this looks very good. Simple and well-commented code to follow. I am missing a test, though. Please look at the hotspot/test/serviceability/dcmd set of tests. Added. Your test is based on

Re: 8072856: Eliminate ProcessTools.getProcessId dependency on sun.management.VMManagement

Looks good to me too. JEP 102 Process Updates will provide an easier way to get the current process PID but we don't have that yet :-) best regards, -- daniel On 11/02/15 17:42, Yekaterina Kantserova wrote: Hi, Could I please have a review of this small fix. bug:

RFR 8072932: Test fails with java.security.AccessControlException: access denied (java.security.SecurityPermission getDomainCombiner)

Please, review the following simple change. Issue : https://bugs.openjdk.java.net/browse/JDK-8072932 Webrev: http://cr.openjdk.java.net/~jbachorik/8072932/webrev.00 This patch is about replacing the j.s.AccessControlContext.getDomainCombiner() with the package-private version

Re: Request for approval: Backport of 8069030

Ping. Is there a different alias I should sent this to? dl On 2/9/2015 1:16 PM, Dean Long wrote: I would like to backport 8069030 to 8u60: https://bugs.openjdk.java.net/browse/JDK-8069030 http://hg.openjdk.java.net/jdk9/hs-comp/hotspot/rev/5960a65b0f54 The patch applied cleanly. dl

Re: [9] RFR (M) 8054888: Runtime: Add Diagnostic Command that prints the class hierarchy

Yes, so I reverted back to the CLD*. Seems to be the only thing that is unique per ClassLoader instance and does not move. Chris On 2/11/15 2:11 PM, Karen Kinnear wrote: Chris, Just saw this. I was thinking the instance

Re: Request for approval: Backport of 8069030

I have no issue with this backport. David On 12/02/2015 7:00 AM, Dean Long wrote: Ping. Is there a different alias I should sent this to? dl On 2/9/2015 1:16 PM, Dean Long wrote: I would like to backport 8069030 to 8u60: https://bugs.openjdk.java.net/browse/JDK-8069030

Re: [9] RFR (M) 8054888: Runtime: Add Diagnostic Command that prints the class hierarchy

Chris, Just saw this. I was thinking the instance in the heap since you might have multiple instances of a single subclass. Good point that it might change and so the correlation would be gone. thanks, Karen On Feb 6, 2015, at 5:09 PM, Chris Plummer wrote: Hi Karen, Can you clarify what

Re: RFR(M): JDK-8072395: LingeredAppTest.java and JMapHeapConfigTest.java fail due to LingeredApp ERROR: java.io.IOException: Lock is too old. Aborting

Hi Dmitry - like it, and particularly like getting shouldSAAttach() in both jdk and hotspot. Yes you're very efficient in just reading that one byte from those one-byte files! 8-) Sorry one more thing... JMapHeapConfigTest.java throws an exception when it doesn't think it will have

gdb and OpenJDK

Hey folks, I think I've mentioned to some of the people on this list that we (and by we, I mean Sasha Smundak) have been working on interoperability between gdb and Java. Basically, what we have now allows us to get a backtrace in gdb that includes Java frames with parameter values (no local

Re: Request for approval: Backport of 8069030

Thanks David. dl On 2/11/2015 3:33 PM, David Holmes wrote: I have no issue with this backport. David On 12/02/2015 7:00 AM, Dean Long wrote: Ping. Is there a different alias I should sent this to? dl On 2/9/2015 1:16 PM, Dean Long wrote: I would like to backport 8069030 to 8u60:

Re: [9] RFR (M) 8054888: Runtime: Add Diagnostic Command that prints the class hierarchy

So I am in agreement on the CLD* - sorry for the earlier suggestion. thanks, Karen On Feb 11, 2015, at 3:04 AM, Staffan Larsen wrote: This version looks good to me! Small comments inline. On 11 feb 2015, at 04:13, Chris Plummer chris.plum...@oracle.com wrote: Hi Staffan, Thanks for

Re: [9] RFR (M) 8054888: Runtime: Add Diagnostic Command that prints the class hierarchy

On 2015-02-11 04:13, Chris Plummer wrote: In general I think this looks very good. Simple and well-commented code to follow. I am missing a test, though. Please look at the hotspot/test/serviceability/dcmd set of tests. Added. Your test is based on DcmdUtil.java which was removed last week

RFR(M): JDK-8072395: LingeredAppTest.java and JMapHeapConfigTest.java fail due to LingeredApp ERROR: java.io.IOException: Lock is too old. Aborting

Hi Everybody, Please review the changes: http://cr.openjdk.java.net/~dsamersoff/JDK-8072395/webrev.04/ 1. Removed lock age test, because LingeredApp can run more than one hour of machine time. 2. Added code to check for common environment pitfalls and produce meaningful diagnostic 3.

Re: [9] RFR (M) 8054888: Runtime: Add Diagnostic Command that prints the class hierarchy

This version looks good to me! Small comments inline. On 11 feb 2015, at 04:13, Chris Plummer chris.plum...@oracle.com wrote: Hi Staffan, Thanks for your feedback. A new incremental webrev can be found at: http://cr.openjdk.java.net/~cjplummer/8054888/webrev.01-02/ Most changes are

Re: [ping] Re: RFR 8069286: Unexpected count of notification in LowMemoryTest

On 10.2.2015 18:09, Mandy Chung wrote: On 2/10/15 1:22 AM, Jaroslav Bachorik wrote: On 2.2.2015 16:59, Jaroslav Bachorik wrote: Please, review the following test change Issue : https://bugs.openjdk.java.net/browse/JDK-8069286 Webrev: http://cr.openjdk.java.net/~jbachorik/8069286/webrev.00