Re: RFR(S): 8059334: nsk/jvmti/scenarios/hotswap/HS201/hs201t001 fails with exit code 0 after timeout

I'm not an expert in this area of code, but I'm wondering about Vladimir's comment about ciEnv::jvmti_state_changed() in the bug report.  With your fix, maybe we don't need to check ciEnv::jvmti_state_changed() (which doesn't seem to be enough by itself) and throw away the compiled result.  We

RFR(S): 8059334: nsk/jvmti/scenarios/hotswap/HS201/hs201t001 fails with exit code 0 after timeout

Hello, Please review the following: https://bugs.openjdk.java.net/browse/JDK-8059334 http://cr.openjdk.java.net/~cjplummer/8059334/webrev.00/webrev.open/ The CR is closed, so I'll try to explain the issue here. The very short explanation is that the JVMTI test was enabling SINGLE STEP and

Re: RFR (S): 8187289 NotifyFramePop request is not cleared if JVMTI_EVENT_FRAME_POP is disabled

Dan, Thank you a lot for review! Serguei On 11/3/17 04:56, Daniel D. Daugherty wrote: > http://cr.openjdk.java.net/%7Esspitsyn/webrevs/2017/hotspot/8187289-jvmti-framepop.2/

Re: PING: RFR: 8165736: Error message should be shown when JVMTI agent cannot be attached

Hi Serguei, Thank you for your comment! I uploaded new webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8165736/webrev.01/ http://cr.openjdk.java.net/~ysuenaga/JDK-8165736/webrev.00/test/jdk/com/sun/tools/attach/StartManagementAgent.java.udiff.html - if (!ex.getMessage().contains("Invalid

Re: RFR (S): 8187289 NotifyFramePop request is not cleared if JVMTI_EVENT_FRAME_POP is disabled

> http://cr.openjdk.java.net/%7Esspitsyn/webrevs/2017/hotspot/8187289-jvmti-framepop.2/ make/test/JtregNativeHotspot.gmk     No comments. src/hotspot/share/prims/jvmtiEventController.cpp     No comments. src/hotspot/share/prims/jvmtiExport.cpp     No comments.

Re: RFR: (small): JDK-8190307: SA: Sanity tests for the clhsdb commands: universe, intconstant, type

Here is the updated webrev: http://cr.openjdk.java.net/~jgeorge/8190307/webrev.01/ I have made changes to validate the test results of each command separately, done away with the asserts and have added some more comments. Thank you, Jini. On 10/31/2017 12:32 PM, Jini George wrote: Thank

RE: RFR: SA: JDK-8189798: SA cleanup - part 1

Hi Jini, You have appended 'Field' for most of the SA variables. Example: private static CIntegerField pcOffsetField; pcOffsetField = type.getCIntegerField("_pc_offset"); However that is not the case in private static long MinChunkSizeInBytes; MinChunkSizeInBytes =

Re: PING: RFR: 8165736: Error message should be shown when JVMTI agent cannot be attached

Hi Yasumasa, Some comments. http://cr.openjdk.java.net/~ysuenaga/JDK-8165736/webrev.00/test/jdk/com/sun/tools/attach/StartManagementAgent.java.udiff.html -if (!ex.getMessage().contains("Invalid com.sun.management.jmxremote.port number")) { +